chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChrome.java - Issue 2499733002: Remove cached dp viewports in LayoutManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChrome.java

Issue 2499733002: Remove cached dp viewports in LayoutManager (Closed)

Patch Set: use Float.compare Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManager.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChrome.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChrome.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChrome.java

index 2aec35a8c3b86bf5a9771318ee357a196d96ebc5..8c12c50a040e0b35313972c46d3f27851acabb7a 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChrome.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChrome.java

@@ -105,11 +105,11 @@ public class LayoutManagerChrome

boolean incognito = tab.isIncognito();

boolean willBeSelected = launchType != TabLaunchType.FROM_LONGPRESS_BACKGROUND

|| (!getTabModelSelector().isIncognitoSelected() && incognito);

- float lastTapX = LocalizationUtils.isLayoutRtl() ? mLastContentWidthDp : 0.f;

+ float lastTapX = LocalizationUtils.isLayoutRtl()

+ ? mHost.getWidth() * mPxToDp : 0.f;

float lastTapY = 0.f;

if (launchType != TabLaunchType.FROM_CHROME_UI) {

- float heightDelta =

- mLastFullscreenViewportDp.height() - mLastVisibleViewportDp.height();

+ float heightDelta = mHeightMinusBrowserControlsPx * mPxToDp;

lastTapX = mPxToDp * mLastTapX;

lastTapY = mPxToDp * mLastTapY - heightDelta;

}