TransformTree::SetRootTransformsAndScales should set 'needs_update' on transform tree only if we ar…

TransformTree::SetRootTransformsAndScales should set 'needs_update' on
transform tree only if we are changing the transforms stored on the 
root or the contents_root node. Otherwise, we will end up updating 
transforms every frame.

NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=663068
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2490773002
Cr-Commit-Position: refs/heads/master@{#431000}
(cherry picked from commit b90ee7fe1cb7843f41100413e907c3e86c620ad7)

Committed: https://chromium.googlesource.com/chromium/src/+/2a4fc7ddcd6b0f9368d510f46882831d290fe9b7

patch from issue 2493943003 at patchset 1 (http://crrev.com/2493943003#ps1)

[jaydasika, 2016-11-11 20:30:26]

Description was changed from

==========
TransformTree::SetRootTransformsAndScales should set 'needs_update' on transform
tree only if we are changing the transforms stored on the root or the
contents_root node. Otherwise, we will end up updating transforms every frame.

BUG=663068
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2490773002
Cr-Commit-Position: refs/heads/master@{#431000}
(cherry picked from commit b90ee7fe1cb7843f41100413e907c3e86c620ad7)

Committed:
https://chromium.googlesource.com/chromium/src/+/2a4fc7ddcd6b0f9368d510f46882...

patch from issue 2493943003 at patchset 1 (http://crrev.com/2493943003#ps1)
==========

to

==========
TransformTree::SetRootTransformsAndScales should set 'needs_update' on
transform tree only if we are changing the transforms stored on the 
root or the contents_root node. Otherwise, we will end up updating 
transforms every frame.

BUG=663068
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2490773002
Cr-Commit-Position: refs/heads/master@{#431000}
(cherry picked from commit b90ee7fe1cb7843f41100413e907c3e86c620ad7)

Committed:
https://chromium.googlesource.com/chromium/src/+/2a4fc7ddcd6b0f9368d510f46882...

patch from issue 2493943003 at patchset 1 (http://crrev.com/2493943003#ps1)
==========

[jaydasika, 2016-11-11 20:31:52]

jaydasika@chromium.org changed reviewers:
+ weiliangc@chromium.org

[jaydasika, 2016-11-11 20:31:52]

For the CL on M55 we should be comparing surface contents scale instead of
ToScreen for the reason I mentioned here :
https://bugs.chromium.org/p/chromium/issues/detail?id=664408#c9

[weiliangc, 2016-11-11 20:36:32]

LGTM

[jaydasika, 2016-11-14 16:35:19]

The CQ bit was checked by jaydasika@chromium.org

[commit-bot: I haz the power, 2016-11-14 16:35:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 16:35:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 16:35:54]

CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true
and NOPRESUBMIT=true in order for the CQ to process them

[jaydasika, 2016-11-14 16:40:42]

Description was changed from

==========
TransformTree::SetRootTransformsAndScales should set 'needs_update' on
transform tree only if we are changing the transforms stored on the 
root or the contents_root node. Otherwise, we will end up updating 
transforms every frame.

BUG=663068
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2490773002
Cr-Commit-Position: refs/heads/master@{#431000}
(cherry picked from commit b90ee7fe1cb7843f41100413e907c3e86c620ad7)

Committed:
https://chromium.googlesource.com/chromium/src/+/2a4fc7ddcd6b0f9368d510f46882...

patch from issue 2493943003 at patchset 1 (http://crrev.com/2493943003#ps1)
==========

to

==========
TransformTree::SetRootTransformsAndScales should set 'needs_update' on
transform tree only if we are changing the transforms stored on the 
root or the contents_root node. Otherwise, we will end up updating 
transforms every frame.

BUG=663068
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2490773002
Cr-Commit-Position: refs/heads/master@{#431000}
(cherry picked from commit b90ee7fe1cb7843f41100413e907c3e86c620ad7)

Committed:
https://chromium.googlesource.com/chromium/src/+/2a4fc7ddcd6b0f9368d510f46882...

patch from issue 2493943003 at patchset 1 (http://crrev.com/2493943003#ps1)
NOTRY=true
NOPRESUBMIT=true
==========

[jaydasika, 2016-11-14 16:40:48]

The CQ bit was checked by jaydasika@chromium.org

[commit-bot: I haz the power, 2016-11-14 16:41:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 18:56:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 18:56:53]

Failed to commit the patch.

[jaydasika, 2016-11-14 19:28:23]

Description was changed from

==========
TransformTree::SetRootTransformsAndScales should set 'needs_update' on
transform tree only if we are changing the transforms stored on the 
root or the contents_root node. Otherwise, we will end up updating 
transforms every frame.

BUG=663068
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2490773002
Cr-Commit-Position: refs/heads/master@{#431000}
(cherry picked from commit b90ee7fe1cb7843f41100413e907c3e86c620ad7)

Committed:
https://chromium.googlesource.com/chromium/src/+/2a4fc7ddcd6b0f9368d510f46882...

patch from issue 2493943003 at patchset 1 (http://crrev.com/2493943003#ps1)
NOTRY=true
NOPRESUBMIT=true
==========

to

==========
TransformTree::SetRootTransformsAndScales should set 'needs_update' on
transform tree only if we are changing the transforms stored on the 
root or the contents_root node. Otherwise, we will end up updating 
transforms every frame.

NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=663068
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2490773002
Cr-Commit-Position: refs/heads/master@{#431000}
(cherry picked from commit b90ee7fe1cb7843f41100413e907c3e86c620ad7)

Committed:
https://chromium.googlesource.com/chromium/src/+/2a4fc7ddcd6b0f9368d510f46882...

patch from issue 2493943003 at patchset 1 (http://crrev.com/2493943003#ps1)
==========

[jaydasika, 2016-11-14 19:28:29]

The CQ bit was checked by jaydasika@chromium.org

[jaydasika, 2016-11-14 19:28:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
weiliangc@chromium.org
Link to the patchset: https://codereview.chromium.org/2499683002/#ps20001
(title: "TransformTree::SetRootTransformsAndScales should set 'needs_update' on
transform tree only if we ar…")

[commit-bot: I haz the power, 2016-11-14 19:29:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 19:46:03]

Description was changed from

==========
TransformTree::SetRootTransformsAndScales should set 'needs_update' on
transform tree only if we are changing the transforms stored on the 
root or the contents_root node. Otherwise, we will end up updating 
transforms every frame.

NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=663068
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2490773002
Cr-Commit-Position: refs/heads/master@{#431000}
(cherry picked from commit b90ee7fe1cb7843f41100413e907c3e86c620ad7)

Committed:
https://chromium.googlesource.com/chromium/src/+/2a4fc7ddcd6b0f9368d510f46882...

patch from issue 2493943003 at patchset 1 (http://crrev.com/2493943003#ps1)
==========

to

==========
TransformTree::SetRootTransformsAndScales should set 'needs_update' on
transform tree only if we are changing the transforms stored on the 
root or the contents_root node. Otherwise, we will end up updating 
transforms every frame.

NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=663068
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2490773002
Cr-Commit-Position: refs/heads/master@{#431000}
(cherry picked from commit b90ee7fe1cb7843f41100413e907c3e86c620ad7)

Committed:
https://chromium.googlesource.com/chromium/src/+/2a4fc7ddcd6b0f9368d510f46882...

patch from issue 2493943003 at patchset 1 (http://crrev.com/2493943003#ps1)
==========

[commit-bot: I haz the power, 2016-11-14 19:46:04]

Committed patchset #2 (id:20001)