Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 2490773002: cc : Set 'needs update' on transform tree only when something changes (Closed)

Created:
4 years, 1 month ago by jaydasika
Modified:
4 years, 1 month ago
Reviewers:
ajuma, weiliangc
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

TransformTree::SetRootTransformsAndScales should set 'needs_update' on transform tree only if we are changing the transforms stored on the root or the contents_root node. Otherwise, we will end up updating transforms every frame. BUG=663068 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/b90ee7fe1cb7843f41100413e907c3e86c620ad7 Cr-Commit-Position: refs/heads/master@{#431000}

Patch Set 1 #

Patch Set 2 : unittest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -3 lines) Patch
M cc/trees/property_tree.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M cc/trees/property_tree_unittest.cc View 1 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
jaydasika
PTAL
4 years, 1 month ago (2016-11-08 23:54:11 UTC) #6
weiliangc
LGTM
4 years, 1 month ago (2016-11-09 16:42:16 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2490773002/20001
4 years, 1 month ago (2016-11-09 19:08:17 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-09 19:13:45 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-09 19:17:20 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b90ee7fe1cb7843f41100413e907c3e86c620ad7
Cr-Commit-Position: refs/heads/master@{#431000}

Powered by Google App Engine
This is Rietveld 408576698