Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1393)

Unified Diff: cc/trees/property_tree_unittest.cc

Issue 2499683002: TransformTree::SetRootTransformsAndScales should set 'needs_update' on transform tree only if we ar… (Closed)
Patch Set: TransformTree::SetRootTransformsAndScales should set 'needs_update' on transform tree only if we ar… Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/trees/property_tree.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/property_tree_unittest.cc
diff --git a/cc/trees/property_tree_unittest.cc b/cc/trees/property_tree_unittest.cc
index d85f0be7affa5460961eb92216d35ea9795664d5..b2f5a78d41464fec090eea1226cdf8b141f58716 100644
--- a/cc/trees/property_tree_unittest.cc
+++ b/cc/trees/property_tree_unittest.cc
@@ -421,6 +421,28 @@ class PropertyTreeTestComputeTransformRoot : public PropertyTreeTest {
DIRECT_AND_SERIALIZED_PROPERTY_TREE_TEST_F(
PropertyTreeTestComputeTransformRoot);
+class PropertyTreeTestSetNeedsUpdate : public PropertyTreeTest {
+ protected:
+ void StartTest() override {
+ PropertyTrees property_trees;
+ TransformTree& tree = property_trees.transform_tree;
+ TransformNode contents_root;
+ contents_root.source_node_id = 0;
+ contents_root.id = tree.Insert(contents_root, 0);
+ tree.SetTargetId(contents_root.id, 0);
+ SetupTransformTreeForTest(&tree);
+
+ EXPECT_FALSE(tree.needs_update());
+ tree.SetRootTransformsAndScales(0.6f, 1.f, gfx::Transform(), gfx::PointF());
+ EXPECT_TRUE(tree.needs_update());
+ tree.set_needs_update(false);
+ tree.SetRootTransformsAndScales(0.6f, 1.f, gfx::Transform(), gfx::PointF());
+ EXPECT_FALSE(tree.needs_update());
+ }
+};
+
+DIRECT_AND_SERIALIZED_PROPERTY_TREE_TEST_F(PropertyTreeTestSetNeedsUpdate);
+
class PropertyTreeTestComputeTransformChild : public PropertyTreeTest {
protected:
void StartTest() override {
« no previous file with comments | « cc/trees/property_tree.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698