[chromecast] Make testnames consistent.

[chromecast] Make testnames consistent.

Note that cast_shell_tests were not being run on the bots. This patch
moves it into a top-level cast_shell_unittests target.

BUG=665489
TBR=dpranke,sky

Committed: https://crrev.com/98afc7db00a7bfe749914e4d618ccb9cc76cbb97
Cr-Commit-Position: refs/heads/master@{#432225}

[alokp, 2016-11-14 21:15:36]

alokp@chromium.org changed reviewers:
+ derekjchow@chromium.org, halliwell@chromium.org

[alokp, 2016-11-14 21:15:37]

https://codereview.chromium.org/2499563002/diff/80001/chromecast/browser/cast...
File chromecast/browser/cast_media_blocker_unittest.cc (right):

https://codereview.chromium.org/2499563002/diff/80001/chromecast/browser/cast...
chromecast/browser/cast_media_blocker_unittest.cc:82:
TEST_F(CastMediaBlockerTest, DISABLED_Block_Unblock_Suspended) {
Disabled because these tests never built or executed on cast_shell_linux bots. I
have included these in the build and fixed compile errors.

https://codereview.chromium.org/2499563002/diff/80001/chromecast/browser/test...
File chromecast/browser/test/chromecast_browser_test_runner.cc (left):

https://codereview.chromium.org/2499563002/diff/80001/chromecast/browser/test...
chromecast/browser/test/chromecast_browser_test_runner.cc:22: class
BrowserTestSuite : public content::ContentTestSuiteBase {
Now we use a common test launcher for both unittests and browsertests. It is
implemented in app/cast_test_launcher.cc

[derekjchow1, 2016-11-15 17:31:06]

lgtm

[alokp, 2016-11-15 17:45:34]

Description was changed from

==========
[chromecast] Make testnames consistent.

Note that cast_shell_tests were not being run on the bots. This patch
moves it into a top-level cast_shell_unittests target.

BUG=663067
==========

to

==========
[chromecast] Make testnames consistent.

Note that cast_shell_tests were not being run on the bots. This patch
moves it into a top-level cast_shell_unittests target.

BUG=665489
==========

[alokp, 2016-11-15 17:45:50]

The CQ bit was checked by alokp@chromium.org

[commit-bot: I haz the power, 2016-11-15 17:46:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 18:07:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 18:07:07]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[alokp, 2016-11-15 18:24:24]

Description was changed from

==========
[chromecast] Make testnames consistent.

Note that cast_shell_tests were not being run on the bots. This patch
moves it into a top-level cast_shell_unittests target.

BUG=665489
==========

to

==========
[chromecast] Make testnames consistent.

Note that cast_shell_tests were not being run on the bots. This patch
moves it into a top-level cast_shell_unittests target.

BUG=665489
TBR=dpranke,sky
==========

[alokp, 2016-11-15 18:25:07]

On 2016/11/15 18:07:07, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

TBR'ing sky@ and dpranke@ as we are not adding any new dependencies - just
moving them around.

[alokp, 2016-11-15 18:25:16]

The CQ bit was checked by alokp@chromium.org

[commit-bot: I haz the power, 2016-11-15 18:25:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 18:52:11]

Description was changed from

==========
[chromecast] Make testnames consistent.

Note that cast_shell_tests were not being run on the bots. This patch
moves it into a top-level cast_shell_unittests target.

BUG=665489
TBR=dpranke,sky
==========

to

==========
[chromecast] Make testnames consistent.

Note that cast_shell_tests were not being run on the bots. This patch
moves it into a top-level cast_shell_unittests target.

BUG=665489
TBR=dpranke,sky
==========

[commit-bot: I haz the power, 2016-11-15 18:52:13]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-11-15 19:05:53]

Description was changed from

==========
[chromecast] Make testnames consistent.

Note that cast_shell_tests were not being run on the bots. This patch
moves it into a top-level cast_shell_unittests target.

BUG=665489
TBR=dpranke,sky
==========

to

==========
[chromecast] Make testnames consistent.

Note that cast_shell_tests were not being run on the bots. This patch
moves it into a top-level cast_shell_unittests target.

BUG=665489
TBR=dpranke,sky

Committed: https://crrev.com/98afc7db00a7bfe749914e4d618ccb9cc76cbb97
Cr-Commit-Position: refs/heads/master@{#432225}
==========

[commit-bot: I haz the power, 2016-11-15 19:05:54]

Patchset 6 (id:??) landed as
https://crrev.com/98afc7db00a7bfe749914e4d618ccb9cc76cbb97
Cr-Commit-Position: refs/heads/master@{#432225}

[Dirk Pranke, 2016-11-15 23:39:18]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/2502143002/ by dpranke@chromium.org.

The reason for reverting is: This broke the cast_shell_linux builder, because
gn_isolate_map.pyl was not updated correctly, causing the analyze step to fail,
e.g.:

https://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_lin...

Unfortunately, because the //testing files (and some of the BUILD.gn files) were
changed, we bypassed the actual analyze invocation, so we didn't notice this in
the try jobs..

[Dirk Pranke, 2016-11-15 23:42:29]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-11-15 23:42:30]

Why did you TBR this?

https://codereview.chromium.org/2499563002/diff/100001/testing/buildbot/gn_is...
File testing/buildbot/gn_isolate_map.pyl (right):

https://codereview.chromium.org/2499563002/diff/100001/testing/buildbot/gn_is...
testing/buildbot/gn_isolate_map.pyl:228: "label":
"//chromecast/browser:cast_shell_browsertests",
You needed to change the labels for these two targets, since you moved them to
//chromecast/BUILD.gn.