Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11970)

Unified Diff: chromecast/browser/test/cast_browser_test.cc

Issue 2499563002: [chromecast] Make testnames consistent. (Closed)
Patch Set: removes mojo dependency Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/browser/test/cast_browser_test.cc
diff --git a/chromecast/browser/test/chromecast_browser_test.cc b/chromecast/browser/test/cast_browser_test.cc
similarity index 73%
rename from chromecast/browser/test/chromecast_browser_test.cc
rename to chromecast/browser/test/cast_browser_test.cc
index 5bc37200ae111b2a1b087047a2d72422bc632cf2..781d2492fbbbb1ec114411537a371122f44242a8 100644
--- a/chromecast/browser/test/chromecast_browser_test.cc
+++ b/chromecast/browser/test/cast_browser_test.cc
@@ -2,11 +2,12 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "chromecast/browser/test/chromecast_browser_test.h"
+#include "chromecast/browser/test/cast_browser_test.h"
#include "base/command_line.h"
#include "base/logging.h"
#include "base/run_loop.h"
+#include "chromecast/base/chromecast_switches.h"
#include "chromecast/base/metrics/cast_metrics_helper.h"
#include "chromecast/browser/cast_browser_context.h"
#include "chromecast/browser/cast_browser_process.h"
@@ -14,30 +15,38 @@
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/render_process_host.h"
#include "content/public/browser/web_contents.h"
+#include "content/public/common/content_switches.h"
#include "content/public/test/browser_test_utils.h"
#include "content/public/test/test_navigation_observer.h"
namespace chromecast {
namespace shell {
-ChromecastBrowserTest::ChromecastBrowserTest() {}
+CastBrowserTest::CastBrowserTest() {}
-ChromecastBrowserTest::~ChromecastBrowserTest() {}
+CastBrowserTest::~CastBrowserTest() {}
-void ChromecastBrowserTest::SetUp() {
+void CastBrowserTest::SetUp() {
SetUpCommandLine(base::CommandLine::ForCurrentProcess());
BrowserTestBase::SetUp();
}
-void ChromecastBrowserTest::TearDownOnMainThread() {
+void CastBrowserTest::TearDownOnMainThread() {
web_contents_.reset();
window_.reset();
BrowserTestBase::TearDownOnMainThread();
}
-void ChromecastBrowserTest::RunTestOnMainThreadLoop() {
+void CastBrowserTest::SetUpCommandLine(base::CommandLine* command_line) {
+ BrowserTestBase::SetUpCommandLine(command_line);
+
+ command_line->AppendSwitch(switches::kNoWifi);
+ command_line->AppendSwitchASCII(switches::kTestType, "browser");
+}
+
+void CastBrowserTest::RunTestOnMainThreadLoop() {
// Pump startup related events.
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
base::RunLoop().RunUntilIdle();
@@ -49,7 +58,7 @@ void ChromecastBrowserTest::RunTestOnMainThreadLoop() {
TearDownOnMainThread();
}
-content::WebContents* ChromecastBrowserTest::NavigateToURL(const GURL& url) {
+content::WebContents* CastBrowserTest::NavigateToURL(const GURL& url) {
window_ = base::MakeUnique<CastContentWindow>();
web_contents_ = window_->CreateWebContents(

Powered by Google App Engine
This is Rietveld 408576698