Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(864)

Unified Diff: chromecast/browser/BUILD.gn

Issue 2499563002: [chromecast] Make testnames consistent. (Closed)
Patch Set: removes mojo dependency Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/browser/BUILD.gn
diff --git a/chromecast/browser/BUILD.gn b/chromecast/browser/BUILD.gn
index fc29e23076a672f19ae9cc30d979c5193200c975..9937c5447fdc83c0aa29ce44202fb7aba3703ddb 100644
--- a/chromecast/browser/BUILD.gn
+++ b/chromecast/browser/BUILD.gn
@@ -158,22 +158,18 @@ grit("resources") {
source_set("test_support") {
testonly = true
-
sources = [
- "test/chromecast_browser_test.cc",
- "test/chromecast_browser_test.h",
- "test/chromecast_browser_test_runner.cc",
+ "test/cast_browser_test.cc",
+ "test/cast_browser_test.h",
]
public_deps = [
":browser",
- "//chromecast:cast_shell_lib",
"//content/test:test_support",
]
deps = [
"//base",
- "//chromecast/app",
"//chromecast/base",
"//content/public/browser",
"//content/public/common",
@@ -181,51 +177,37 @@ source_set("test_support") {
]
}
-config("browser_test_config") {
- defines = [ "HAS_OUT_OF_PROC_TEST_RUNNER" ]
-}
-
-test("cast_shell_tests") {
+source_set("browsertests") {
+ testonly = true
sources = [
- "test/cast_devtools_delegate_test.cc",
- "test/cast_media_blocker_test.cc",
- "test/cast_test_launcher.cc",
+ "cast_media_blocker_browsertest.cc",
+ "test/cast_navigation_browsertest.cc",
]
+ defines = [ "HAS_OUT_OF_PROC_TEST_RUNNER" ]
+
deps = [
- ":browser",
- "//base",
- "//chromecast/app",
- "//chromecast/base",
- "//content/test:test_support",
- "//mojo/edk/system",
- "//testing/gtest",
+ ":test_support",
+ "//chromecast:chromecast_features",
+ "//media/base:test_support",
]
}
-test("cast_shell_browser_test") {
+source_set("unittests") {
+ testonly = true
+
sources = [
- "test/chromecast_shell_browser_test.cc",
- "test/chromecast_shell_media_blocking_browser_test.cc",
+ "cast_media_blocker_unittest.cc",
+ "devtools/cast_devtools_manager_delegate_unittest.cc",
]
- configs += [ ":browser_test_config" ]
-
deps = [
- ":test_support",
+ ":browser",
"//base",
- "//chromecast:chromecast_features",
+ "//chromecast/base",
+ "//content/public/browser",
"//content/test:test_support",
- "//media/base:test_support",
- "//testing/gtest",
- "//url",
]
-
- if (chromecast_branding == "public") {
- # Link default libcast_media_1.0 statically not to link dummy one
- # dynamically for public unittests.
- deps += [ "//chromecast/media/base:libcast_media_1.0_default_core" ]
- }
}
if (is_android) {

Powered by Google App Engine
This is Rietveld 408576698