Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6223)

Unified Diff: chrome/browser/extensions/extension_management_unittest.cc

Issue 2499493004: Communicate ExtensionSettings policy to renderers (Closed)
Patch Set: Add URLPattern effective TLD whitelisting, Switched IPC to UpdatePermissions, Removed shared memor… Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_management_unittest.cc
diff --git a/chrome/browser/extensions/extension_management_unittest.cc b/chrome/browser/extensions/extension_management_unittest.cc
index 176e7ca8eb47203ce4b8d25b2dc94a09f856eebf..2ad09f11926e88e70921b14153070e8532981b36 100644
--- a/chrome/browser/extensions/extension_management_unittest.cc
+++ b/chrome/browser/extensions/extension_management_unittest.cc
@@ -125,7 +125,7 @@ class ExtensionManagementServiceTest : public testing::Test {
return extension_management_->global_settings_.get();
}
- const URLPatternSet& GetRuntimeBlockedHostsById(const std::string& id) {
Devlin 2017/01/26 22:47:39 Why this change?
nrpeter 2017/02/03 19:32:24 It was a syntax issue I didn't detect earlier by c
+ URLPatternSet GetRuntimeBlockedHostsById(const std::string& id) {
return GetRuntimeBlockedHosts(id, kNonExistingUpdateUrl);
}
@@ -441,7 +441,7 @@ TEST_F(ExtensionManagementServiceTest, PreferenceParsing) {
ExtensionManagement::INSTALLATION_BLOCKED);
EXPECT_EQ(GetInstallationModeByUpdateUrl(kExampleUpdateUrl),
ExtensionManagement::INSTALLATION_ALLOWED);
- EXPECT_TRUE(GetRuntimeBlockedHostsById(kTargetExtension).empty());
+ EXPECT_TRUE(GetRuntimeBlockedHostsById(kTargetExtension).is_empty());
EXPECT_TRUE(GetRuntimeBlockedHostsById(kTargetExtension4)
.MatchesURL(GURL("http://test.foo.com/test")));
EXPECT_TRUE(GetRuntimeBlockedHostsById(kTargetExtension4)

Powered by Google App Engine
This is Rietveld 408576698