Communicate ExtensionSettings policy to renderers

chrome/browser/extensions/extension_service.cc

Index: chrome/browser/extensions/extension_service.cc
diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc
index 4cecaddab3e02cc9e9697c9d3f7a01d4ab746468..194199637d74cb22228397f81232bab69e0cde55 100644
--- a/chrome/browser/extensions/extension_service.cc
+++ b/chrome/browser/extensions/extension_service.cc
@@ -866,11 +866,18 @@ void ExtensionService::EnableExtension(const std::string& extension_id) {
   const Extension* extension =
       registry_->disabled_extensions().GetByID(extension_id);
 
+  extensions::ExtensionManagement* management =
+      extensions::ExtensionManagementFactory::GetForBrowserContext(profile());
+
   ManagementPolicy* policy = system_->management_policy();
   if (extension && policy->MustRemainDisabled(extension, nullptr, nullptr)) {
     UMA_HISTOGRAM_COUNTS_100("Extensions.EnableDeniedByPolicy", 1);
     return;
   }
+  extensions::PermissionsUpdater(profile()).SetPolicyHostRestrictions(

[Devlin, 2017/01/26 22:47:39]

We seem to be calling this an awful lot.  We should instead be able to hook into
one or two places.

Basically, I'd expect that we can merge SetPolicyHostRestrictions with
PermissionsUpdater::InitializePermissions(), which is already called when the
extension is added.  We will have to update if we find a new policy, but
otherwise that should cover all our bases, right?

[nrpeter, 2017/02/03 19:32:24]

The call under CheckManagementPolicy handles the situation where the policy
changes and the renderers need the new policy so I think it makes sense to leave
it.

The calls under OnLoadedInstalledExtensions, AddExtension, EnableExtension were
unnecessary and I removed them.

The AddExtension call is covered by RendererStartupHelper::InitializeProcess. 

The EnableExtension and OnLoadedInstalledExtensions is covered by
RendererStartupHelper::OnExtensionLoaded which already communicates the
permissions to all existing renderers.

+      extension, management->GetRuntimeBlockedHosts(extension),
+      management->GetRuntimeAllowedHosts(extension),
+      management->UsesDefaultRuntimeHostRestrictions(extension));
 
   extension_prefs_->SetExtensionEnabled(extension_id);
 
@@ -1212,6 +1219,16 @@ void ExtensionService::CheckManagementPolicy() {
 
   extensions::ExtensionManagement* management =
       extensions::ExtensionManagementFactory::GetForBrowserContext(profile());
+  for (const auto& extension : registry_->enabled_extensions()) {
+    extensions::PermissionsUpdater(profile()).SetPolicyHostRestrictions(
+        extension.get(), management->GetRuntimeBlockedHosts(extension.get()),
+        management->GetRuntimeAllowedHosts(extension.get()),
+        management->UsesDefaultRuntimeHostRestrictions(extension.get()));
+  }
+  extensions::PermissionsUpdater(profile())
+      .SetDefaultPolicyHostRestrictions(
+          management->GetDefaultRuntimeBlockedHosts(),
+          management->GetDefaultRuntimeAllowedHosts());
 
   // Loop through the disabled extension list, find extensions to re-enable
   // automatically. These extensions are exclusive from the |to_disable| and
@@ -1443,6 +1460,13 @@ void ExtensionService::OnLoadedInstalledExtensions() {
     if (SharedModuleInfo::IsSharedModule(extension.get()))
       to_enable.push_back(extension);
   }
+  extensions::ExtensionManagement* management =
+      extensions::ExtensionManagementFactory::GetForBrowserContext(profile());
+  extensions::PermissionsUpdater(profile())
+      .SetDefaultPolicyHostRestrictions(
+          management->GetDefaultRuntimeBlockedHosts(),
+          management->GetDefaultRuntimeAllowedHosts());
+
   for (const auto& extension : to_enable) {
     EnableExtension(extension->id());
   }
@@ -1461,6 +1485,14 @@ void ExtensionService::AddExtension(const Extension* extension) {
     return;
   }
 
+  extensions::ExtensionManagement* settings =
+      extensions::ExtensionManagementFactory::GetForBrowserContext(profile());
+  DCHECK(settings);
+  extensions::PermissionsUpdater(profile()).SetPolicyHostRestrictions(
+      extension, settings->GetRuntimeBlockedHosts(extension),
+      settings->GetRuntimeAllowedHosts(extension),
+      settings->UsesDefaultRuntimeHostRestrictions(extension));
+
   bool is_extension_upgrade = false;
   bool is_extension_loaded = false;
   const Extension* old = GetInstalledExtension(extension->id());