Communicate ExtensionSettings policy to renderers

chrome/browser/extensions/extension_management_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_management.h"
 
 #include <algorithm>
 #include <memory>
 #include <string>
 #include <vector>
@@ skipping 107 matching lines @@
     if (managed)
       pref_service_->RemoveManagedPref(path);
     else
       pref_service_->RemoveUserPref(path);
   }
 
   const internal::GlobalSettings* ReadGlobalSettings() {
     return extension_management_->global_settings_.get();
   }
 
-  const URLPatternSet& GetRuntimeBlockedHostsById(const std::string& id) {

[Devlin, 2017/01/26 22:47:39]

Why this change?

[nrpeter, 2017/02/03 19:32:24]

It was a syntax issue I didn't detect earlier by compiling unit_tests.

This function isn't actually necessary since RuntimeBlockedHosts is only ever
queried via ID. I went ahead and removed this function and simplified
GetRuntimeBlockedHosts.

+  URLPatternSet GetRuntimeBlockedHostsById(const std::string& id) {
     return GetRuntimeBlockedHosts(id, kNonExistingUpdateUrl);
   }
 
   ExtensionManagement::InstallationMode GetInstallationModeById(
       const std::string& id) {
     return GetInstallationMode(id, kNonExistingUpdateUrl);
   }
 
   ExtensionManagement::InstallationMode GetInstallationModeByUpdateUrl(
       const std::string& update_url) {
@@ skipping 295 matching lines @@
   EXPECT_EQ(GetInstallationModeById(kTargetExtension2),
             ExtensionManagement::INSTALLATION_FORCED);
   CheckAutomaticallyInstalledUpdateUrl(kTargetExtension2, kExampleUpdateUrl);
   EXPECT_EQ(GetInstallationModeById(kTargetExtension3),
             ExtensionManagement::INSTALLATION_RECOMMENDED);
   CheckAutomaticallyInstalledUpdateUrl(kTargetExtension3, kExampleUpdateUrl);
   EXPECT_EQ(GetInstallationModeById(kNonExistingExtension),
             ExtensionManagement::INSTALLATION_BLOCKED);
   EXPECT_EQ(GetInstallationModeByUpdateUrl(kExampleUpdateUrl),
             ExtensionManagement::INSTALLATION_ALLOWED);
-  EXPECT_TRUE(GetRuntimeBlockedHostsById(kTargetExtension).empty());
+  EXPECT_TRUE(GetRuntimeBlockedHostsById(kTargetExtension).is_empty());
   EXPECT_TRUE(GetRuntimeBlockedHostsById(kTargetExtension4)
                   .MatchesURL(GURL("http://test.foo.com/test")));
   EXPECT_TRUE(GetRuntimeBlockedHostsById(kTargetExtension4)
                   .MatchesURL(GURL("https://bar.org/test")));
 
   // Verifies global settings.
   EXPECT_TRUE(ReadGlobalSettings()->has_restricted_install_sources);
   const URLPatternSet& allowed_sites = ReadGlobalSettings()->install_sources;
   EXPECT_EQ(allowed_sites.size(), 1u);
   EXPECT_TRUE(allowed_sites.MatchesURL(GURL("http://foo.com/entry")));
@@ skipping 447 matching lines @@
   EXPECT_FALSE(error.empty());
 
   CreateExtension(Manifest::INTERNAL);
   error.clear();
   EXPECT_FALSE(MustRemainEnabled(extension_.get(), NULL));
   EXPECT_FALSE(MustRemainEnabled(extension_.get(), &error));
   EXPECT_TRUE(error.empty());
 }
 
 }  // namespace extensions