Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1642)

Unified Diff: content/public/browser/navigation_handle.h

Issue 2499313003: Set user_gesture bit at NavigationHandle creation time. (Closed)
Patch Set: remove gesture dcheck Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/navigation_params.cc ('k') | content/public/browser/navigation_handle.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/navigation_handle.h
diff --git a/content/public/browser/navigation_handle.h b/content/public/browser/navigation_handle.h
index f2506c82dce30a5df29d0599180cd8268f09ae2a..49149a14ed2f71e1b600a8d22be6905cb2f74b90 100644
--- a/content/public/browser/navigation_handle.h
+++ b/content/public/browser/navigation_handle.h
@@ -196,7 +196,8 @@ class CONTENT_EXPORT NavigationHandle {
const GURL& url,
RenderFrameHost* render_frame_host,
bool committed = false,
- net::Error error = net::OK);
+ net::Error error = net::OK,
+ bool has_user_gesture = false);
clamy 2016/11/21 16:50:46 Should this take a NavigationGesture as well?
Bryan McQuade 2016/11/22 14:13:03 NavigationGesture isn't currently part of the publ
// Registers a NavigationThrottle for tests. The throttle can
// modify the request, pause the request or cancel the request. This will
@@ -212,7 +213,6 @@ class CONTENT_EXPORT NavigationHandle {
virtual NavigationThrottle::ThrottleCheckResult
CallWillStartRequestForTesting(bool is_post,
const Referrer& sanitized_referrer,
- bool has_user_gesture,
ui::PageTransition transition,
bool is_external_protocol) = 0;
« no previous file with comments | « content/common/navigation_params.cc ('k') | content/public/browser/navigation_handle.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698