Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1442)

Unified Diff: content/common/navigation_params.cc

Issue 2499313003: Set user_gesture bit at NavigationHandle creation time. (Closed)
Patch Set: remove gesture dcheck Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/navigation_params.cc
diff --git a/content/common/navigation_params.cc b/content/common/navigation_params.cc
index d6d1eb1abaafe537f722ff4ff2a496ea0fdc7030..2457037185ee418288546b8151ae3d84a782a7b0 100644
--- a/content/common/navigation_params.cc
+++ b/content/common/navigation_params.cc
@@ -81,19 +81,19 @@ CommonNavigationParams::~CommonNavigationParams() {
BeginNavigationParams::BeginNavigationParams()
: load_flags(0),
- has_user_gesture(false),
+ gesture(NavigationGestureAuto),
skip_service_worker(false),
request_context_type(REQUEST_CONTEXT_TYPE_LOCATION) {}
BeginNavigationParams::BeginNavigationParams(
std::string headers,
int load_flags,
- bool has_user_gesture,
+ NavigationGesture gesture,
bool skip_service_worker,
RequestContextType request_context_type)
: headers(headers),
load_flags(load_flags),
- has_user_gesture(has_user_gesture),
+ gesture(gesture),
skip_service_worker(skip_service_worker),
request_context_type(request_context_type) {}
@@ -135,7 +135,7 @@ RequestNavigationParams::RequestNavigationParams()
should_clear_history_list(false),
should_create_service_worker(false),
service_worker_provider_id(kInvalidServiceWorkerProviderId),
- has_user_gesture(false) {}
+ gesture(NavigationGestureAuto) {}
RequestNavigationParams::RequestNavigationParams(
bool is_overriding_user_agent,
@@ -153,7 +153,7 @@ RequestNavigationParams::RequestNavigationParams(
int current_history_list_length,
bool is_view_source,
bool should_clear_history_list,
- bool has_user_gesture)
+ NavigationGesture gesture)
: is_overriding_user_agent(is_overriding_user_agent),
redirects(redirects),
can_load_local_resources(can_load_local_resources),
@@ -171,7 +171,7 @@ RequestNavigationParams::RequestNavigationParams(
should_clear_history_list(should_clear_history_list),
should_create_service_worker(false),
service_worker_provider_id(kInvalidServiceWorkerProviderId),
- has_user_gesture(has_user_gesture) {}
+ gesture(gesture) {}
RequestNavigationParams::RequestNavigationParams(
const RequestNavigationParams& other) = default;

Powered by Google App Engine
This is Rietveld 408576698