Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2524763002: make NavigationGesture part of public content API and use it outside content (Closed)

Created:
4 years ago by Bryan McQuade
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, loading-reviews+metrics_chromium.org, csharrison+watch_chromium.org, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

make NavigationGesture part of public content API and use it outside content BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -65 lines) Patch
M chrome/browser/page_load_metrics/page_load_tracker.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/plugins/flash_download_interception.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/plugins/flash_download_interception_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/navigation_interception/intercept_navigation_throttle.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/navigation_interception/navigation_params.h View 4 chunks +4 lines, -3 lines 0 comments Download
M components/navigation_interception/navigation_params.cc View 4 chunks +4 lines, -6 lines 0 comments Download
M content/browser/frame_host/navigation_handle_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/navigation_handle_impl.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M content/common/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/frame_messages.h View 2 chunks +1 line, -1 line 0 comments Download
D content/common/navigation_gesture.h View 1 chunk +0 lines, -24 lines 0 comments Download
M content/common/navigation_params.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/view_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/navigation_handle.h View 3 chunks +7 lines, -6 lines 0 comments Download
M content/public/browser/navigation_handle.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M content/public/common/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A + content/public/common/navigation_gesture.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 2499313003 Patch 290001

Messages

Total messages: 5 (5 generated)
Bryan McQuade
Description was changed from ========== make NavigationGesture part of public content API and use it ...
4 years ago (2016-11-22 13:58:28 UTC) #1
Bryan McQuade
The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run
4 years ago (2016-11-22 13:58:30 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2524763002/1
4 years ago (2016-11-22 13:58:43 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years ago (2016-11-22 14:28:51 UTC) #4
commit-bot: I haz the power
4 years ago (2016-11-22 14:28:51 UTC) #5 
Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

Powered by Google App Engine
This is Rietveld 408576698