Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2499083002: [ObjC ARC] Converts ios/chrome/browser/browser_state:browser_state_impl. (Closed)

Created:
4 years, 1 month ago by stkhapugin
Modified:
4 years, 1 month ago
Reviewers:
sdefresne
CC:
chromium-reviews, mac-reviews_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/browser_state:browser_state_impl. Notable changes:none BUG=665024 Committed: https://crrev.com/c610262d11a225c916a026a4dec70c48890b1f88 Cr-Commit-Position: refs/heads/master@{#433866}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M ios/chrome/browser/browser_state/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M ios/chrome/browser/browser_state/browser_state_keyed_service_factories.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/browser_state/chrome_browser_state_impl_io_data.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/browser_state/chrome_browser_state_removal_controller.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/browser_state/off_the_record_chrome_browser_state_io_data.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (6 generated)
stkhapugin
This issue has passed the downstream tests
4 years, 1 month ago (2016-11-16 11:46:39 UTC) #1
sdefresne
lgtm
4 years, 1 month ago (2016-11-16 16:37:47 UTC) #3
commit-bot: I haz the power
This CL has an open dependency (Issue 2502673002 Patch 1). Please resolve the dependency and ...
4 years, 1 month ago (2016-11-16 16:47:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2499083002/1
4 years, 1 month ago (2016-11-22 14:25:34 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-22 15:42:44 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 15:44:20 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c610262d11a225c916a026a4dec70c48890b1f88
Cr-Commit-Position: refs/heads/master@{#433866}

Powered by Google App Engine
This is Rietveld 408576698