Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Issue 2502673002: [ObjC ARC] Converts ios/chrome/browser/browser_state to ARC. (Closed)

Created:
4 years, 1 month ago by stkhapugin
Modified:
4 years ago
CC:
chromium-reviews, mac-reviews_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/browser_state to ARC. Notable changes: none. BUG=665024 Committed: https://crrev.com/b3857608c8682df22c86ea1820a761a319cec541 Cr-Commit-Position: refs/heads/master@{#433538}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M ios/chrome/browser/browser_state/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M ios/chrome/browser/browser_state/chrome_browser_state.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (4 generated)
stkhapugin
PTAL. This issue passed downstream tests.
4 years, 1 month ago (2016-11-16 13:29:28 UTC) #2
noyau (Ping after 24h)
lgtm
4 years, 1 month ago (2016-11-16 13:34:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2502673002/1
4 years ago (2016-11-21 12:22:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-21 14:34:23 UTC) #7
commit-bot: I haz the power
4 years ago (2016-11-21 14:38:32 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b3857608c8682df22c86ea1820a761a319cec541
Cr-Commit-Position: refs/heads/master@{#433538}

Powered by Google App Engine
This is Rietveld 408576698