Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 2495353002: [ObjC ARC] Converts ios/chrome/browser/browser_state:test_support (Closed)

Created:
4 years, 1 month ago by stkhapugin
Modified:
4 years ago
CC:
chromium-reviews, mac-reviews_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/browser_state:test_support Notable changes: none BUG=665024 Committed: https://crrev.com/d43013c5d52b5cefb20b2f4537d8b48ebe6c0ac4 Cr-Commit-Position: refs/heads/master@{#436277}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M ios/chrome/browser/browser_state/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M ios/chrome/browser/browser_state/test_chrome_browser_state.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/browser_state/test_chrome_browser_state_isolated_context.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (8 generated)
stkhapugin
PTAL. This CL has passed downstream tests.
4 years, 1 month ago (2016-11-15 13:12:59 UTC) #2
Eugene But (OOO till 7-30)
lgtm
4 years, 1 month ago (2016-11-15 17:00:35 UTC) #3
commit-bot: I haz the power
This CL has an open dependency (Issue 2499083002 Patch 1). Please resolve the dependency and ...
4 years, 1 month ago (2016-11-15 17:15:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2495353002/1
4 years ago (2016-11-24 12:54:11 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/321628)
4 years ago (2016-11-24 15:17:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2495353002/1
4 years ago (2016-12-05 12:33:28 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-05 13:40:51 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-05 13:42:37 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d43013c5d52b5cefb20b2f4537d8b48ebe6c0ac4
Cr-Commit-Position: refs/heads/master@{#436277}

Powered by Google App Engine
This is Rietveld 408576698