[Sync] Introduce SyncedSessionWindow type.

[Sync] Introduce SyncedSessionWindow type.

Because we now need to maintain state outside of the normal SessionWindow
struct, this patch introduces a SyncedSessionWindow type. It wraps a
normal SessionWindow, while allowing tab sync to track additional window
information.

As part of this patch, I've also cleaned up the unused variation ids.
Moving forward, nothing sync specific should need to be in
SessionWindow. We'll probably need to add a wrapper
for SessionTab in the future as well.

The patch itself does not have any behavioral impact, but paves the way for
consuming sync window type information.

BUG=639009
TBR=bauerb, skuhne, thestig

Review-Url: https://codereview.chromium.org/2499023004
Cr-Commit-Position: refs/heads/master@{#460510}
Committed: https://chromium.googlesource.com/chromium/src/+/325508e90dc01afb4d6332510fc83d39c74c96f0

[Nicolas Zea, 2016-11-15 01:02:40]

The CQ bit was checked by zea@chromium.org to run a CQ dry run

[Nicolas Zea, 2016-11-15 01:03:43]

Description was changed from

==========
[Sync] Introduce SyncedSessionWindow type.

Because we now need to maintain state outside of the normal SessionWindow
struct, this patch introduces a SyncedSessionWindow type. It wraps a
normal SessionWindow, while allowing tab sync to track additional window
information.

As part of this patch, I've also cleaned up the unused variation ids and
migrated TabLink to use unique ptr.

The patch itself does not have any behavioral impact, but paves the way for
consuming sync window type information.

BUG=639009
==========

to

==========
[Sync] Introduce SyncedSessionWindow type.

Because we now need to maintain state outside of the normal SessionWindow
struct, this patch introduces a SyncedSessionWindow type. It wraps a
normal SessionWindow, while allowing tab sync to track additional window
information.

As part of this patch, I've also cleaned up the unused variation ids and
migrated TabLink to use unique ptr. Moving forward, nothing sync specific
should need to be in SessionWindow. We'll probably need to add a wrapper
for SessionTab in the future as well.

The patch itself does not have any behavioral impact, but paves the way for
consuming sync window type information.

BUG=639009
==========

[commit-bot: I haz the power, 2016-11-15 01:03:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 01:09:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 01:09:28]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Nicolas Zea, 2016-11-15 01:23:25]

The CQ bit was checked by zea@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-15 01:24:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 02:07:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 02:07:33]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Nicolas Zea, 2016-11-15 02:14:03]

The CQ bit was checked by zea@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-15 02:15:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 02:15:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 02:15:08]

Dry run: CLs for remote refs other than refs/pending/heads/master must contain
NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them

[Nicolas Zea, 2016-12-03 00:01:52]

Patchset #3 (id:40001) has been deleted

[Nicolas Zea, 2016-12-03 00:03:05]

Description was changed from

==========
[Sync] Introduce SyncedSessionWindow type.

Because we now need to maintain state outside of the normal SessionWindow
struct, this patch introduces a SyncedSessionWindow type. It wraps a
normal SessionWindow, while allowing tab sync to track additional window
information.

As part of this patch, I've also cleaned up the unused variation ids and
migrated TabLink to use unique ptr. Moving forward, nothing sync specific
should need to be in SessionWindow. We'll probably need to add a wrapper
for SessionTab in the future as well.

The patch itself does not have any behavioral impact, but paves the way for
consuming sync window type information.

BUG=639009
==========

to

==========
[Sync] Introduce SyncedSessionWindow type.

Because we now need to maintain state outside of the normal SessionWindow
struct, this patch introduces a SyncedSessionWindow type. It wraps a
normal SessionWindow, while allowing tab sync to track additional window
information.

As part of this patch, I've also cleaned up the unused variation ids.
Moving forward, nothing sync specific should need to be in
SessionWindow. We'll probably need to add a wrapper
for SessionTab in the future as well.

The patch itself does not have any behavioral impact, but paves the way for
consuming sync window type information.

BUG=639009
==========

[Nicolas Zea, 2016-12-03 00:03:10]

The CQ bit was checked by zea@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-03 00:03:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-03 00:24:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-03 00:24:48]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[Nicolas Zea, 2017-02-10 21:46:33]

The CQ bit was checked by zea@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 21:46:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nicolas Zea, 2017-02-10 21:47:47]

Patchset #5 (id:100001) has been deleted

[commit-bot: I haz the power, 2017-02-10 21:49:40]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Nicolas Zea, 2017-02-10 21:50:38]

The CQ bit was checked by zea@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 21:51:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 21:59:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 22:00:00]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[Nicolas Zea, 2017-02-13 22:49:31]

The CQ bit was checked by zea@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 22:50:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 23:02:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-13 23:02:08]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Nicolas Zea, 2017-03-27 22:19:25]

The CQ bit was checked by zea@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 22:20:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 22:30:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 22:30:59]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Nicolas Zea, 2017-03-27 22:59:45]

The CQ bit was checked by zea@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 23:00:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 23:10:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 23:10:15]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Nicolas Zea, 2017-03-27 23:26:39]

The CQ bit was checked by zea@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 23:27:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 23:39:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 23:39:16]

Dry run: Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Nicolas Zea, 2017-03-27 23:47:59]

The CQ bit was checked by zea@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 23:48:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nicolas Zea, 2017-03-28 01:47:17]

zea@chromium.org changed reviewers:
+ pnoland@chromium.org, skym@chromium.org

[Nicolas Zea, 2017-03-28 01:47:19]

+Sky for review, +Patrick FYI

[commit-bot: I haz the power, 2017-03-28 02:03:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 02:03:57]

Dry run: This issue passed the CQ dry run.

[skym, 2017-03-28 04:48:55]

https://codereview.chromium.org/2499023004/diff/200001/chrome/browser/sync/te...
File chrome/browser/sync/test/integration/single_client_sessions_sync_test.cc
(right):

https://codereview.chromium.org/2499023004/diff/200001/chrome/browser/sync/te...
chrome/browser/sync/test/integration/single_client_sessions_sync_test.cc:195:
for (auto it2 = it->second->wrapped_window.tabs.begin();
Such creative iterator names!

https://codereview.chromium.org/2499023004/diff/200001/components/sync/protoc...
File components/sync/protocol/session_specifics.proto (right):

https://codereview.chromium.org/2499023004/diff/200001/components/sync/protoc...
components/sync/protocol/session_specifics.proto:83: repeated uint64
variation_id = 12;
Mark with [deprecated = true] ? (and while you're in here, all the others :) )

https://codereview.chromium.org/2499023004/diff/200001/components/sync_sessio...
File components/sync_sessions/revisit/sessions_page_revisit_observer_unittest.cc
(right):

https://codereview.chromium.org/2499023004/diff/200001/components/sync_sessio...
components/sync_sessions/revisit/sessions_page_revisit_observer_unittest.cc:101:
std::unique_ptr<SyncedSessionWindow> window =
What do you think of using auto here? The right hand side of this assignment has
the type anyways. (This applies to a few below as well)

https://codereview.chromium.org/2499023004/diff/200001/components/sync_sessio...
File components/sync_sessions/synced_session.h (right):

https://codereview.chromium.org/2499023004/diff/200001/components/sync_sessio...
components/sync_sessions/synced_session.h:27: sync_pb::SessionWindow
ToSyncSessionWindowPB() const;
The "PB" looks really ugly to me, I'd prefer something like
ToSyncProtoSessionWindow(), but I'm fine with whatever you think is best.

https://codereview.chromium.org/2499023004/diff/200001/components/sync_sessio...
components/sync_sessions/synced_session.h:33: sessions::SessionWindow
wrapped_window;
Does it really make sense to hang onto a SessionWindow indefinitely? It seems
like there are quite a few fields that we don't care about. workspace, bounds,
show_state, app_name, etc. Especially for foreign sessions, having a
wrapped_window is kind of lie. What do you think of holding onto our members
directly here, and having another ToNativeSessionWindow() accessor that creates
a sessions::SessionWindow on demand?

What if we remove all concepts of "wrapping in SessionsSyncManager and friends
and they simply had its own first class models that held data in the way that
was the most convenient to them. I feel like adding .wrapped_window. is going
the wrong way here.

[skym, 2017-03-28 20:09:54]

Discussed offline that even if we ultimately remove wrapper classes, this is a
necessary intermediate step to keep moving forward. lgtm

[Patrick Noland, 2017-03-28 20:42:01]

lgtm

https://codereview.chromium.org/2499023004/diff/200001/components/ntp_snippet...
File components/ntp_snippets/sessions/foreign_sessions_suggestions_provider.cc
(right):

https://codereview.chromium.org/2499023004/diff/200001/components/ntp_snippet...
components/ntp_snippets/sessions/foreign_sessions_suggestions_provider.cc:369:
for (const std::pair<const SessionID::id_type,
[nit] This would be a little less verbose with auto, which we're already using
in foreign_session_handler.cc

https://codereview.chromium.org/2499023004/diff/200001/components/sync_sessio...
File components/sync_sessions/synced_session.h (right):

https://codereview.chromium.org/2499023004/diff/200001/components/sync_sessio...
components/sync_sessions/synced_session.h:33: sessions::SessionWindow
wrapped_window;
It seems like many accesses of wrapped_window just want the tabs; would it make
sense to add an accessor to insulate these callers from the fact that there's a
wrapped window?

[Nicolas Zea, 2017-03-29 18:56:46]

The CQ bit was checked by zea@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 18:57:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nicolas Zea, 2017-03-29 19:01:32]

zea@chromium.org changed reviewers:
+ bauerb@google.com, skuhne@chromium.org, thestig@chromium.org

[Nicolas Zea, 2017-03-29 19:01:33]

Comments addressed. TBRing owners as this is just changing how sync's
SessionWindows are accessed (trivial callsite change)

https://codereview.chromium.org/2499023004/diff/200001/chrome/browser/sync/te...
File chrome/browser/sync/test/integration/single_client_sessions_sync_test.cc
(right):

https://codereview.chromium.org/2499023004/diff/200001/chrome/browser/sync/te...
chrome/browser/sync/test/integration/single_client_sessions_sync_test.cc:195:
for (auto it2 = it->second->wrapped_window.tabs.begin();
On 2017/03/28 04:48:55, skym wrote:
> Such creative iterator names!

Acknowledged.

https://codereview.chromium.org/2499023004/diff/200001/components/ntp_snippet...
File components/ntp_snippets/sessions/foreign_sessions_suggestions_provider.cc
(right):

https://codereview.chromium.org/2499023004/diff/200001/components/ntp_snippet...
components/ntp_snippets/sessions/foreign_sessions_suggestions_provider.cc:369:
for (const std::pair<const SessionID::id_type,
On 2017/03/28 20:42:00, Patrick Noland wrote:
> [nit] This would be a little less verbose with auto, which we're already using
> in foreign_session_handler.cc

Done.

https://codereview.chromium.org/2499023004/diff/200001/components/sync/protoc...
File components/sync/protocol/session_specifics.proto (right):

https://codereview.chromium.org/2499023004/diff/200001/components/sync/protoc...
components/sync/protocol/session_specifics.proto:83: repeated uint64
variation_id = 12;
On 2017/03/28 04:48:55, skym wrote:
> Mark with [deprecated = true] ? (and while you're in here, all the others :) )

Done.

https://codereview.chromium.org/2499023004/diff/200001/components/sync_sessio...
File components/sync_sessions/revisit/sessions_page_revisit_observer_unittest.cc
(right):

https://codereview.chromium.org/2499023004/diff/200001/components/sync_sessio...
components/sync_sessions/revisit/sessions_page_revisit_observer_unittest.cc:101:
std::unique_ptr<SyncedSessionWindow> window =
On 2017/03/28 04:48:55, skym wrote:
> What do you think of using auto here? The right hand side of this assignment
has
> the type anyways. (This applies to a few below as well)

Done.

https://codereview.chromium.org/2499023004/diff/200001/components/sync_sessio...
File components/sync_sessions/synced_session.h (right):

https://codereview.chromium.org/2499023004/diff/200001/components/sync_sessio...
components/sync_sessions/synced_session.h:27: sync_pb::SessionWindow
ToSyncSessionWindowPB() const;
On 2017/03/28 04:48:55, skym wrote:
> The "PB" looks really ugly to me, I'd prefer something like
> ToSyncProtoSessionWindow(), but I'm fine with whatever you think is best.

Switched to ToSessionWindowProto

https://codereview.chromium.org/2499023004/diff/200001/components/sync_sessio...
components/sync_sessions/synced_session.h:33: sessions::SessionWindow
wrapped_window;
On 2017/03/28 20:42:00, Patrick Noland wrote:
> It seems like many accesses of wrapped_window just want the tabs; would it
make
> sense to add an accessor to insulate these callers from the fact that there's
a
> wrapped window? 

I do think it probably makes sense to move away from sessions::SessionWindow
entirely at some point, but I think that's outside of the scope of this patch
(as discussed offline). I think that will eventually also address Patrick's
concern about callers not caring about whether the window is wrapped or not.

[Nicolas Zea, 2017-03-29 19:01:52]

Description was changed from

==========
[Sync] Introduce SyncedSessionWindow type.

Because we now need to maintain state outside of the normal SessionWindow
struct, this patch introduces a SyncedSessionWindow type. It wraps a
normal SessionWindow, while allowing tab sync to track additional window
information.

As part of this patch, I've also cleaned up the unused variation ids.
Moving forward, nothing sync specific should need to be in
SessionWindow. We'll probably need to add a wrapper
for SessionTab in the future as well.

The patch itself does not have any behavioral impact, but paves the way for
consuming sync window type information.

BUG=639009
==========

to

==========
[Sync] Introduce SyncedSessionWindow type.

Because we now need to maintain state outside of the normal SessionWindow
struct, this patch introduces a SyncedSessionWindow type. It wraps a
normal SessionWindow, while allowing tab sync to track additional window
information.

As part of this patch, I've also cleaned up the unused variation ids.
Moving forward, nothing sync specific should need to be in
SessionWindow. We'll probably need to add a wrapper
for SessionTab in the future as well.

The patch itself does not have any behavioral impact, but paves the way for
consuming sync window type information.

BUG=639009
TBR=bauerb, skuhne, thestig
==========

[Lei Zhang, 2017-03-29 19:17:50]

chrome/ lgtm

[commit-bot: I haz the power, 2017-03-29 19:57:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 19:57:02]

Dry run: This issue passed the CQ dry run.

[Nicolas Zea, 2017-03-29 19:58:21]

The CQ bit was checked by zea@chromium.org

[Nicolas Zea, 2017-03-29 19:58:21]

The patchset sent to the CQ was uploaded after l-g-t-m from skym@chromium.org,
pnoland@chromium.org
Link to the patchset: https://codereview.chromium.org/2499023004/#ps220001
(title: "Address comments")

[commit-bot: I haz the power, 2017-03-29 19:58:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 20:11:32]

CQ is committing da patch.

Bot data: {"patchset_id": 220001, "attempt_start_ts": 1490817501344600,
"parent_rev": "61687ec5b7b5dce1c9c86ae46f552c0c34473555", "commit_rev":
"325508e90dc01afb4d6332510fc83d39c74c96f0"}

[commit-bot: I haz the power, 2017-03-29 20:12:17]

Description was changed from

==========
[Sync] Introduce SyncedSessionWindow type.

Because we now need to maintain state outside of the normal SessionWindow
struct, this patch introduces a SyncedSessionWindow type. It wraps a
normal SessionWindow, while allowing tab sync to track additional window
information.

As part of this patch, I've also cleaned up the unused variation ids.
Moving forward, nothing sync specific should need to be in
SessionWindow. We'll probably need to add a wrapper
for SessionTab in the future as well.

The patch itself does not have any behavioral impact, but paves the way for
consuming sync window type information.

BUG=639009
TBR=bauerb, skuhne, thestig
==========

to

==========
[Sync] Introduce SyncedSessionWindow type.

Because we now need to maintain state outside of the normal SessionWindow
struct, this patch introduces a SyncedSessionWindow type. It wraps a
normal SessionWindow, while allowing tab sync to track additional window
information.

As part of this patch, I've also cleaned up the unused variation ids.
Moving forward, nothing sync specific should need to be in
SessionWindow. We'll probably need to add a wrapper
for SessionTab in the future as well.

The patch itself does not have any behavioral impact, but paves the way for
consuming sync window type information.

BUG=639009
TBR=bauerb, skuhne, thestig

Review-Url: https://codereview.chromium.org/2499023004
Cr-Commit-Position: refs/heads/master@{#460510}
Committed:
https://chromium.googlesource.com/chromium/src/+/325508e90dc01afb4d6332510fc8...
==========

[commit-bot: I haz the power, 2017-03-29 20:12:19]

Committed patchset #10 (id:220001) as
https://chromium.googlesource.com/chromium/src/+/325508e90dc01afb4d6332510fc8...