[Sync] Introduce SyncedSessionWindow type.

components/ntp_snippets/sessions/foreign_sessions_suggestions_provider.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/ntp_snippets/sessions/foreign_sessions_suggestions_provider.h"
 
 #include <algorithm>
 #include <map>
 #include <tuple>
 #include <utility>
@@ skipping 16 matching lines @@
 #include "components/variations/variations_associated_data.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/gfx/image/image.h"
 #include "url/gurl.h"
 
 using base::Time;
 using base::TimeDelta;
 using sessions::SerializedNavigationEntry;
 using sessions::SessionTab;
 using sessions::SessionWindow;
+using sync_sessions::SyncedSessionWindow;
 using sync_sessions::SyncedSession;
 
 using DismissedFilter = base::Callback<bool(const std::string& id)>;
 
 namespace ntp_snippets {
 namespace {
 
 const int kMaxForeignTabsTotal = 10;
 const int kMaxForeignTabsPerDevice = 3;
 const int kMaxForeignTabAgeInMinutes = 180;
@@ skipping 311 matching lines @@
 }
 
 std::vector<ForeignSessionsSuggestionsProvider::SessionData>
 ForeignSessionsSuggestionsProvider::GetSuggestionCandidates(
     const DismissedFilter& suggestions_filter) {
   const std::vector<const SyncedSession*>& foreign_sessions =
       foreign_sessions_provider_->GetAllForeignSessions();
   const TimeDelta max_foreign_tab_age = GetMaxForeignTabAge();
   std::vector<SessionData> suggestion_candidates;
   for (const SyncedSession* session : foreign_sessions) {
     for (const std::pair<const SessionID::id_type,

[Patrick Noland, 2017/03/28 20:42:00]

[nit] This would be a little less verbose with auto, which we're already using
in foreign_session_handler.cc

[Nicolas Zea, 2017/03/29 19:01:33]

Done.

-                         std::unique_ptr<sessions::SessionWindow>>& key_value :
+                         std::unique_ptr<SyncedSessionWindow>>& key_value :
          session->windows) {
-      for (const std::unique_ptr<SessionTab>& tab : key_value.second->tabs) {
+      for (const std::unique_ptr<SessionTab>& tab :
+           key_value.second->wrapped_window.tabs) {
         if (tab->navigations.empty()) {
           continue;
         }
 
         const SerializedNavigationEntry& navigation = tab->navigations.back();
         const std::string id = navigation.virtual_url().spec();
         // TODO(skym): Filter out internal pages. Tabs that contain only
         // non-syncable content should never reach the local client. However,
         // sync will let tabs through whose current navigation entry is
         // internal, as long as a back or forward navigation entry is valid. We
@@ skipping 16 matching lines @@
                                data.navigation->virtual_url().spec(),
                                data.navigation->virtual_url());
   suggestion.set_title(data.navigation->title());
   suggestion.set_publish_date(data.tab->timestamp);
   suggestion.set_publisher_name(
       base::UTF8ToUTF16(data.navigation->virtual_url().host()));
   return suggestion;
 }
 
 }  // namespace ntp_snippets