Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 2498873003: Refactor how the updater state data is serialized in update checks. (Closed)

Created:
4 years, 1 month ago by Sorin Jianu
Modified:
4 years, 1 month ago
Reviewers:
waffles
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor how the updater state data is serialized in update checks. This is mostly a mechanical change that affects how the updater state is serialized in the component updater update checks. The outcome of this change is that the "domainjoined" attribute is serialized as an XML attribute of the request element. The other attributes of the updater state are serialized as an XML <updater> element. This change tears down the previous implementation of passing the updater state thorough the recovery component. There is a change in behavior: the updater state is serialized only for Google Chrome builds. The "domainjoined" attribute is an exception and it is being serialized for all Chromium builds. Last, the updater state is read on a blocking pool task runner, and therefore, it can be implemented for macOS builds too. BUG=615187 Committed: https://crrev.com/97bd029159326fcd0792045a451b99cf9b20c913 Cr-Commit-Position: refs/heads/master@{#431907}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+439 lines, -532 lines) Patch
M chrome/browser/component_updater/recovery_component_installer.cc View 3 chunks +0 lines, -13 lines 0 comments Download
M components/component_updater/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M components/component_updater/component_updater_service.cc View 4 chunks +1 line, -34 lines 0 comments Download
M components/component_updater/component_updater_service_internal.h View 1 chunk +0 lines, -6 lines 0 comments Download
D components/component_updater/updater_state_unittest_win.cc View 1 chunk +0 lines, -103 lines 0 comments Download
D components/component_updater/updater_state_win.h View 1 chunk +0 lines, -57 lines 0 comments Download
D components/component_updater/updater_state_win.cc View 1 chunk +0 lines, -195 lines 0 comments Download
M components/update_client/BUILD.gn View 2 chunks +4 lines, -0 lines 0 comments Download
M components/update_client/configurator.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/update_client/ping_manager.cc View 2 chunks +3 lines, -1 line 0 comments Download
M components/update_client/update_checker.cc View 7 chunks +39 lines, -13 lines 0 comments Download
M components/update_client/update_checker_unittest.cc View 1 chunk +17 lines, -10 lines 0 comments Download
A components/update_client/updater_state.h View 1 chunk +68 lines, -0 lines 0 comments Download
A components/update_client/updater_state.cc View 1 chunk +92 lines, -0 lines 0 comments Download
A components/update_client/updater_state_unittest.cc View 1 chunk +108 lines, -0 lines 0 comments Download
A + components/update_client/updater_state_win.cc View 6 chunks +18 lines, -73 lines 0 comments Download
M components/update_client/utils.h View 2 chunks +14 lines, -9 lines 0 comments Download
M components/update_client/utils.cc View 7 chunks +34 lines, -10 lines 0 comments Download
M components/update_client/utils_unittest.cc View 3 chunks +39 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Sorin Jianu
PTAL
4 years, 1 month ago (2016-11-14 16:52:56 UTC) #3
waffles
lgtm
4 years, 1 month ago (2016-11-14 17:10:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2498873003/1
4 years, 1 month ago (2016-11-14 19:31:12 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-14 19:47:23 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-14 20:10:18 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/97bd029159326fcd0792045a451b99cf9b20c913
Cr-Commit-Position: refs/heads/master@{#431907}

Powered by Google App Engine
This is Rietveld 408576698