Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(703)

Unified Diff: components/update_client/utils.h

Issue 2498873003: Refactor how the updater state data is serialized in update checks. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/update_client/updater_state_win.cc ('k') | components/update_client/utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/update_client/utils.h
diff --git a/components/update_client/utils.h b/components/update_client/utils.h
index 9f761c42040a9adf2436753a2aa07634c6b36f5b..f82fb929a2d7434ddc5c588351e45941ba4114e7 100644
--- a/components/update_client/utils.h
+++ b/components/update_client/utils.h
@@ -12,6 +12,7 @@
#include "base/callback_forward.h"
#include "components/update_client/update_client.h"
+#include "components/update_client/updater_state.h"
class GURL;
@@ -58,15 +59,19 @@ using InstallerAttribute = std::pair<std::string, std::string>;
// affects the list of download URLs returned in the update response.
// If specified, |additional_attributes| are appended as attributes of the
// request element. The additional attributes have to be well-formed for
-// insertion in the request element.
-std::string BuildProtocolRequest(const std::string& prod_id,
- const std::string& browser_version,
- const std::string& channel,
- const std::string& lang,
- const std::string& os_long_name,
- const std::string& download_preference,
- const std::string& request_body,
- const std::string& additional_attributes);
+// insertion in the request element. |updater_state_attributes| is an optional
+// parameter specifying that an <updater> element is serialized as part of
+// the request.
+std::string BuildProtocolRequest(
+ const std::string& prod_id,
+ const std::string& browser_version,
+ const std::string& channel,
+ const std::string& lang,
+ const std::string& os_long_name,
+ const std::string& download_preference,
+ const std::string& request_body,
+ const std::string& additional_attributes,
+ const std::unique_ptr<UpdaterState::Attributes>& updater_state_attributes);
// Sends a protocol request to the the service endpoint specified by |url|.
// The body of the request is provided by |protocol_request| and it is
« no previous file with comments | « components/update_client/updater_state_win.cc ('k') | components/update_client/utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698