components/update_client/configurator.h - Issue 2498873003: Refactor how the updater state data is serialized in update checks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/update_client/configurator.h

Issue 2498873003: Refactor how the updater state data is serialized in update checks. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/update_client/configurator.h

diff --git a/components/update_client/configurator.h b/components/update_client/configurator.h

index 384b23de6bf95187d809052e7088c43bae299ed3..c0217108ee60c8d75af6c6702afd428853bb7cd7 100644

--- a/components/update_client/configurator.h

+++ b/components/update_client/configurator.h

@@ -132,7 +132,8 @@ class Configurator : public base::RefCountedThreadSafe<Configurator> {

virtual PrefService* GetPrefService() const = 0;

// Returns true if the Chrome is installed for the current user only, or false

- // if Chrome is installed for all users on the machine.

+ // if Chrome is installed for all users on the machine. This function must be

+ // called only from a blocking pool thread, as it may access the file system.

virtual bool IsPerUserInstall() const = 0;

protected:

« no previous file with comments | « components/update_client/BUILD.gn ('k') | components/update_client/ping_manager.cc » ('j') | no next file with comments »