Add ARC++ kiosk menu items and ability to start kiosk session.

Add ARC++ kiosk menu items and ability to start kiosk session.

BUG=634497
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/008f8d022c3819474eb845a7099452f8f220cebf
Cr-Commit-Position: refs/heads/master@{#432892}

[Sergey Poromov, 2016-11-11 16:42:52]

Description was changed from

==========
Add ARC++ kiosk menu items and ability to start kiosk session.

BUG=634497
==========

to

==========
Add ARC++ kiosk menu items and ability to start kiosk session.

BUG=634497
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Sergey Poromov, 2016-11-11 18:36:47]

poromov@chromium.org changed reviewers:
+ achuith@chromium.org, bartfab@chromium.org, hidehiko@chromium.org,
lhchavez@chromium.org, nkostylev@chromium.org, peletskyi@chromium.org

[peletskyi, 2016-11-12 16:52:17]

https://codereview.chromium.org/2498613003/diff/1/chrome/browser/app_mode/app...
File chrome/browser/app_mode/app_mode_utils.cc (right):

https://codereview.chromium.org/2498613003/diff/1/chrome/browser/app_mode/app...
chrome/browser/app_mode/app_mode_utils.cc:58: base::CommandLine* command_line =
base::CommandLine::ForCurrentProcess();
Can you try here to check what type of user is logged in?

https://codereview.chromium.org/2498613003/diff/1/chrome/browser/chromeos/arc...
File chrome/browser/chromeos/arc/arc_auth_service.cc (right):

https://codereview.chromium.org/2498613003/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/arc_auth_service.cc:438:
mojom::ChromeAccountType::ROBOT_ACCOUNT, true);
ArcAuthServiceBrowsertest must be fixed as well.

[Luis Héctor Chávez, 2016-11-12 18:03:08]

https://codereview.chromium.org/2498613003/diff/1/chrome/browser/app_mode/app...
File chrome/browser/app_mode/app_mode_utils.cc (right):

https://codereview.chromium.org/2498613003/diff/1/chrome/browser/app_mode/app...
chrome/browser/app_mode/app_mode_utils.cc:48: IsRunningInForcedAppMode();
Do you also want this to include IsRunningInAndroidAppMode?

https://codereview.chromium.org/2498613003/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/existing_user_controller.cc (right):

https://codereview.chromium.org/2498613003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/existing_user_controller.cc:239: user->GetType()
== user_manager::USER_TYPE_ARC_KIOSK_APP)
nit: you cannot elide braces if the condition spans more than one line.

https://codereview.chromium.org/2498613003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/existing_user_controller.cc:911:
login_performer_.reset(nullptr);
nit: this is unnecessary. The call to reset() in the next line takes care of
destroying whatever |login_performer_| currently has.

https://codereview.chromium.org/2498613003/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/session/user_session_manager.cc (right):

https://codereview.chromium.org/2498613003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/session/user_session_manager.cc:1334:
chrome::IsRunningInAndroidAppMode()) {
nit: put the Forced and Android app mode checks together.

https://codereview.chromium.org/2498613003/diff/1/chrome/browser/ui/webui/chr...
File chrome/browser/ui/webui/chromeos/login/kiosk_app_menu_handler.cc (right):

https://codereview.chromium.org/2498613003/diff/1/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/login/kiosk_app_menu_handler.cc:133:
std::unique_ptr<base::DictionaryValue> app_info(new base::DictionaryValue);
Try to avoid parenthesesless constructors:
https://sites.google.com/a/chromium.org/dev/developers/coding-style/cpp-dos-a...

https://codereview.chromium.org/2498613003/diff/1/chrome/common/chrome_switch...
File chrome/common/chrome_switches.cc (right):

https://codereview.chromium.org/2498613003/diff/1/chrome/common/chrome_switch...
chrome/common/chrome_switches.cc:535: const char kForceAndroidAppMode[]         
 = "android-force-app-mode";
Also make this alphabetical and document this flag by itself.

Also, wouldn't this be "force-android-app-mode"?

https://codereview.chromium.org/2498613003/diff/1/chrome/common/chrome_switch...
File chrome/common/chrome_switches.h (right):

https://codereview.chromium.org/2498613003/diff/1/chrome/common/chrome_switch...
chrome/common/chrome_switches.h:164: extern const char kForceAndroidAppMode[];
L31 says "// All switches in alphabetical order"

[hidehiko, 2016-11-14 05:29:24]

https://codereview.chromium.org/2498613003/diff/1/chrome/browser/app_mode/app...
File chrome/browser/app_mode/app_mode_utils.cc (right):

https://codereview.chromium.org/2498613003/diff/1/chrome/browser/app_mode/app...
chrome/browser/app_mode/app_mode_utils.cc:57: bool IsRunningInAndroidAppMode() {
Considering the name consistency, IsRunningInForcedAndroidAppMode()?

https://codereview.chromium.org/2498613003/diff/1/chrome/browser/app_mode/app...
chrome/browser/app_mode/app_mode_utils.cc:59: return
command_line->HasSwitch(switches::kForceAndroidAppMode);
"command_line->HasSwitch(switches::kAppId)" is in the IsRunningInForcedAppMode.
Interested in to check it here, too?

https://codereview.chromium.org/2498613003/diff/1/chrome/browser/chromeos/arc...
File chrome/browser/chromeos/arc/arc_auth_service.cc (right):

https://codereview.chromium.org/2498613003/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/arc_auth_service.cc:438:
mojom::ChromeAccountType::ROBOT_ACCOUNT, true);
policy_util::IsAccountManaged(profile_) looks better than hardcoded value?

https://codereview.chromium.org/2498613003/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/arc_auth_service.cc:476: if
(!IsOptInVerificationDisabled() && !IsArcKioskMode()) {
Any comments?

https://codereview.chromium.org/2498613003/diff/1/chromeos/login/auth/cryptoh...
File chromeos/login/auth/cryptohome_authenticator.h (right):

https://codereview.chromium.org/2498613003/diff/1/chromeos/login/auth/cryptoh...
chromeos/login/auth/cryptohome_authenticator.h:139: // Initiates login into the
ARC kiosk mode account identified by
nit: insert an empty line for consistency?

[Sergey Poromov, 2016-11-14 17:23:21]

poromov@chromium.org changed reviewers:
+ xiyuan@chromium.org

[Sergey Poromov, 2016-11-14 17:23:23]

https://codereview.chromium.org/2498613003/diff/1/chrome/browser/app_mode/app...
File chrome/browser/app_mode/app_mode_utils.cc (right):

https://codereview.chromium.org/2498613003/diff/1/chrome/browser/app_mode/app...
chrome/browser/app_mode/app_mode_utils.cc:48: IsRunningInForcedAppMode();
On 2016/11/12 18:03:08, Luis Héctor Chávez wrote:
> Do you also want this to include IsRunningInAndroidAppMode?

Done. But I'll wait for xiyuan@ review to tell whether I'm doing the right thing
here.

https://codereview.chromium.org/2498613003/diff/1/chrome/browser/app_mode/app...
chrome/browser/app_mode/app_mode_utils.cc:57: bool IsRunningInAndroidAppMode() {
On 2016/11/14 05:29:24, hidehiko wrote:
> Considering the name consistency, IsRunningInForcedAndroidAppMode()?

Done.

https://codereview.chromium.org/2498613003/diff/1/chrome/browser/app_mode/app...
chrome/browser/app_mode/app_mode_utils.cc:59: return
command_line->HasSwitch(switches::kForceAndroidAppMode);
On 2016/11/14 05:29:24, hidehiko wrote:
> "command_line->HasSwitch(switches::kAppId)" is in the
IsRunningInForcedAppMode.
> Interested in to check it here, too?

For android app we don't put the switch.

https://codereview.chromium.org/2498613003/diff/1/chrome/browser/chromeos/arc...
File chrome/browser/chromeos/arc/arc_auth_service.cc (right):

https://codereview.chromium.org/2498613003/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/arc_auth_service.cc:438:
mojom::ChromeAccountType::ROBOT_ACCOUNT, true);
On 2016/11/14 05:29:24, hidehiko wrote:
> policy_util::IsAccountManaged(profile_) looks better than hardcoded value?

Done.

https://codereview.chromium.org/2498613003/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/arc_auth_service.cc:476: if
(!IsOptInVerificationDisabled() && !IsArcKioskMode()) {
On 2016/11/14 05:29:24, hidehiko wrote:
> Any comments?

Done.

https://codereview.chromium.org/2498613003/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/existing_user_controller.cc (right):

https://codereview.chromium.org/2498613003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/existing_user_controller.cc:239: user->GetType()
== user_manager::USER_TYPE_ARC_KIOSK_APP)
On 2016/11/12 18:03:08, Luis Héctor Chávez wrote:
> nit: you cannot elide braces if the condition spans more than one line.

Done.

https://codereview.chromium.org/2498613003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/existing_user_controller.cc:911:
login_performer_.reset(nullptr);
On 2016/11/12 18:03:08, Luis Héctor Chávez wrote:
> nit: this is unnecessary. The call to reset() in the next line takes care of
> destroying whatever |login_performer_| currently has.

It's destroying after creating a new ChromeLoginPerformer(this). Looks like
there is nothing suspicious in the constructors/destructors, but I wrote it here
the same way as everywhere in this class for consistency.

https://codereview.chromium.org/2498613003/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/session/user_session_manager.cc (right):

https://codereview.chromium.org/2498613003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/session/user_session_manager.cc:1334:
chrome::IsRunningInAndroidAppMode()) {
On 2016/11/12 18:03:08, Luis Héctor Chávez wrote:
> nit: put the Forced and Android app mode checks together.

Done.

https://codereview.chromium.org/2498613003/diff/1/chrome/browser/ui/webui/chr...
File chrome/browser/ui/webui/chromeos/login/kiosk_app_menu_handler.cc (right):

https://codereview.chromium.org/2498613003/diff/1/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/login/kiosk_app_menu_handler.cc:133:
std::unique_ptr<base::DictionaryValue> app_info(new base::DictionaryValue);
On 2016/11/12 18:03:08, Luis Héctor Chávez wrote:
> Try to avoid parenthesesless constructors:
>
https://sites.google.com/a/chromium.org/dev/developers/coding-style/cpp-dos-a...

Done.

https://codereview.chromium.org/2498613003/diff/1/chrome/common/chrome_switch...
File chrome/common/chrome_switches.cc (right):

https://codereview.chromium.org/2498613003/diff/1/chrome/common/chrome_switch...
chrome/common/chrome_switches.cc:535: const char kForceAndroidAppMode[]         
 = "android-force-app-mode";
On 2016/11/12 18:03:08, Luis Héctor Chávez wrote:
> Also make this alphabetical and document this flag by itself.
> 
> Also, wouldn't this be "force-android-app-mode"?

Done.

https://codereview.chromium.org/2498613003/diff/1/chrome/common/chrome_switch...
File chrome/common/chrome_switches.h (right):

https://codereview.chromium.org/2498613003/diff/1/chrome/common/chrome_switch...
chrome/common/chrome_switches.h:164: extern const char kForceAndroidAppMode[];
On 2016/11/12 18:03:08, Luis Héctor Chávez wrote:
> L31 says "// All switches in alphabetical order"

Done.

https://codereview.chromium.org/2498613003/diff/1/chromeos/login/auth/cryptoh...
File chromeos/login/auth/cryptohome_authenticator.h (right):

https://codereview.chromium.org/2498613003/diff/1/chromeos/login/auth/cryptoh...
chromeos/login/auth/cryptohome_authenticator.h:139: // Initiates login into the
ARC kiosk mode account identified by
On 2016/11/14 05:29:24, hidehiko wrote:
> nit: insert an empty line for consistency?

Done.

[xiyuan, 2016-11-15 16:56:25]

Mostly good.

https://codereview.chromium.org/2498613003/diff/1/chrome/browser/app_mode/app...
File chrome/browser/app_mode/app_mode_utils.cc (right):

https://codereview.chromium.org/2498613003/diff/1/chrome/browser/app_mode/app...
chrome/browser/app_mode/app_mode_utils.cc:48: IsRunningInForcedAppMode();
On 2016/11/14 17:23:22, Sergey Poromov wrote:
> On 2016/11/12 18:03:08, Luis Héctor Chávez wrote:
> > Do you also want this to include IsRunningInAndroidAppMode?
> 
> Done. But I'll wait for xiyuan@ review to tell whether I'm doing the right
thing
> here.

Yep, think we should include arc app. We should try to combine those mode test
function as much as we can.

https://codereview.chromium.org/2498613003/diff/20001/chrome/browser/app_mode...
File chrome/browser/app_mode/app_mode_utils.cc (right):

https://codereview.chromium.org/2498613003/diff/20001/chrome/browser/app_mode...
chrome/browser/app_mode/app_mode_utils.cc:57: bool
IsRunningInForcedAndroidAppMode() {
Do we need to differentiate this from IsRunningInForcedAppMode above?

[Sergey Poromov, 2016-11-15 18:24:04]

poromov@chromium.org changed reviewers:
+ oshima@chromium.org
- achuith@chromium.org

[Sergey Poromov, 2016-11-15 18:24:04]

Hi all,

please review changes in the following files:

Nikita:
chrome/browser/chromeos/*

Xiyuan:
chrome/browser/app_mode/*
chrome/browser/resources/*
chrome/browser/ui/*
chromeos/login/auth/*
components/user_manager/*

Mitsuru:
ash/common/*

[Nikita (slow), 2016-11-16 14:37:13]

On 2016/11/15 18:24:04, Sergey Poromov wrote:
> Nikita:
> chrome/browser/chromeos/*

lgtm

[Nikita (slow), 2016-11-16 14:37:22]

https://codereview.chromium.org/2498613003/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/arc_auth_service.cc (right):

https://codereview.chromium.org/2498613003/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/arc_auth_service.cc:477: // Don't show Play Store
app for ARC Kiosk because the only one UI in kiosk
What would be the way to debug Play Store then?

Imagine we have ARC++ kiosk session running and kiosk app is not delivered.

How about having a certain cmd line parameter?

https://codereview.chromium.org/2498613003/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc (right):

https://codereview.chromium.org/2498613003/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc:701: return;
nit: {}

[Sergey Poromov, 2016-11-16 15:06:21]

https://codereview.chromium.org/2498613003/diff/20001/chrome/browser/app_mode...
File chrome/browser/app_mode/app_mode_utils.cc (right):

https://codereview.chromium.org/2498613003/diff/20001/chrome/browser/app_mode...
chrome/browser/app_mode/app_mode_utils.cc:57: bool
IsRunningInForcedAndroidAppMode() {
On 2016/11/15 16:56:25, xiyuan wrote:
> Do we need to differentiate this from IsRunningInForcedAppMode above?

Looks like there is no difference right now. If you are OK with merging these
methods - I did it.

https://codereview.chromium.org/2498613003/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/arc_auth_service.cc (right):

https://codereview.chromium.org/2498613003/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/arc_auth_service.cc:477: // Don't show Play Store
app for ARC Kiosk because the only one UI in kiosk
On 2016/11/16 14:37:21, Nikita (slow) wrote:
> What would be the way to debug Play Store then?
> 
> Imagine we have ARC++ kiosk session running and kiosk app is not delivered.
> 
> How about having a certain cmd line parameter?

This code auto-starts Play Store app on first sign in into ARC++ session for
opt-in UI. This workflow is not needed for ARC Kiosk, but it doesn't prevent
from starting Play Store app to install the app if needed.

https://codereview.chromium.org/2498613003/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc (right):

https://codereview.chromium.org/2498613003/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc:701: return;
On 2016/11/16 14:37:21, Nikita (slow) wrote:
> nit: {}

Done.

[xiyuan, 2016-11-16 17:28:55]

lgtm

https://codereview.chromium.org/2498613003/diff/20001/chrome/browser/app_mode...
File chrome/browser/app_mode/app_mode_utils.cc (right):

https://codereview.chromium.org/2498613003/diff/20001/chrome/browser/app_mode...
chrome/browser/app_mode/app_mode_utils.cc:57: bool
IsRunningInForcedAndroidAppMode() {
On 2016/11/16 15:06:21, Sergey Poromov wrote:
> On 2016/11/15 16:56:25, xiyuan wrote:
> > Do we need to differentiate this from IsRunningInForcedAppMode above?
> 
> Looks like there is no difference right now. If you are OK with merging these
> methods - I did it.

Thanks.

[Sergey Poromov, 2016-11-16 18:04:29]

The CQ bit was checked by poromov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 18:05:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hidehiko, 2016-11-16 18:57:07]

https://codereview.chromium.org/2498613003/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc (right):

https://codereview.chromium.org/2498613003/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc:881:
command_line->AppendSwitch(chromeos::switches::kEnableArc);
Could you set arc.enabled and arc.terms.accepted preference, too?

[xiyuan, 2016-11-16 19:00:17]

https://codereview.chromium.org/2498613003/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc (right):

https://codereview.chromium.org/2498613003/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc:881:
command_line->AppendSwitch(chromeos::switches::kEnableArc);
On 2016/11/16 18:57:07, hidehiko wrote:
> Could you set arc.enabled and arc.terms.accepted preference, too?

If we need to do this, we need to do it somewhere else, probably in
UserSessionManager::FinalizePrepareProfile. This is because the
ArcKioskAppLoggedIn and friends are called after cryptohome auth but before user
profile is finished loading. Thus PrefService is not available here.

[commit-bot: I haz the power, 2016-11-16 19:19:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 19:19:19]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[oshima, 2016-11-16 19:52:36]

lgtm with nits

https://codereview.chromium.org/2498613003/diff/40001/ash/common/system/tray/...
File ash/common/system/tray/system_tray.cc (right):

https://codereview.chromium.org/2498613003/diff/40001/ash/common/system/tray/...
ash/common/system/tray/system_tray.cc:569: if
(WmShell::Get()->system_tray_delegate()->GetUserLoginStatus() ==
nit: please get the pointer to system tray delegate and use it in if.

https://codereview.chromium.org/2498613003/diff/40001/ash/common/wm/overview/...
File ash/common/wm/overview/window_selector_controller.cc (right):

https://codereview.chromium.org/2498613003/diff/40001/ash/common/wm/overview/...
ash/common/wm/overview/window_selector_controller.cc:36:
WmShell::Get()->GetSessionStateDelegate();
nit: would you mind to get the pointer to WmShell then use it unstead of getting
every time?

[Sergey Poromov, 2016-11-17 12:33:13]

https://codereview.chromium.org/2498613003/diff/40001/ash/common/system/tray/...
File ash/common/system/tray/system_tray.cc (right):

https://codereview.chromium.org/2498613003/diff/40001/ash/common/system/tray/...
ash/common/system/tray/system_tray.cc:569: if
(WmShell::Get()->system_tray_delegate()->GetUserLoginStatus() ==
On 2016/11/16 19:52:35, oshima wrote:
> nit: please get the pointer to system tray delegate and use it in if. 

Done.

https://codereview.chromium.org/2498613003/diff/40001/ash/common/wm/overview/...
File ash/common/wm/overview/window_selector_controller.cc (right):

https://codereview.chromium.org/2498613003/diff/40001/ash/common/wm/overview/...
ash/common/wm/overview/window_selector_controller.cc:36:
WmShell::Get()->GetSessionStateDelegate();
On 2016/11/16 19:52:35, oshima wrote:
> nit: would you mind to get the pointer to WmShell then use it unstead of
getting
> every time?

Done.

https://codereview.chromium.org/2498613003/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc (right):

https://codereview.chromium.org/2498613003/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc:881:
command_line->AppendSwitch(chromeos::switches::kEnableArc);
On 2016/11/16 19:00:17, xiyuan wrote:
> On 2016/11/16 18:57:07, hidehiko wrote:
> > Could you set arc.enabled and arc.terms.accepted preference, too?
> 
> If we need to do this, we need to do it somewhere else, probably in
> UserSessionManager::FinalizePrepareProfile. This is because the
> ArcKioskAppLoggedIn and friends are called after cryptohome auth but before
user
> profile is finished loading. Thus PrefService is not available here.

Both of these preferences are set fir ARC kiosk in
ArcAuthService::OnOptInPreferenceChanged()

[Sergey Poromov, 2016-11-17 13:38:07]

The CQ bit was checked by poromov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 13:38:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 13:40:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 13:40:48]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Sergey Poromov, 2016-11-17 14:46:21]

The CQ bit was checked by poromov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 14:46:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 14:49:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 14:49:30]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Sergey Poromov, 2016-11-17 14:58:18]

The CQ bit was checked by poromov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 14:58:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 15:55:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 15:55:47]

Dry run: This issue passed the CQ dry run.

[Sergey Poromov, 2016-11-17 16:25:53]

The CQ bit was checked by poromov@chromium.org

[Sergey Poromov, 2016-11-17 16:25:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
nkostylev@chromium.org, xiyuan@chromium.org, oshima@chromium.org
Link to the patchset: https://codereview.chromium.org/2498613003/#ps100001
(title: "rebase")

[commit-bot: I haz the power, 2016-11-17 16:26:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 16:34:49]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-11-17 16:38:02]

Description was changed from

==========
Add ARC++ kiosk menu items and ability to start kiosk session.

BUG=634497
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Add ARC++ kiosk menu items and ability to start kiosk session.

BUG=634497
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/008f8d022c3819474eb845a7099452f8f220cebf
Cr-Commit-Position: refs/heads/master@{#432892}
==========

[commit-bot: I haz the power, 2016-11-17 16:38:04]

Patchset 6 (id:??) landed as
https://crrev.com/008f8d022c3819474eb845a7099452f8f220cebf
Cr-Commit-Position: refs/heads/master@{#432892}