Add ARC++ kiosk menu items and ability to start kiosk session.

chrome/browser/chromeos/login/existing_user_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/existing_user_controller.h"
 
 #include <memory>
 #include <vector>
 
 #include "base/bind.h"
@@ skipping 216 matching lines @@
 void ExistingUserController::UpdateLoginDisplay(
     const user_manager::UserList& users) {
   bool show_users_on_signin;
   user_manager::UserList filtered_users;
 
   cros_settings_->GetBoolean(kAccountsPrefShowUserNamesOnSignIn,
                              &show_users_on_signin);
   for (auto* user : users) {
     // Skip kiosk apps for login screen user list. Kiosk apps as pods (aka new
     // kiosk UI) is currently disabled and it gets the apps directly from
-    // KioskAppManager.
-    if (user->GetType() == user_manager::USER_TYPE_KIOSK_APP)
+    // KioskAppManager and ArcKioskAppManager.
+    if (user->GetType() == user_manager::USER_TYPE_KIOSK_APP ||
+        user->GetType() == user_manager::USER_TYPE_ARC_KIOSK_APP)

[Luis Héctor Chávez, 2016/11/12 18:03:08]

nit: you cannot elide braces if the condition spans more than one line.

[Sergey Poromov, 2016/11/14 17:23:23]

Done.

       continue;
 
     // TODO(xiyuan): Clean user profile whose email is not in whitelist.
     const bool meets_supervised_requirements =
         user->GetType() != user_manager::USER_TYPE_SUPERVISED ||
         user_manager::UserManager::Get()->AreSupervisedUsersAllowed();
     const bool meets_whitelist_requirements =
         CrosSettings::IsWhitelisted(user->GetAccountId().GetUserEmail(),
                                     nullptr) ||
         !user->HasGaiaAccount();
@@ skipping 650 matching lines @@
   // Login can continue immediately.
   LoginAsPublicSessionInternal(new_user_context);
 }
 
 void ExistingUserController::LoginAsKioskApp(const std::string& app_id,
                                              bool diagnostic_mode) {
   const bool auto_start = false;
   host_->StartAppLaunch(app_id, diagnostic_mode, auto_start);
 }
 
+void ExistingUserController::LoginAsArcKioskApp(const AccountId& account_id) {
+  login_performer_.reset(nullptr);

[Luis Héctor Chávez, 2016/11/12 18:03:08]

nit: this is unnecessary. The call to reset() in the next line takes care of
destroying whatever |login_performer_| currently has.

[Sergey Poromov, 2016/11/14 17:23:22]

It's destroying after creating a new ChromeLoginPerformer(this). Looks like
there is nothing suspicious in the constructors/destructors, but I wrote it here
the same way as everywhere in this class for consistency.

+  login_performer_.reset(new ChromeLoginPerformer(this));
+  login_performer_->LoginAsArcKioskAccount(account_id);
+}
+
 void ExistingUserController::ConfigurePublicSessionAutoLogin() {
   std::string auto_login_account_id;
   cros_settings_->GetString(kAccountsPrefDeviceLocalAccountAutoLoginId,
                             &auto_login_account_id);
   const std::vector<policy::DeviceLocalAccount> device_local_accounts =
       policy::GetDeviceLocalAccounts(cros_settings_);
 
   public_session_auto_login_account_id_ = EmptyAccountId();
   for (std::vector<policy::DeviceLocalAccount>::const_iterator
            it = device_local_accounts.begin();
@@ skipping 279 matching lines @@
     LoginAsPublicSession(user_context);
     return;
   }
 
   if (user_context.GetUserType() == user_manager::USER_TYPE_KIOSK_APP) {
     LoginAsKioskApp(user_context.GetAccountId().GetUserEmail(),
                     specifics.kiosk_diagnostic_mode);
     return;
   }
 
+  if (user_context.GetUserType() == user_manager::USER_TYPE_ARC_KIOSK_APP) {
+    LoginAsArcKioskApp(user_context.GetAccountId());
+    return;
+  }
+
   // Regular user or supervised user login.
 
   if (!user_context.HasCredentials()) {
     // If credentials are missing, refuse to log in.
 
     // Reenable clicking on other windows and status area.
     login_display_->SetUIEnabled(true);
     // Restart the auto-login timer.
     StartPublicSessionAutoLoginTimer();
   }
@@ skipping 46 matching lines @@
   }
 
   // Otherwise, show the unrecoverable cryptohome error UI and ask user's
   // permission to collect a feedback.
   RecordPasswordChangeFlow(LOGIN_PASSWORD_CHANGE_FLOW_CRYPTOHOME_FAILURE);
   VLOG(1) << "Show unrecoverable cryptohome error dialog.";
   login_display_->ShowUnrecoverableCrypthomeErrorDialog();
 }
 
 }  // namespace chromeos