Implement auto-login for ARC kiosk.

Implement auto-login for ARC kiosk.

If auto-login AccountId is present in ArcKioskAppManager because of a policy,
ARC kiosk account session starts automatically.

Instead of using Chrome Kiosk app sessions approach, ARC kiosks uses the same way as public sessions as they are configured through the same policies. The only difference is the source of user id and type of the user.

As ARC kiosk user don't have user pods, GaiaScreen could be shown instead of SigninScreen and it should also report to ExistingUserController when it's ready.

BUG=634497
Committed: https://crrev.com/56a933a3e9151523d89a3fca86b5347d52740031
Cr-Commit-Position: refs/heads/master@{#433336}

[Sergey Poromov, 2016-11-17 21:46:44]

poromov@chromium.org changed reviewers:
+ alemate@chromium.org, bartfab@chromium.org, nkostylev@chromium.org,
peletskyi@chromium.org

[Sergey Poromov, 2016-11-17 21:46:45]

nkostylev@chromium.org: Please review changes in 
chrome/browser/chromeos/login/*

alemate@chromium.org: Please review changes in 
chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc

[Sergey Poromov, 2016-11-17 21:47:26]

The CQ bit was checked by poromov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 21:48:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sergey Poromov, 2016-11-17 22:49:24]

The CQ bit was checked by poromov@chromium.org to run a CQ dry run

[Alexander Alekseev, 2016-11-17 22:49:33]

https://codereview.chromium.org/2510203002/diff/1/chrome/browser/ui/webui/chr...
File chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc (right):

https://codereview.chromium.org/2510203002/diff/1/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc:552:
Delegate()->OnSigninScreenReady();
This looks strange. Why do you need this?

[commit-bot: I haz the power, 2016-11-17 22:50:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sergey Poromov, 2016-11-17 22:55:34]

https://codereview.chromium.org/2510203002/diff/1/chrome/browser/ui/webui/chr...
File chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc (right):

https://codereview.chromium.org/2510203002/diff/1/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc:552:
Delegate()->OnSigninScreenReady();
On 2016/11/17 22:49:33, Alexander Alekseev wrote:
> This looks strange. Why do you need this?

This is needed to notify ExistingUserController that signin screen is ready and
it can auto-launch ARC kiosk session.
This is done similar to public session that wait for the same signal, but from
SigninScreenHandler.
The other solution could be to create separate path of notifying
ExistingUserController, but this will produce several intermediate methods.

[Alexander Alekseev, 2016-11-17 23:04:59]

On 2016/11/17 22:55:34, Sergey Poromov wrote:
>
https://codereview.chromium.org/2510203002/diff/1/chrome/browser/ui/webui/chr...
> File chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc (right):
> 
>
https://codereview.chromium.org/2510203002/diff/1/chrome/browser/ui/webui/chr...
> chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc:552:
> Delegate()->OnSigninScreenReady();
> On 2016/11/17 22:49:33, Alexander Alekseev wrote:
> > This looks strange. Why do you need this?
> 
> This is needed to notify ExistingUserController that signin screen is ready
and
> it can auto-launch ARC kiosk session.
> This is done similar to public session that wait for the same signal, but from
> SigninScreenHandler.
> The other solution could be to create separate path of notifying
> ExistingUserController, but this will produce several intermediate methods.

Why is startup flow different for kiosk sessions and for public sessions?

[commit-bot: I haz the power, 2016-11-18 00:55:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 00:55:28]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[Sergey Poromov, 2016-11-18 14:20:27]

The CQ bit was checked by poromov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 14:20:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 14:37:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 14:37:53]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Nikita (slow), 2016-11-18 15:12:59]

https://codereview.chromium.org/2510203002/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/existing_user_controller.cc (right):

https://codereview.chromium.org/2510203002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/existing_user_controller.cc:948:
public_session_auto_login_account_id_ = EmptyAccountId();
nit: {}

https://codereview.chromium.org/2510203002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/existing_user_controller.cc:957:
arc_kiosk_auto_login_account_id_ = EmptyAccountId();
nit: {}

https://codereview.chromium.org/2510203002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/existing_user_controller.cc:964: if
(public_session_auto_login_account_id_.is_valid() ||
nit: {}

https://codereview.chromium.org/2510203002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/existing_user_controller.cc:971: void
ExistingUserController::ResetPublicSessionAutoLoginTimer() {
nit: rename

https://codereview.chromium.org/2510203002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/existing_user_controller.cc:1111: void
ExistingUserController::PerformLoginFinishedActions(
nit: rename method param

https://codereview.chromium.org/2510203002/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/existing_user_controller.h (right):

https://codereview.chromium.org/2510203002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/existing_user_controller.h:235: // cancelled. If
|start_public_session_timer| is true than public session
nit: update comment + rename param

https://codereview.chromium.org/2510203002/diff/1/chrome/browser/ui/webui/chr...
File chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc (right):

https://codereview.chromium.org/2510203002/diff/1/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc:552:
Delegate()->OnSigninScreenReady();
Why this change?

https://codereview.chromium.org/2510203002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/existing_user_controller.cc (right):

https://codereview.chromium.org/2510203002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/existing_user_controller.cc:352:
PerformLoginFinishedActions(true /* start public session timer */);
nit: update comment

https://codereview.chromium.org/2510203002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/existing_user_controller.cc:586:
PerformLoginFinishedActions(false /* don't start public session timer */);
nit: update comment

https://codereview.chromium.org/2510203002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/existing_user_controller.cc:771:
PerformLoginFinishedActions(true /* start public session timer */);
nit: update comment

https://codereview.chromium.org/2510203002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/existing_user_controller.cc:786:
PerformLoginFinishedActions(false /* don't start public session timer */);
nit: update comment

https://codereview.chromium.org/2510203002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/existing_user_controller.cc:830:
PerformLoginFinishedActions(true /* start public session timer */);
nit: update comment

https://codereview.chromium.org/2510203002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/existing_user_controller.cc:852:
PerformLoginFinishedActions(true /* start public session timer */);
nit: update comment

[Sergey Poromov, 2016-11-18 15:47:27]

https://codereview.chromium.org/2510203002/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/existing_user_controller.cc (right):

https://codereview.chromium.org/2510203002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/existing_user_controller.cc:948:
public_session_auto_login_account_id_ = EmptyAccountId();
On 2016/11/18 15:12:58, Nikita (slow) wrote:
> nit: {}

Done.

https://codereview.chromium.org/2510203002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/existing_user_controller.cc:957:
arc_kiosk_auto_login_account_id_ = EmptyAccountId();
On 2016/11/18 15:12:58, Nikita (slow) wrote:
> nit: {}

Done.

https://codereview.chromium.org/2510203002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/existing_user_controller.cc:964: if
(public_session_auto_login_account_id_.is_valid() ||
On 2016/11/18 15:12:58, Nikita (slow) wrote:
> nit: {}

Done.

https://codereview.chromium.org/2510203002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/existing_user_controller.cc:971: void
ExistingUserController::ResetPublicSessionAutoLoginTimer() {
On 2016/11/18 15:12:58, Nikita (slow) wrote:
> nit: rename

Done.

https://codereview.chromium.org/2510203002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/existing_user_controller.cc:1111: void
ExistingUserController::PerformLoginFinishedActions(
On 2016/11/18 15:12:58, Nikita (slow) wrote:
> nit: rename method param

Done.

https://codereview.chromium.org/2510203002/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/existing_user_controller.h (right):

https://codereview.chromium.org/2510203002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/existing_user_controller.h:235: // cancelled. If
|start_public_session_timer| is true than public session
On 2016/11/18 15:12:58, Nikita (slow) wrote:
> nit: update comment + rename param

Done.

https://codereview.chromium.org/2510203002/diff/1/chrome/browser/ui/webui/chr...
File chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc (right):

https://codereview.chromium.org/2510203002/diff/1/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc:552:
Delegate()->OnSigninScreenReady();
On 2016/11/18 15:12:58, Nikita (slow) wrote:
> Why this change?

Changed to OnGaiaScreenReady as for auto login it should be reported that GAIA
UI is loaded.

https://codereview.chromium.org/2510203002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/existing_user_controller.cc (right):

https://codereview.chromium.org/2510203002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/existing_user_controller.cc:352:
PerformLoginFinishedActions(true /* start public session timer */);
On 2016/11/18 15:12:59, Nikita (slow) wrote:
> nit: update comment

Done.

https://codereview.chromium.org/2510203002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/existing_user_controller.cc:586:
PerformLoginFinishedActions(false /* don't start public session timer */);
On 2016/11/18 15:12:59, Nikita (slow) wrote:
> nit: update comment

Done.

https://codereview.chromium.org/2510203002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/existing_user_controller.cc:771:
PerformLoginFinishedActions(true /* start public session timer */);
On 2016/11/18 15:12:59, Nikita (slow) wrote:
> nit: update comment

Done.

https://codereview.chromium.org/2510203002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/existing_user_controller.cc:786:
PerformLoginFinishedActions(false /* don't start public session timer */);
On 2016/11/18 15:12:59, Nikita (slow) wrote:
> nit: update comment

Done.

https://codereview.chromium.org/2510203002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/existing_user_controller.cc:830:
PerformLoginFinishedActions(true /* start public session timer */);
On 2016/11/18 15:12:59, Nikita (slow) wrote:
> nit: update comment

Done.

https://codereview.chromium.org/2510203002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/existing_user_controller.cc:852:
PerformLoginFinishedActions(true /* start public session timer */);
On 2016/11/18 15:12:59, Nikita (slow) wrote:
> nit: update comment

Done.

[Sergey Poromov, 2016-11-18 15:47:29]

The CQ bit was checked by poromov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 15:48:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 16:15:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 16:15:03]

Dry run: This issue passed the CQ dry run.

[Sergey Poromov, 2016-11-18 16:35:24]

Description was changed from

==========
Implement auto-login for ARC kiosk.

If auto-login AccountId is present in ArcKioskAppManager because of a policy,
ARC kiosk account session starts automatically similar to public session.

BUG=634497
==========

to

==========
Implement auto-login for ARC kiosk.

If auto-login AccountId is present in ArcKioskAppManager because of a policy,
ARC kiosk account session starts automatically.

Instead of using Chrome Kiosk app sessions approach, ARC kiosks uses the same
way as public sessions as they are configured through the same policies. The
only difference is the source of user id and type of the user.

As ARC kiosk user don't have user pods, GaiaScreen could be shown instead of
SigninScreen and it should also report to ExistingUserController when it's
ready.

BUG=634497
==========

[Nikita (slow), 2016-11-18 17:05:49]

https://codereview.chromium.org/2510203002/diff/60001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/existing_user_controller.h (right):

https://codereview.chromium.org/2510203002/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/login/existing_user_controller.h:325: bool
signin_screen_ready_ = false;
nit: As discussed rename to auto_launch_ready_ as it is only used for auto
launch timer.

[Nikita (slow), 2016-11-18 17:09:35]

lgtm with this potential issue being resolved

https://codereview.chromium.org/2510203002/diff/80001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/existing_user_controller.cc (right):

https://codereview.chromium.org/2510203002/diff/80001/chrome/browser/chromeos...
chrome/browser/chromeos/login/existing_user_controller.cc:446:
StartAutoLoginTimer();
Both OnGaiaScreenReady and OnSigninScreenReady() may be called.
Please put a guard in place in StartAutoLoginTimer(), smth like

if (auto_login_timer_ && auto_login_timer_->IsRunning())
  StopAutoLoginTimer();

[Sergey Poromov, 2016-11-18 18:56:11]

https://codereview.chromium.org/2510203002/diff/60001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/existing_user_controller.h (right):

https://codereview.chromium.org/2510203002/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/login/existing_user_controller.h:325: bool
signin_screen_ready_ = false;
On 2016/11/18 17:05:49, Nikita (slow) wrote:
> nit: As discussed rename to auto_launch_ready_ as it is only used for auto
> launch timer.

Done.

https://codereview.chromium.org/2510203002/diff/80001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/existing_user_controller.cc (right):

https://codereview.chromium.org/2510203002/diff/80001/chrome/browser/chromeos...
chrome/browser/chromeos/login/existing_user_controller.cc:446:
StartAutoLoginTimer();
On 2016/11/18 17:09:35, Nikita (slow) wrote:
> Both OnGaiaScreenReady and OnSigninScreenReady() may be called.
> Please put a guard in place in StartAutoLoginTimer(), smth like
> 
> if (auto_login_timer_ && auto_login_timer_->IsRunning())
>   StopAutoLoginTimer();

Done.

[Sergey Poromov, 2016-11-18 19:07:39]

The CQ bit was checked by poromov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 19:08:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alexander Alekseev, 2016-11-18 22:50:07]

lgtm

[Sergey Poromov, 2016-11-18 23:28:19]

The CQ bit was unchecked by poromov@chromium.org

[Sergey Poromov, 2016-11-18 23:28:20]

The CQ bit was checked by poromov@chromium.org

[Sergey Poromov, 2016-11-18 23:28:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
nkostylev@chromium.org
Link to the patchset: https://codereview.chromium.org/2510203002/#ps100001
(title: "Stop timer if running in StartAutoLoginTimer()")

[commit-bot: I haz the power, 2016-11-18 23:28:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sergey Poromov, 2016-11-18 23:38:56]

The CQ bit was checked by poromov@chromium.org

[commit-bot: I haz the power, 2016-11-18 23:39:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 23:58:06]

Description was changed from

==========
Implement auto-login for ARC kiosk.

If auto-login AccountId is present in ArcKioskAppManager because of a policy,
ARC kiosk account session starts automatically.

Instead of using Chrome Kiosk app sessions approach, ARC kiosks uses the same
way as public sessions as they are configured through the same policies. The
only difference is the source of user id and type of the user.

As ARC kiosk user don't have user pods, GaiaScreen could be shown instead of
SigninScreen and it should also report to ExistingUserController when it's
ready.

BUG=634497
==========

to

==========
Implement auto-login for ARC kiosk.

If auto-login AccountId is present in ArcKioskAppManager because of a policy,
ARC kiosk account session starts automatically.

Instead of using Chrome Kiosk app sessions approach, ARC kiosks uses the same
way as public sessions as they are configured through the same policies. The
only difference is the source of user id and type of the user.

As ARC kiosk user don't have user pods, GaiaScreen could be shown instead of
SigninScreen and it should also report to ExistingUserController when it's
ready.

BUG=634497
==========

[commit-bot: I haz the power, 2016-11-18 23:58:07]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-11-19 00:05:23]

Description was changed from

==========
Implement auto-login for ARC kiosk.

If auto-login AccountId is present in ArcKioskAppManager because of a policy,
ARC kiosk account session starts automatically.

Instead of using Chrome Kiosk app sessions approach, ARC kiosks uses the same
way as public sessions as they are configured through the same policies. The
only difference is the source of user id and type of the user.

As ARC kiosk user don't have user pods, GaiaScreen could be shown instead of
SigninScreen and it should also report to ExistingUserController when it's
ready.

BUG=634497
==========

to

==========
Implement auto-login for ARC kiosk.

If auto-login AccountId is present in ArcKioskAppManager because of a policy,
ARC kiosk account session starts automatically.

Instead of using Chrome Kiosk app sessions approach, ARC kiosks uses the same
way as public sessions as they are configured through the same policies. The
only difference is the source of user id and type of the user.

As ARC kiosk user don't have user pods, GaiaScreen could be shown instead of
SigninScreen and it should also report to ExistingUserController when it's
ready.

BUG=634497

Committed: https://crrev.com/56a933a3e9151523d89a3fca86b5347d52740031
Cr-Commit-Position: refs/heads/master@{#433336}
==========

[commit-bot: I haz the power, 2016-11-19 00:05:24]

Patchset 6 (id:??) landed as
https://crrev.com/56a933a3e9151523d89a3fca86b5347d52740031
Cr-Commit-Position: refs/heads/master@{#433336}