Make CPDF_Array take unique_ptrs

Make CPDF_Array take unique_ptrs

BUG=

Committed: https://pdfium.googlesource.com/pdfium/+/8a3aa459fc5284f51bcd7e98e95bf6214f47bb67

[Tom Sepez, 2016-11-15 22:14:31]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-15 22:14:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-11-15 22:20:52]

tsepez@chromium.org changed reviewers:
+ dsinclair@chromium.org, thestig@chromium.org

[Tom Sepez, 2016-11-15 22:20:52]

Dan, for review.

[commit-bot: I haz the power, 2016-11-15 23:00:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 23:00:37]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-11-16 14:58:32]

lgtm w/ nits.

https://codereview.chromium.org/2498223005/diff/1/core/fpdfapi/parser/cpdf_ar...
File core/fpdfapi/parser/cpdf_array_unittest.cpp (right):

https://codereview.chromium.org/2498223005/diff/1/core/fpdfapi/parser/cpdf_ar...
core/fpdfapi/parser/cpdf_array_unittest.cpp:47: 
Add tests for SetAt to verify the out of bounds insertion works?

https://codereview.chromium.org/2498223005/diff/1/fpdfsdk/cpdfsdk_baannot.cpp
File fpdfsdk/cpdfsdk_baannot.cpp (right):

https://codereview.chromium.org/2498223005/diff/1/fpdfsdk/cpdfsdk_baannot.cpp...
fpdfsdk/cpdfsdk_baannot.cpp:247:
pArray->AddNew<CPDF_Number>((FX_FLOAT)FXSYS_GetBValue(color) / 255.0f);
nit: static_cast's

https://codereview.chromium.org/2498223005/diff/1/fpdfsdk/fpdfeditpage.cpp
File fpdfsdk/fpdfeditpage.cpp (right):

https://codereview.chromium.org/2498223005/diff/1/fpdfsdk/fpdfeditpage.cpp#ne...
fpdfsdk/fpdfeditpage.cpp:116:
pMediaBoxArray->AddNew<CPDF_Number>(FX_FLOAT(height));
static_cast?

[Tom Sepez, 2016-11-16 20:08:57]

https://codereview.chromium.org/2498223005/diff/1/core/fpdfapi/parser/cpdf_ar...
File core/fpdfapi/parser/cpdf_array_unittest.cpp (right):

https://codereview.chromium.org/2498223005/diff/1/core/fpdfapi/parser/cpdf_ar...
core/fpdfapi/parser/cpdf_array_unittest.cpp:47: 
On 2016/11/16 14:58:32, dsinclair wrote:
> Add tests for SetAt to verify the out of bounds insertion works? 

Actually, out-of-bounds SetAt() ASSERTS(), at least in debug.

https://codereview.chromium.org/2498223005/diff/1/fpdfsdk/cpdfsdk_baannot.cpp
File fpdfsdk/cpdfsdk_baannot.cpp (right):

https://codereview.chromium.org/2498223005/diff/1/fpdfsdk/cpdfsdk_baannot.cpp...
fpdfsdk/cpdfsdk_baannot.cpp:247:
pArray->AddNew<CPDF_Number>((FX_FLOAT)FXSYS_GetBValue(color) / 255.0f);
On 2016/11/16 14:58:32, dsinclair wrote:
> nit: static_cast's

Done.

https://codereview.chromium.org/2498223005/diff/1/fpdfsdk/fpdfeditpage.cpp
File fpdfsdk/fpdfeditpage.cpp (right):

https://codereview.chromium.org/2498223005/diff/1/fpdfsdk/fpdfeditpage.cpp#ne...
fpdfsdk/fpdfeditpage.cpp:116:
pMediaBoxArray->AddNew<CPDF_Number>(FX_FLOAT(height));
On 2016/11/16 14:58:32, dsinclair wrote:
> static_cast?

done

[Tom Sepez, 2016-11-16 20:09:23]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2016-11-16 20:09:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
dsinclair@chromium.org
Link to the patchset: https://codereview.chromium.org/2498223005/#ps20001
(title: "nits")

[commit-bot: I haz the power, 2016-11-16 20:09:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 20:26:09]

Description was changed from

==========
Make CPDF_Array take unique_ptrs

BUG=
==========

to

==========
Make CPDF_Array take unique_ptrs

BUG=

Committed:
https://pdfium.googlesource.com/pdfium/+/8a3aa459fc5284f51bcd7e98e95bf6214f47...
==========

[commit-bot: I haz the power, 2016-11-16 20:26:13]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/8a3aa459fc5284f51bcd7e98e95bf6214f47...