core/fpdfapi/page/cpdf_streamcontentparser.cpp - Issue 2498223005: Make CPDF_Array take unique_ptrs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/page/cpdf_streamcontentparser.cpp

Issue 2498223005: Make CPDF_Array take unique_ptrs (Closed)

Patch Set: nits Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/page/cpdf_streamcontentparser.cpp

diff --git a/core/fpdfapi/page/cpdf_streamcontentparser.cpp b/core/fpdfapi/page/cpdf_streamcontentparser.cpp

index 69b2b7e4e3c8117eb1cb3107b11cd0d646d21684..5ef47bc68e6ef16bea86b29ed193caa7b46a531d 100644

--- a/core/fpdfapi/page/cpdf_streamcontentparser.cpp

+++ b/core/fpdfapi/page/cpdf_streamcontentparser.cpp

@@ -216,7 +216,7 @@ void ReplaceAbbr(CPDF_Object* pObj) {

CFX_ByteStringC fullname = FindFullName(

InlineValueAbbr, FX_ArraySize(InlineValueAbbr), name.AsStringC());

if (!fullname.IsEmpty())

- pArray->SetAt(i, new CPDF_Name(CFX_ByteString(fullname)));

+ pArray->SetNewAt<CPDF_Name>(i, CFX_ByteString(fullname));

} else {

ReplaceAbbr(pElement);

}

« no previous file with comments | « core/fpdfapi/page/cpdf_image.cpp ('k') | core/fpdfapi/page/cpdf_streamparser.cpp » ('j') | no next file with comments »