Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Side by Side Diff: core/fpdfapi/font/cpdf_fontencoding.cpp

Issue 2498223005: Make CPDF_Array take unique_ptrs (Closed)
Patch Set: nits Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « core/fpdfapi/edit/fpdf_edit_create.cpp ('k') | core/fpdfapi/page/cpdf_image.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 PDFium Authors. All rights reserved. 1 // Copyright 2016 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "core/fpdfapi/font/cpdf_fontencoding.h" 7 #include "core/fpdfapi/font/cpdf_fontencoding.h"
8 8
9 #include "core/fpdfapi/parser/cpdf_array.h" 9 #include "core/fpdfapi/parser/cpdf_array.h"
10 #include "core/fpdfapi/parser/cpdf_dictionary.h" 10 #include "core/fpdfapi/parser/cpdf_dictionary.h"
(...skipping 1685 matching lines...) Expand 10 before | Expand all | Expand 10 after
1696 } 1696 }
1697 if (predefined == PDFFONT_ENCODING_MACEXPERT) { 1697 if (predefined == PDFFONT_ENCODING_MACEXPERT) {
1698 return new CPDF_Name(pPool->Intern("MacExpertEncoding")); 1698 return new CPDF_Name(pPool->Intern("MacExpertEncoding"));
1699 } 1699 }
1700 return nullptr; 1700 return nullptr;
1701 } 1701 }
1702 const uint16_t* pStandard = 1702 const uint16_t* pStandard =
1703 PDF_UnicodesForPredefinedCharSet(PDFFONT_ENCODING_WINANSI); 1703 PDF_UnicodesForPredefinedCharSet(PDFFONT_ENCODING_WINANSI);
1704 CPDF_Array* pDiff = new CPDF_Array; 1704 CPDF_Array* pDiff = new CPDF_Array;
1705 for (int i = 0; i < 256; i++) { 1705 for (int i = 0; i < 256; i++) {
1706 if (pStandard[i] == m_Unicodes[i]) { 1706 if (pStandard[i] == m_Unicodes[i])
1707 continue; 1707 continue;
1708 } 1708
1709 pDiff->Add(new CPDF_Number(i)); 1709 pDiff->AddNew<CPDF_Number>(i);
1710 pDiff->Add(new CPDF_Name(PDF_AdobeNameFromUnicode(m_Unicodes[i]))); 1710 pDiff->AddNew<CPDF_Name>(PDF_AdobeNameFromUnicode(m_Unicodes[i]));
1711 } 1711 }
1712 1712
1713 CPDF_Dictionary* pDict = new CPDF_Dictionary(pPool); 1713 CPDF_Dictionary* pDict = new CPDF_Dictionary(pPool);
1714 pDict->SetNameFor("BaseEncoding", "WinAnsiEncoding"); 1714 pDict->SetNameFor("BaseEncoding", "WinAnsiEncoding");
1715 pDict->SetFor("Differences", pDiff); 1715 pDict->SetFor("Differences", pDiff);
1716 return pDict; 1716 return pDict;
1717 } 1717 }
1718 1718
1719 uint32_t FT_CharCodeFromUnicode(int encoding, FX_WCHAR unicode) { 1719 uint32_t FT_CharCodeFromUnicode(int encoding, FX_WCHAR unicode) {
1720 switch (encoding) { 1720 switch (encoding) {
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
1809 return MacExpertEncoding[(uint8_t)charcode]; 1809 return MacExpertEncoding[(uint8_t)charcode];
1810 case FXFT_ENCODING_ADOBE_LATIN_1: 1810 case FXFT_ENCODING_ADOBE_LATIN_1:
1811 return AdobeWinAnsiEncoding[(uint8_t)charcode]; 1811 return AdobeWinAnsiEncoding[(uint8_t)charcode];
1812 case FXFT_ENCODING_APPLE_ROMAN: 1812 case FXFT_ENCODING_APPLE_ROMAN:
1813 return MacRomanEncoding[(uint8_t)charcode]; 1813 return MacRomanEncoding[(uint8_t)charcode];
1814 case PDFFONT_ENCODING_PDFDOC: 1814 case PDFFONT_ENCODING_PDFDOC:
1815 return PDFDocEncoding[(uint8_t)charcode]; 1815 return PDFDocEncoding[(uint8_t)charcode];
1816 } 1816 }
1817 return 0; 1817 return 0;
1818 } 1818 }
OLDNEW
« no previous file with comments | « core/fpdfapi/edit/fpdf_edit_create.cpp ('k') | core/fpdfapi/page/cpdf_image.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698