DevTools: Add closure compile to buildbot to type check devtools front-end

DevTools: Add closure compile to buildbot to type check devtools front-end

This should only run when devtools front-end files are modified.

BUG=665181
Committed: https://crrev.com/2ee4d24c9f3a42d47950d78763fe8ff4f139395b
Cr-Commit-Position: refs/heads/master@{#433636}

[chenwilliam, 2016-11-15 04:53:49]

Patchset #9 (id:150001) has been deleted

[chenwilliam, 2016-11-16 21:28:57]

chenwilliam@chromium.org changed reviewers:
+ dpranke@chromium.org

[chenwilliam, 2016-11-16 21:28:58]

Please take a look. This is similar to the eslint CL that you started but I made
some tweaks to make it work.

I'm hoping to land this one first, since it's simpler than the eslint CL.

Just to double check, I believe this will only run on CQ & main waterfall if a
CL changes at least one of the files in the gn target group
"devtools_closure_compile". Does that sound right?

Thanks.

https://codereview.chromium.org/2498123002/diff/330001/testing/scripts/run_de...
File testing/scripts/run_devtools_closure_compile.py (right):

https://codereview.chromium.org/2498123002/diff/330001/testing/scripts/run_de...
testing/scripts/run_devtools_closure_compile.py:54:
json.dump(['devtools_closure_compile'], args.output)
I think this is the only part that's closure specific, otherwise I can reuse
this script for eslint.

https://codereview.chromium.org/2498123002/diff/330001/testing/scripts/run_de...
testing/scripts/run_devtools_closure_compile.py:59: if 'compile_targets' in
sys.argv:
I coped this chunk from similar scripts in testing/scripts. When does
"compile_targets" get passed in as an argv? When I tried it on buildbot, it
doesn't look like it's passing in compile_targets as an argv.

[Dirk Pranke, 2016-11-17 02:19:51]

lgtm

https://codereview.chromium.org/2498123002/diff/330001/testing/scripts/run_de...
File testing/scripts/run_devtools_closure_compile.py (right):

https://codereview.chromium.org/2498123002/diff/330001/testing/scripts/run_de...
testing/scripts/run_devtools_closure_compile.py:54:
json.dump(['devtools_closure_compile'], args.output)
On 2016/11/16 21:28:58, chenwilliam wrote:
> I think this is the only part that's closure specific, otherwise I can reuse
> this script for eslint.

Yup, this script is 95% boilerplate, but I'm not quite sure what the right way
to get rid of the boilerplate is at the moment and I don't want you to worry
about it, either.

https://codereview.chromium.org/2498123002/diff/330001/testing/scripts/run_de...
testing/scripts/run_devtools_closure_compile.py:59: if 'compile_targets' in
sys.argv:
On 2016/11/16 21:28:58, chenwilliam wrote:
> I coped this chunk from similar scripts in testing/scripts. When does
> "compile_targets" get passed in as an argv? When I tried it on buildbot, it
> doesn't look like it's passing in compile_targets as an argv.

It gets run as part of the "get compile targets for scripts" step (which you can
see in your tryjob log).

[chenwilliam, 2016-11-17 18:46:04]

The CQ bit was checked by chenwilliam@chromium.org

[commit-bot: I haz the power, 2016-11-17 18:46:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 20:19:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 20:19:13]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[chenwilliam, 2016-11-17 21:27:56]

The CQ bit was checked by chenwilliam@chromium.org

[commit-bot: I haz the power, 2016-11-17 21:28:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chenwilliam, 2016-11-17 23:37:14]

The CQ bit was unchecked by chenwilliam@chromium.org

[chenwilliam, 2016-11-18 19:08:40]

The CQ bit was checked by chenwilliam@chromium.org

[commit-bot: I haz the power, 2016-11-18 19:09:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 22:21:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 22:21:23]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[chenwilliam, 2016-11-18 22:26:28]

The CQ bit was checked by chenwilliam@chromium.org

[commit-bot: I haz the power, 2016-11-18 22:27:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-19 00:19:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-19 00:19:11]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[chenwilliam, 2016-11-21 18:37:14]

The CQ bit was checked by chenwilliam@chromium.org

[commit-bot: I haz the power, 2016-11-21 18:37:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 20:41:47]

CQ is committing da patch.

Bot data: {"patchset_id": 330001, "attempt_start_ts": 1479753434054700,
"parent_rev": "97b531ee680673e7ca34e33bd05bce405a6712e1", "commit_rev":
"2312be01b455ebfacf69b7e0e36a9dbda8090f05"}

[commit-bot: I haz the power, 2016-11-21 20:42:11]

Committed patchset #17 (id:330001)

[commit-bot: I haz the power, 2016-11-21 20:45:36]

Description was changed from

==========
DevTools: Add closure compile to buildbot to type check devtools front-end

This should only run when devtools front-end files are modified.

BUG=665181
==========

to

==========
DevTools: Add closure compile to buildbot to type check devtools front-end

This should only run when devtools front-end files are modified.

BUG=665181

Committed: https://crrev.com/2ee4d24c9f3a42d47950d78763fe8ff4f139395b
Cr-Commit-Position: refs/heads/master@{#433636}
==========

[commit-bot: I haz the power, 2016-11-21 20:45:38]

Patchset 17 (id:??) landed as
https://crrev.com/2ee4d24c9f3a42d47950d78763fe8ff4f139395b
Cr-Commit-Position: refs/heads/master@{#433636}