DevTools: Add closure compile to buildbot to type check devtools front-end

testing/scripts/run_devtools_closure_compile.py

Index: testing/scripts/run_devtools_closure_compile.py
diff --git a/testing/scripts/run_devtools_closure_compile.py b/testing/scripts/run_devtools_closure_compile.py
new file mode 100755
index 0000000000000000000000000000000000000000..1c6d088745058a7f7f673ae0377438fdc209d97e
--- /dev/null
+++ b/testing/scripts/run_devtools_closure_compile.py
@@ -0,0 +1,65 @@
+#!/usr/bin/env python
+# Copyright 2015 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+"""Runs a python script under an isolate
+
+This script attempts to emulate the contract of gtest-style tests
+invoked via recipes. The main contract is that the caller passes the
+argument:
+
+  --isolated-script-test-output=[FILENAME]
+
+json is written to that file in the format produced by
+common.parse_common_test_results.
+
+This script is intended to be the base command invoked by the isolate,
+followed by a subsequent Python script."""
+
+import argparse
+import json
+import os
+import sys
+
+
+import common
+
+# Add src/testing/ into sys.path for importing xvfb.
+sys.path.append(os.path.join(os.path.dirname(__file__), '..'))
+import xvfb
+
+
+def main():
+  parser = argparse.ArgumentParser()
+  parser.add_argument('--isolated-script-test-output', type=str,
+                      required=True)
+  args, rest_args = parser.parse_known_args()
+  # Remove the chartjson extra arg until this script cares about chartjson
+  # results
+  index = 0
+  for arg in rest_args:
+    if '--isolated-script-test-chartjson-output' in arg:
+      rest_args.pop(index)
+      break
+    index += 1
+
+  ret = common.run_command([sys.executable] + rest_args)
+  with open(args.isolated_script_test_output, 'w') as fp:
+    json.dump({'valid': True,
+               'failures': ['failed'] if ret else []}, fp)
+  return ret
+
+def main_compile_targets(args):
+  json.dump(['devtools_closure_compile'], args.output)

[chenwilliam, 2016/11/16 21:28:58]

I think this is the only part that's closure specific, otherwise I can reuse
this script for eslint.

[Dirk Pranke, 2016/11/17 02:19:51]

Yup, this script is 95% boilerplate, but I'm not quite sure what the right way
to get rid of the boilerplate is at the moment and I don't want you to worry
about it, either.

+
+
+if __name__ == '__main__':
+  # Conform minimally to the protocol defined by ScriptTest.
+  if 'compile_targets' in sys.argv:

[chenwilliam, 2016/11/16 21:28:58]

I coped this chunk from similar scripts in testing/scripts. When does
"compile_targets" get passed in as an argv? When I tried it on buildbot, it
doesn't look like it's passing in compile_targets as an argv.

[Dirk Pranke, 2016/11/17 02:19:51]

It gets run as part of the "get compile targets for scripts" step (which you can
see in your tryjob log).

+    funcs = {
+      'run': None,
+      'compile_targets': main_compile_targets,
+    }
+    sys.exit(common.run_script(sys.argv[1:], funcs))
+  sys.exit(main())