Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1027)

Unified Diff: third_party/WebKit/Source/devtools/BUILD.gn

Issue 2498123002: DevTools: Add closure compile to buildbot to type check devtools front-end (Closed)
Patch Set: Fix GN w/o Type Error Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/BUILD.gn
diff --git a/third_party/WebKit/Source/devtools/BUILD.gn b/third_party/WebKit/Source/devtools/BUILD.gn
index 0cba489c0580beb7eb30cbc6d24da931136bfe7e..31e98f157f1605a3ca104fd6ea284be2ed586343 100644
--- a/third_party/WebKit/Source/devtools/BUILD.gn
+++ b/third_party/WebKit/Source/devtools/BUILD.gn
@@ -1156,3 +1156,19 @@ if (debug_devtools) {
]
}
}
+
+group("devtools_closure_compile") {
+ data = [
+ # Needed for isolate script to execute.
+ "front_end/",
+ "scripts/build/",
+ "scripts/closure/",
+ "scripts/compile_frontend.py",
+ "scripts/jsdoc_validator/",
+ "//testing/scripts/run_devtools_closure_compile.py",
+ "//testing/scripts/common.py",
+ "//testing/xvfb.py",
+ "//third_party/WebKit/Source/core/inspector/browser_protocol.json",
+ "//v8/src/inspector/js_protocol.json",
+ ]
+}

Powered by Google App Engine
This is Rietveld 408576698