Add InProcessContextProvider and update InProcessCommandBuffer

Add InProcessContextProvider and update InProcessCommandBuffer

The Mus-Gpu Display Compositor will use an InProcessContextProvider and
InProcessCommandBuffer in place of SurfacesContextProvider,
GpuChannelHost, and CommandBufferProxyImpl to avoid the IPC overhead of
those classes. This CL introduces InProcessContextProvider and allows
InProcessCommandBuffer to coexist with GpuCommandBufferStubs
on the same thread.

In particular, when an InProcessCommandBuffer hits a sync token, it
will now get descheduled if specified by
InProcessCommandBuffer::Service until the token is passed. At that
point, it will finish the flush and run all the operations that have
been queued up since the command buffer was descheduled. This enables
other command buffers on the same thread to make progress.

BUG=661278
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Committed: https://crrev.com/edc0c2c7a7de29978b3c25d6f80ccee88aa00125
Cr-Commit-Position: refs/heads/master@{#433313}

[Fady Samuel, 2016-11-15 21:20:17]

Description was changed from

==========
Support switching CommandBuffers on same thread with InProcessCommandBuffer

BUG=
==========

to

==========
Support switching CommandBuffers on same thread with InProcessCommandBuffer

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Fady Samuel, 2016-11-15 21:20:18]

Description was changed from

==========
Support switching CommandBuffers on same thread with InProcessCommandBuffer

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Support switching CommandBuffers on same thread with InProcessCommandBuffer

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Fady Samuel, 2016-11-15 21:28:46]

Description was changed from

==========
Support switching CommandBuffers on same thread with InProcessCommandBuffer

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Add InProcessContextProvider and update InProcessCommandBuffer

The Mus-Gpu Display Compositor will use an InProcessContextProvider and
InProcessCommandBuffer in place of GpuChannelHost, and 
CommandBufferProxyImpl to avoid the IPC overhead of those classes. This 
CL introduces InProcessContextProvider and allows 
InProcessCommandBuffer to coexist with GpuCommandBufferStubs
on the same thread.

In particular, when an InProcessCommandBuffer hits a sync token, it
will now get descheduled if specified by 
InProcessCommandBuffer::Service until the token is passed. At that point, it
will finish the flush and run all the operations that have been queued up since
the command buffer was descheduled. This enables
other command buffers on the same thread to make progress.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Fady Samuel, 2016-11-15 21:28:46]

Description was changed from

==========
Support switching CommandBuffers on same thread with InProcessCommandBuffer

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Add InProcessContextProvider and update InProcessCommandBuffer

The Mus-Gpu Display Compositor will use an InProcessContextProvider and
InProcessCommandBuffer in place of GpuChannelHost, and 
CommandBufferProxyImpl to avoid the IPC overhead of those classes. This 
CL introduces InProcessContextProvider and allows 
InProcessCommandBuffer to coexist with GpuCommandBufferStubs
on the same thread.

In particular, when an InProcessCommandBuffer hits a sync token, it
will now get descheduled if specified by 
InProcessCommandBuffer::Service until the token is passed. At that point, it
will finish the flush and run all the operations that have been queued up since
the command buffer was descheduled. This enables
other command buffers on the same thread to make progress.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Fady Samuel, 2016-11-15 21:29:28]

Description was changed from

==========
Add InProcessContextProvider and update InProcessCommandBuffer

The Mus-Gpu Display Compositor will use an InProcessContextProvider and
InProcessCommandBuffer in place of GpuChannelHost, and 
CommandBufferProxyImpl to avoid the IPC overhead of those classes. This 
CL introduces InProcessContextProvider and allows 
InProcessCommandBuffer to coexist with GpuCommandBufferStubs
on the same thread.

In particular, when an InProcessCommandBuffer hits a sync token, it
will now get descheduled if specified by 
InProcessCommandBuffer::Service until the token is passed. At that point, it
will finish the flush and run all the operations that have been queued up since
the command buffer was descheduled. This enables
other command buffers on the same thread to make progress.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Add InProcessContextProvider and update InProcessCommandBuffer

The Mus-Gpu Display Compositor will use an InProcessContextProvider and
InProcessCommandBuffer in place of SurfacesContextProvider, 
GpuChannelHost, and CommandBufferProxyImpl to avoid the IPC overhead of 
those classes. This CL introduces InProcessContextProvider and allows 
InProcessCommandBuffer to coexist with GpuCommandBufferStubs
on the same thread.

In particular, when an InProcessCommandBuffer hits a sync token, it
will now get descheduled if specified by 
InProcessCommandBuffer::Service until the token is passed. At that point, it
will finish the flush and run all the operations that have been queued up since
the command buffer was descheduled. This enables
other command buffers on the same thread to make progress.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Fady Samuel, 2016-11-15 21:29:40]

Description was changed from

==========
Add InProcessContextProvider and update InProcessCommandBuffer

The Mus-Gpu Display Compositor will use an InProcessContextProvider and
InProcessCommandBuffer in place of SurfacesContextProvider, 
GpuChannelHost, and CommandBufferProxyImpl to avoid the IPC overhead of 
those classes. This CL introduces InProcessContextProvider and allows 
InProcessCommandBuffer to coexist with GpuCommandBufferStubs
on the same thread.

In particular, when an InProcessCommandBuffer hits a sync token, it
will now get descheduled if specified by 
InProcessCommandBuffer::Service until the token is passed. At that point, it
will finish the flush and run all the operations that have been queued up since
the command buffer was descheduled. This enables
other command buffers on the same thread to make progress.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Add InProcessContextProvider and update InProcessCommandBuffer

The Mus-Gpu Display Compositor will use an InProcessContextProvider and
InProcessCommandBuffer in place of SurfacesContextProvider, 
GpuChannelHost, and CommandBufferProxyImpl to avoid the IPC overhead of 
those classes. This CL introduces InProcessContextProvider and allows 
InProcessCommandBuffer to coexist with GpuCommandBufferStubs
on the same thread.

In particular, when an InProcessCommandBuffer hits a sync token, it
will now get descheduled if specified by 
InProcessCommandBuffer::Service until the token is passed. At that 
point, it will finish the flush and run all the operations that have 
been queued up since the command buffer was descheduled. This enables
other command buffers on the same thread to make progress.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Fady Samuel, 2016-11-15 21:30:10]

Description was changed from

==========
Add InProcessContextProvider and update InProcessCommandBuffer

The Mus-Gpu Display Compositor will use an InProcessContextProvider and
InProcessCommandBuffer in place of SurfacesContextProvider, 
GpuChannelHost, and CommandBufferProxyImpl to avoid the IPC overhead of 
those classes. This CL introduces InProcessContextProvider and allows 
InProcessCommandBuffer to coexist with GpuCommandBufferStubs
on the same thread.

In particular, when an InProcessCommandBuffer hits a sync token, it
will now get descheduled if specified by 
InProcessCommandBuffer::Service until the token is passed. At that 
point, it will finish the flush and run all the operations that have 
been queued up since the command buffer was descheduled. This enables
other command buffers on the same thread to make progress.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Add InProcessContextProvider and update InProcessCommandBuffer

The Mus-Gpu Display Compositor will use an InProcessContextProvider and
InProcessCommandBuffer in place of SurfacesContextProvider, 
GpuChannelHost, and CommandBufferProxyImpl to avoid the IPC overhead of 
those classes. This CL introduces InProcessContextProvider and allows 
InProcessCommandBuffer to coexist with GpuCommandBufferStubs
on the same thread.

In particular, when an InProcessCommandBuffer hits a sync token, it
will now get descheduled if specified by 
InProcessCommandBuffer::Service until the token is passed. At that 
point, it will finish the flush and run all the operations that have 
been queued up since the command buffer was descheduled. This enables
other command buffers on the same thread to make progress.

BUG=661278
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Fady Samuel, 2016-11-15 21:31:14]

fsamuel@chromium.org changed reviewers:
+ piman@chromium.org

[piman, 2016-11-15 21:57:32]

https://codereview.chromium.org/2498053004/diff/1/cc/surfaces/BUILD.gn
File cc/surfaces/BUILD.gn (right):

https://codereview.chromium.org/2498053004/diff/1/cc/surfaces/BUILD.gn#newcode20
cc/surfaces/BUILD.gn:20: source_set("context_provider") {
How about cc/output instead of cc/surfaces for these?
That's where ContextProvider is, and it really has nothing to do with surfaces.

https://codereview.chromium.org/2498053004/diff/1/cc/surfaces/deferred_gpu_co...
File cc/surfaces/deferred_gpu_command_service.h (right):

https://codereview.chromium.org/2498053004/diff/1/cc/surfaces/deferred_gpu_co...
cc/surfaces/deferred_gpu_command_service.h:14: class DeferredGpuCommandService
nit: names... nothing "deferred" about this really. I wonder if we could merge
with GpuInProcessThread, because it does pretty much the same thing, *except*
GpuInProcessThread also owns the thread - but this could simply be an extra
option.

https://codereview.chromium.org/2498053004/diff/1/cc/surfaces/deferred_gpu_co...
cc/surfaces/deferred_gpu_command_service.h:44: std::queue<base::Closure> tasks_;
nit: those aren't used.

https://codereview.chromium.org/2498053004/diff/1/cc/surfaces/in_process_cont...
File cc/surfaces/in_process_context_provider.cc (right):

https://codereview.chromium.org/2498053004/diff/1/cc/surfaces/in_process_cont...
cc/surfaces/in_process_context_provider.cc:156:
context_->GetInProcessCommandBuffer()->SetSwapBuffersCompletionCallback(
nit: Demeter is crying. Could we expose SetSwapBuffersCompletionCallback and
SetUpdateVSyncParametersCallback on GLInProcessContext instead of exposing
InProcessCommandBuffer?

https://codereview.chromium.org/2498053004/diff/1/gpu/ipc/in_process_command_...
File gpu/ipc/in_process_command_buffer.cc (left):

https://codereview.chromium.org/2498053004/diff/1/gpu/ipc/in_process_command_...
gpu/ipc/in_process_command_buffer.cc:342: surface_ =
gl::init::CreateOffscreenGLSurface(gfx::Size());
We need to keep the offscreen path, and only use
ImageTransportSurface::CreateNativeSurface for !offscreen

https://codereview.chromium.org/2498053004/diff/1/gpu/ipc/in_process_command_...
File gpu/ipc/in_process_command_buffer.cc (right):

https://codereview.chromium.org/2498053004/diff/1/gpu/ipc/in_process_command_...
gpu/ipc/in_process_command_buffer.cc:1172: return true;
I think this should be false here, but set to true in
android_webview::DeferredGpuCommandService

[Fady Samuel, 2016-11-16 00:33:35]

PTAL Antoine!

https://codereview.chromium.org/2498053004/diff/1/cc/surfaces/BUILD.gn
File cc/surfaces/BUILD.gn (right):

https://codereview.chromium.org/2498053004/diff/1/cc/surfaces/BUILD.gn#newcode20
cc/surfaces/BUILD.gn:20: source_set("context_provider") {
On 2016/11/15 21:57:32, piman wrote:
> How about cc/output instead of cc/surfaces for these?
> That's where ContextProvider is, and it really has nothing to do with
surfaces.

Done.

https://codereview.chromium.org/2498053004/diff/1/cc/surfaces/deferred_gpu_co...
File cc/surfaces/deferred_gpu_command_service.h (right):

https://codereview.chromium.org/2498053004/diff/1/cc/surfaces/deferred_gpu_co...
cc/surfaces/deferred_gpu_command_service.h:14: class DeferredGpuCommandService
On 2016/11/15 21:57:32, piman wrote:
> nit: names... nothing "deferred" about this really. I wonder if we could merge
> with GpuInProcessThread, because it does pretty much the same thing, *except*
> GpuInProcessThread also owns the thread - but this could simply be an extra
> option.

Done.

https://codereview.chromium.org/2498053004/diff/1/cc/surfaces/deferred_gpu_co...
cc/surfaces/deferred_gpu_command_service.h:44: std::queue<base::Closure> tasks_;
On 2016/11/15 21:57:32, piman wrote:
> nit: those aren't used.

Done.

https://codereview.chromium.org/2498053004/diff/1/cc/surfaces/in_process_cont...
File cc/surfaces/in_process_context_provider.cc (right):

https://codereview.chromium.org/2498053004/diff/1/cc/surfaces/in_process_cont...
cc/surfaces/in_process_context_provider.cc:156:
context_->GetInProcessCommandBuffer()->SetSwapBuffersCompletionCallback(
On 2016/11/15 21:57:32, piman wrote:
> nit: Demeter is crying. Could we expose SetSwapBuffersCompletionCallback and
> SetUpdateVSyncParametersCallback on GLInProcessContext instead of exposing
> InProcessCommandBuffer?

Done.

https://codereview.chromium.org/2498053004/diff/1/gpu/ipc/in_process_command_...
File gpu/ipc/in_process_command_buffer.cc (left):

https://codereview.chromium.org/2498053004/diff/1/gpu/ipc/in_process_command_...
gpu/ipc/in_process_command_buffer.cc:342: surface_ =
gl::init::CreateOffscreenGLSurface(gfx::Size());
On 2016/11/15 21:57:32, piman wrote:
> We need to keep the offscreen path, and only use
> ImageTransportSurface::CreateNativeSurface for !offscreen

Done.

https://codereview.chromium.org/2498053004/diff/1/gpu/ipc/in_process_command_...
File gpu/ipc/in_process_command_buffer.cc (right):

https://codereview.chromium.org/2498053004/diff/1/gpu/ipc/in_process_command_...
gpu/ipc/in_process_command_buffer.cc:1172: return true;
On 2016/11/15 21:57:32, piman wrote:
> I think this should be false here, but set to true in
> android_webview::DeferredGpuCommandService

Done.

[Fady Samuel, 2016-11-16 00:33:40]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 00:34:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 00:49:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 00:49:17]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  blimp_linux_dbg on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/blimp_linux_dbg...)

[piman, 2016-11-16 00:50:16]

lgtm

https://codereview.chromium.org/2498053004/diff/20001/cc/BUILD.gn
File cc/BUILD.gn (right):

https://codereview.chromium.org/2498053004/diff/20001/cc/BUILD.gn#newcode589
cc/BUILD.gn:589: "//gpu/command_buffer/client:gles2_c_lib",
nit: You shouldn't need this one

[Fady Samuel, 2016-11-16 01:04:47]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[Fady Samuel, 2016-11-16 01:05:12]

fsamuel@chromium.org changed reviewers:
+ boliu@chromium.org

[Fady Samuel, 2016-11-16 01:05:14]

+boliu@ for android_webview.

https://codereview.chromium.org/2498053004/diff/20001/cc/BUILD.gn
File cc/BUILD.gn (right):

https://codereview.chromium.org/2498053004/diff/20001/cc/BUILD.gn#newcode589
cc/BUILD.gn:589: "//gpu/command_buffer/client:gles2_c_lib",
On 2016/11/16 00:50:16, piman wrote:
> nit: You shouldn't need this one

Done.

[commit-bot: I haz the power, 2016-11-16 01:05:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Fady Samuel, 2016-11-16 01:11:37]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 01:12:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Fady Samuel, 2016-11-16 01:21:59]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 01:22:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[boliu, 2016-11-16 01:35:11]

lgtm

[commit-bot: I haz the power, 2016-11-16 01:41:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 01:41:18]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Fady Samuel, 2016-11-16 02:41:44]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 02:42:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 02:58:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 02:58:34]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Fady Samuel, 2016-11-16 03:08:14]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 03:08:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 03:27:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 03:27:12]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[Fady Samuel, 2016-11-16 04:28:21]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 04:28:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 04:45:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 04:45:05]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Fady Samuel, 2016-11-16 15:47:11]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 15:47:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 16:03:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 16:03:01]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Fady Samuel, 2016-11-16 16:52:53]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 16:53:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Fady Samuel, 2016-11-16 17:14:28]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 17:15:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 17:25:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 17:25:09]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Fady Samuel, 2016-11-16 18:10:40]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 18:11:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 18:58:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 18:58:10]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Fady Samuel, 2016-11-16 19:04:40]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 19:06:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 19:41:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 19:41:04]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Fady Samuel, 2016-11-16 20:23:19]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 20:23:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Fady Samuel, 2016-11-16 20:28:36]

fsamuel@chromium.org changed reviewers:
+ dtrainor@chromium.org

[Fady Samuel, 2016-11-16 20:28:37]

+dtrainor@ for blimp changes.
+piman@: PTAL for recent changes: more plumbing of SurfaceHandle.
InProcessCommandBuffer uses SurfaceHandle because it uses ImageTransportSurface
now, and thus all things that depend on InProcessCommandBuffer needed to be
updated. Clients that use *ContextProvider that uses InProcessCommandBuffer now
translate AcceleratedWidget to SurfaceHandle as necessary. I also had to
explicitly enable OSMesa in tests in some cases because ImageTransportSurface
needed that.

[Fady Samuel, 2016-11-16 20:31:22]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 20:32:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Fady Samuel, 2016-11-16 20:43:34]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 20:44:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[piman, 2016-11-16 20:48:50]

https://codereview.chromium.org/2498053004/diff/300001/ui/compositor/test/in_...
File ui/compositor/test/in_process_context_factory.cc (right):

https://codereview.chromium.org/2498053004/diff/300001/ui/compositor/test/in_...
ui/compositor/test/in_process_context_factory.cc:178: surface_handle =
tracker->AddSurfaceForNativeWidget(compositor->widget());
Should we remove in RemoveCompositor?

[Fady Samuel, 2016-11-16 21:08:43]

PTAL Antoine, David!

[Fady Samuel, 2016-11-16 21:08:51]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 21:10:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[David Trainor- moved to gerrit, 2016-11-16 21:13:52]

Small nit suggestion, but lgtm either way.

https://codereview.chromium.org/2498053004/diff/340001/blimp/client/app/compo...
File blimp/client/app/compositor/browser_compositor.h (right):

https://codereview.chromium.org/2498053004/diff/340001/blimp/client/app/compo...
blimp/client/app/compositor/browser_compositor.h:41: gpu::SurfaceHandle
surface_handle_ = gpu::kNullSurfaceHandle;
Would it make sense to just put this inside BlimpContextProvider?

[Fady Samuel, 2016-11-16 21:16:17]

Thanks David! I'm not going to make your change because I'd like the usage to
match elsewhere in Chrome. ContextProviders should not be using
GpuSurfaceTracker...and if they do end up doing so, I'd like to make it
consistent throughout. In the interest of consistency, I will leave it as is.

https://codereview.chromium.org/2498053004/diff/340001/blimp/client/app/compo...
File blimp/client/app/compositor/browser_compositor.h (right):

https://codereview.chromium.org/2498053004/diff/340001/blimp/client/app/compo...
blimp/client/app/compositor/browser_compositor.h:41: gpu::SurfaceHandle
surface_handle_ = gpu::kNullSurfaceHandle;
On 2016/11/16 21:13:52, David Trainor wrote:
> Would it make sense to just put this inside BlimpContextProvider?

That doesn't match the pattern used in other code. The ContextProvider simply
takes in a SurfaceHandle, but the thing that owns the ContextProvider is what
creates it.

[commit-bot: I haz the power, 2016-11-16 21:55:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 21:55:34]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[piman, 2016-11-16 22:00:53]

lgtm

[Fady Samuel, 2016-11-16 22:25:07]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 22:26:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Fady Samuel, 2016-11-16 22:34:36]

fsamuel@chromium.org changed reviewers:
+ sky@chromium.org

[Fady Samuel, 2016-11-16 22:34:37]

+sky@ for chrome/test

[Fady Samuel, 2016-11-16 22:34:45]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 22:36:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 23:28:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 23:28:31]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Fady Samuel, 2016-11-16 23:48:04]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 23:49:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Fady Samuel, 2016-11-16 23:57:50]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 23:59:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2016-11-17 00:38:45]

LGTM

[commit-bot: I haz the power, 2016-11-17 01:07:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 01:07:18]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Fady Samuel, 2016-11-17 02:20:10]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 02:21:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Fady Samuel, 2016-11-17 02:23:29]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 02:24:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 04:06:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 04:06:13]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Fady Samuel, 2016-11-17 04:27:49]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 04:28:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 04:34:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 04:34:38]

Dry run: Try jobs failed on following builders:
  linux_trusty_blink_rel on master.tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_trusty_blink_rel/b...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Fady Samuel, 2016-11-17 04:38:11]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 04:38:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 05:38:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 05:38:29]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Fady Samuel, 2016-11-17 21:18:54]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 21:20:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 23:17:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 23:17:45]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Fady Samuel, 2016-11-18 02:08:19]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 02:09:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 02:22:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 02:22:31]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Fady Samuel, 2016-11-18 02:23:06]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 02:24:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 02:36:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 02:36:37]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Fady Samuel, 2016-11-18 03:58:00]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 03:58:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Fady Samuel, 2016-11-18 05:27:24]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 05:28:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 07:17:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 07:17:43]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Fady Samuel, 2016-11-18 18:04:27]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 18:05:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Fady Samuel, 2016-11-18 19:58:47]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2016-11-18 19:58:48]

The patchset sent to the CQ was uploaded after l-g-t-m from boliu@chromium.org,
dtrainor@chromium.org, piman@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2498053004/#ps610001
(title: "Revert experiments and fix android_webview")

[commit-bot: I haz the power, 2016-11-18 19:59:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 22:29:23]

Description was changed from

==========
Add InProcessContextProvider and update InProcessCommandBuffer

The Mus-Gpu Display Compositor will use an InProcessContextProvider and
InProcessCommandBuffer in place of SurfacesContextProvider, 
GpuChannelHost, and CommandBufferProxyImpl to avoid the IPC overhead of 
those classes. This CL introduces InProcessContextProvider and allows 
InProcessCommandBuffer to coexist with GpuCommandBufferStubs
on the same thread.

In particular, when an InProcessCommandBuffer hits a sync token, it
will now get descheduled if specified by 
InProcessCommandBuffer::Service until the token is passed. At that 
point, it will finish the flush and run all the operations that have 
been queued up since the command buffer was descheduled. This enables
other command buffers on the same thread to make progress.

BUG=661278
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Add InProcessContextProvider and update InProcessCommandBuffer

The Mus-Gpu Display Compositor will use an InProcessContextProvider and
InProcessCommandBuffer in place of SurfacesContextProvider, 
GpuChannelHost, and CommandBufferProxyImpl to avoid the IPC overhead of 
those classes. This CL introduces InProcessContextProvider and allows 
InProcessCommandBuffer to coexist with GpuCommandBufferStubs
on the same thread.

In particular, when an InProcessCommandBuffer hits a sync token, it
will now get descheduled if specified by 
InProcessCommandBuffer::Service until the token is passed. At that 
point, it will finish the flush and run all the operations that have 
been queued up since the command buffer was descheduled. This enables
other command buffers on the same thread to make progress.

BUG=661278
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[commit-bot: I haz the power, 2016-11-18 22:29:25]

Committed patchset #32 (id:610001)

[commit-bot: I haz the power, 2016-11-18 22:32:08]

Description was changed from

==========
Add InProcessContextProvider and update InProcessCommandBuffer

The Mus-Gpu Display Compositor will use an InProcessContextProvider and
InProcessCommandBuffer in place of SurfacesContextProvider, 
GpuChannelHost, and CommandBufferProxyImpl to avoid the IPC overhead of 
those classes. This CL introduces InProcessContextProvider and allows 
InProcessCommandBuffer to coexist with GpuCommandBufferStubs
on the same thread.

In particular, when an InProcessCommandBuffer hits a sync token, it
will now get descheduled if specified by 
InProcessCommandBuffer::Service until the token is passed. At that 
point, it will finish the flush and run all the operations that have 
been queued up since the command buffer was descheduled. This enables
other command buffers on the same thread to make progress.

BUG=661278
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Add InProcessContextProvider and update InProcessCommandBuffer

The Mus-Gpu Display Compositor will use an InProcessContextProvider and
InProcessCommandBuffer in place of SurfacesContextProvider,
GpuChannelHost, and CommandBufferProxyImpl to avoid the IPC overhead of
those classes. This CL introduces InProcessContextProvider and allows
InProcessCommandBuffer to coexist with GpuCommandBufferStubs
on the same thread.

In particular, when an InProcessCommandBuffer hits a sync token, it
will now get descheduled if specified by
InProcessCommandBuffer::Service until the token is passed. At that
point, it will finish the flush and run all the operations that have
been queued up since the command buffer was descheduled. This enables
other command buffers on the same thread to make progress.

BUG=661278
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Committed: https://crrev.com/edc0c2c7a7de29978b3c25d6f80ccee88aa00125
Cr-Commit-Position: refs/heads/master@{#433313}
==========

[commit-bot: I haz the power, 2016-11-18 22:32:10]

Patchset 32 (id:??) landed as
https://crrev.com/edc0c2c7a7de29978b3c25d6f80ccee88aa00125
Cr-Commit-Position: refs/heads/master@{#433313}