Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 2498013004: Convert thai-line-breaks to a ref test (Closed)

Created:
4 years, 1 month ago by jungshik at Google
Modified:
4 years, 1 month ago
Reviewers:
drott
CC:
chromium-reviews, blink-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert thai-line-breaks to a ref test ICU was used to generate the expected result. (see http://paste.lisp.org/display/331567 ). Update TestExpectations. This test should always pass on all platforms. BUG=661764 TEST=fast/text/international/thai-line-breaks Committed: https://crrev.com/4595e6bb1e424666f1718486a90f42a37253c35a Cr-Commit-Position: refs/heads/master@{#432234}

Patch Set 1 #

Patch Set 2 : update TestExpectation for Win #

Unified diffs Side-by-side diffs Delta from patch set Stats (+328 lines, -10804 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/text/international/thai-line-breaks.html View 2 chunks +2 lines, -329 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/text/international/thai-line-breaks-expected.html View 1 chunk +326 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/fast/text/international/thai-line-breaks-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/fast/text/international/thai-line-breaks-expected.txt View 1 chunk +0 lines, -2618 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/fast/text/international/thai-line-breaks-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/fast/text/international/thai-line-breaks-expected.txt View 1 chunk +0 lines, -2618 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/international/thai-line-breaks-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/text/international/thai-line-breaks-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/fast/text/international/thai-line-breaks-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/fast/text/international/thai-line-breaks-expected.txt View 1 chunk +0 lines, -2619 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/fast/text/international/thai-line-breaks-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/fast/text/international/thai-line-breaks-expected.txt View 1 chunk +0 lines, -2619 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win7/fast/text/international/thai-line-breaks-expected.png View Binary file 0 comments Download

Messages

Total messages: 9 (4 generated)
jungshik at Google
Dominik, can you take a look?
4 years, 1 month ago (2016-11-15 08:35:08 UTC) #3
drott
LGTM
4 years, 1 month ago (2016-11-15 08:46:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2498013004/20001
4 years, 1 month ago (2016-11-15 18:11:59 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-15 19:28:00 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 19:35:01 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4595e6bb1e424666f1718486a90f42a37253c35a
Cr-Commit-Position: refs/heads/master@{#432234}

Powered by Google App Engine
This is Rietveld 408576698