Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2497483002:
[Turbofan] CodeGenerator for ARM avoids moves from VFP to general regs. (Closed)
|
Created:
4 years, 1 month ago by bbudge Modified:
4 years, 1 month ago Reviewers:
Benedikt Meurer CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[Turbofan] CodeGenerator for ARM avoids moves from VFP to general regs.
- Adds VmovExtended, VswpExtended methods to MacroAssembler. These methods
use only VFP registers to perform s-register moves.
LOG=N
BUG=v8:4124
Committed: https://crrev.com/99c8144773bbde80bce17717807e6321715eddff
Cr-Commit-Position: refs/heads/master@{#40939}
Patch Set 1 #Patch Set 2 : Fix VswpExtended bug, eliminate stray define. #Patch Set 3 : Add comments, DCHECKs for completeness. #Patch Set 4 : Fix bug in VswpExtended. #
Messages
Total messages: 32 (22 generated)
The CQ bit was checked by bbudge@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...) v8_linux_arm_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng_trigger...)
The CQ bit was checked by bbudge@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
bbudge@chromium.org changed reviewers: + bmeurer@chromium.org
Description was changed from ========== [Turbofan] CodeGenerator for ARM avoids moves from VFP to general regs. - Adds VmovExtended, VswpExtended methods to MacroAssembler. LOG=N BUG=v8:4124 ========== to ========== [Turbofan] CodeGenerator for ARM avoids moves from VFP to general regs. - Adds VmovExtended, VswpExtended methods to MacroAssembler. These methods use only VFP registers to perform s-register moves. LOG=N BUG=v8:4124 ==========
lgtm
The CQ bit was checked by bbudge@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Sorry for the additional upload, I added some comments and DCHECKs but otherwise should be identical.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Still LGTM.
The CQ bit was checked by bbudge@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by bbudge@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org Link to the patchset: https://codereview.chromium.org/2497483002/#ps60001 (title: "Fix bug in VswpExtended.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [Turbofan] CodeGenerator for ARM avoids moves from VFP to general regs. - Adds VmovExtended, VswpExtended methods to MacroAssembler. These methods use only VFP registers to perform s-register moves. LOG=N BUG=v8:4124 ========== to ========== [Turbofan] CodeGenerator for ARM avoids moves from VFP to general regs. - Adds VmovExtended, VswpExtended methods to MacroAssembler. These methods use only VFP registers to perform s-register moves. LOG=N BUG=v8:4124 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Hi Benedikt, this doesn't seem to improve performance on any bots. I think I should revert. WDYT?
Message was sent while issue was closed.
On 2016/11/16 00:38:10, bbudge wrote: > Hi Benedikt, this doesn't seem to improve performance on any bots. I think I > should revert. WDYT? SGTM
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/2505003002/ by bbudge@chromium.org. The reason for reverting is: This was a speculative fix for perf regressions on Nexus 10 and ChromeOS. However, perf graphs after this landed show no improvement, so we should go back to the smaller, simpler code before..
Message was sent while issue was closed.
Description was changed from ========== [Turbofan] CodeGenerator for ARM avoids moves from VFP to general regs. - Adds VmovExtended, VswpExtended methods to MacroAssembler. These methods use only VFP registers to perform s-register moves. LOG=N BUG=v8:4124 ========== to ========== [Turbofan] CodeGenerator for ARM avoids moves from VFP to general regs. - Adds VmovExtended, VswpExtended methods to MacroAssembler. These methods use only VFP registers to perform s-register moves. LOG=N BUG=v8:4124 Committed: https://crrev.com/99c8144773bbde80bce17717807e6321715eddff Cr-Commit-Position: refs/heads/master@{#40939} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/99c8144773bbde80bce17717807e6321715eddff Cr-Commit-Position: refs/heads/master@{#40939} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
