Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: src/compiler/arm/code-generator-arm.cc

Issue 2497483002: [Turbofan] CodeGenerator for ARM avoids moves from VFP to general regs. (Closed)
Patch Set: Fix bug in VswpExtended. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/arm/macro-assembler-arm.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/arm/code-generator-arm.cc
diff --git a/src/compiler/arm/code-generator-arm.cc b/src/compiler/arm/code-generator-arm.cc
index 4acc0562c3f526cb2d41a60cb1839c08dcac8b6e..4b9c607659254f842ceb514c5e973ea47104b71d 100644
--- a/src/compiler/arm/code-generator-arm.cc
+++ b/src/compiler/arm/code-generator-arm.cc
@@ -1898,10 +1898,10 @@ void CodeGenerator::AssembleMove(InstructionOperand* source,
int src_code = LocationOperand::cast(source)->register_code();
if (destination->IsFloatRegister()) {
int dst_code = LocationOperand::cast(destination)->register_code();
- __ VmovExtended(dst_code, src_code, kScratchReg);
+ __ VmovExtended(dst_code, src_code);
} else {
DCHECK(destination->IsFloatStackSlot());
- __ VmovExtended(g.ToMemOperand(destination), src_code, kScratchReg);
+ __ VmovExtended(g.ToMemOperand(destination), src_code);
}
}
} else if (source->IsFPStackSlot()) {
@@ -1916,7 +1916,7 @@ void CodeGenerator::AssembleMove(InstructionOperand* source,
// GapResolver may give us reg codes that don't map to actual
// s-registers. Generate code to work around those cases.
int dst_code = LocationOperand::cast(destination)->register_code();
- __ VmovExtended(dst_code, src, kScratchReg);
+ __ VmovExtended(dst_code, src);
}
} else {
DCHECK(destination->IsFPStackSlot());
@@ -1988,15 +1988,11 @@ void CodeGenerator::AssembleSwap(InstructionOperand* source,
int src_code = LocationOperand::cast(source)->register_code();
if (destination->IsFPRegister()) {
int dst_code = LocationOperand::cast(destination)->register_code();
- __ VmovExtended(temp.low().code(), src_code, kScratchReg);
- __ VmovExtended(src_code, dst_code, kScratchReg);
- __ VmovExtended(dst_code, temp.low().code(), kScratchReg);
+ __ VswpExtended(dst_code, src_code);
} else {
DCHECK(destination->IsFPStackSlot());
MemOperand dst = g.ToMemOperand(destination);
- __ VmovExtended(temp.low().code(), src_code, kScratchReg);
- __ VmovExtended(src_code, dst, kScratchReg);
- __ vstr(temp.low(), dst);
+ __ VswpExtended(dst, src_code);
}
}
} else if (source->IsFPStackSlot()) {
« no previous file with comments | « src/arm/macro-assembler-arm.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698