arc: Partially migrate mojo types

arc: Partially migrate mojo types

This splits off the build target that compiles all .mojom files into
two, so that we can migrate them one by one instead of having a massive
migration change.

BUG=624136
TEST=trybots

Committed: https://crrev.com/5ec7c09e047b30460d3debb26743bd7103c9f327
Cr-Commit-Position: refs/heads/master@{#431703}

[Luis Héctor Chávez, 2016-11-11 17:25:22]

The CQ bit was checked by lhchavez@chromium.org to run a CQ dry run

[Luis Héctor Chávez, 2016-11-11 17:25:31]

lhchavez@chromium.org changed reviewers:
+ yusukes@chromium.org

[Luis Héctor Chávez, 2016-11-11 17:25:32]

PTAL

[commit-bot: I haz the power, 2016-11-11 17:25:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yusuke Sato, 2016-11-11 17:33:37]

https://codereview.chromium.org/2496973002/diff/1/chrome/browser/chromeos/arc...
File
chrome/browser/chromeos/arc/downloads_watcher/arc_downloads_watcher_service.h
(right):

https://codereview.chromium.org/2496973002/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/downloads_watcher/arc_downloads_watcher_service.h:48:
void OnDownloadsChanged(std::vector<std::string> paths);
const std::vector<std::string>& probably?

The does not prevent accidental copy and seems error-prone. The migration doc
says "pass-by-value if the target type is move-only".

[commit-bot: I haz the power, 2016-11-11 17:40:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 17:40:56]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Luis Héctor Chávez, 2016-11-11 17:53:38]

https://codereview.chromium.org/2496973002/diff/1/chrome/browser/chromeos/arc...
File
chrome/browser/chromeos/arc/downloads_watcher/arc_downloads_watcher_service.h
(right):

https://codereview.chromium.org/2496973002/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/downloads_watcher/arc_downloads_watcher_service.h:48:
void OnDownloadsChanged(std::vector<std::string> paths);
On 2016/11/11 17:33:37, Yusuke Sato wrote:
> const std::vector<std::string>& probably?
> 
> The does not prevent accidental copy and seems error-prone. The migration doc
> says "pass-by-value if the target type is move-only".

Done.

[Luis Héctor Chávez, 2016-11-11 17:53:42]

The CQ bit was checked by lhchavez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-11 17:54:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 18:09:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 18:09:11]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Luis Héctor Chávez, 2016-11-11 19:15:48]

The CQ bit was checked by lhchavez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-11 19:16:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 20:18:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 20:18:26]

Dry run: This issue passed the CQ dry run.

[Yusuke Sato, 2016-11-11 22:12:08]

Thanks! LGTM with one nit.

https://codereview.chromium.org/2496973002/diff/20001/chrome/browser/chromeos...
File
chrome/browser/chromeos/arc/downloads_watcher/arc_downloads_watcher_service.cc
(right):

https://codereview.chromium.org/2496973002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/downloads_watcher/arc_downloads_watcher_service.cc:297:
std::vector<std::string> mojo_paths(changed_paths.size());
nit: s/mojo_// or s/mojo_/string_/ ?

[Luis Héctor Chávez, 2016-11-11 22:19:21]

https://codereview.chromium.org/2496973002/diff/20001/chrome/browser/chromeos...
File
chrome/browser/chromeos/arc/downloads_watcher/arc_downloads_watcher_service.cc
(right):

https://codereview.chromium.org/2496973002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/downloads_watcher/arc_downloads_watcher_service.cc:297:
std::vector<std::string> mojo_paths(changed_paths.size());
On 2016/11/11 22:12:08, Yusuke Sato wrote:
> nit: s/mojo_// or s/mojo_/string_/ ?

Chose the latter.

[Luis Héctor Chávez, 2016-11-11 22:19:26]

The CQ bit was checked by lhchavez@chromium.org

[Luis Héctor Chávez, 2016-11-11 22:19:27]

The patchset sent to the CQ was uploaded after l-g-t-m from yusukes@chromium.org
Link to the patchset: https://codereview.chromium.org/2496973002/#ps60001
(title: "Fixed nit")

[commit-bot: I haz the power, 2016-11-11 22:19:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-12 00:29:07]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-12 00:33:18]

Description was changed from

==========
arc: Partially migrate mojo types

This splits off the build target that compiles all .mojom files into
two, so that we can migrate them one by one instead of having a massive
migration change.

BUG=624136
TEST=trybots
==========

to

==========
arc: Partially migrate mojo types

This splits off the build target that compiles all .mojom files into
two, so that we can migrate them one by one instead of having a massive
migration change.

BUG=624136
TEST=trybots

Committed: https://crrev.com/5ec7c09e047b30460d3debb26743bd7103c9f327
Cr-Commit-Position: refs/heads/master@{#431703}
==========

[commit-bot: I haz the power, 2016-11-12 00:33:19]

Patchset 4 (id:??) landed as
https://crrev.com/5ec7c09e047b30460d3debb26743bd7103c9f327
Cr-Commit-Position: refs/heads/master@{#431703}