Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Side by Side Diff: components/arc/clipboard/arc_clipboard_bridge.cc

Issue 2496973002: arc: Partially migrate mojo types (Closed)
Patch Set: Fixed nit Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/arc/clipboard/arc_clipboard_bridge.h" 5 #include "components/arc/clipboard/arc_clipboard_bridge.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/strings/utf_string_conversions.h" 8 #include "base/strings/utf_string_conversions.h"
9 #include "base/threading/thread_checker.h" 9 #include "base/threading/thread_checker.h"
10 #include "components/arc/arc_bridge_service.h" 10 #include "components/arc/arc_bridge_service.h"
11 #include "ui/base/clipboard/clipboard.h" 11 #include "ui/base/clipboard/clipboard.h"
12 #include "ui/base/clipboard/clipboard_types.h" 12 #include "ui/base/clipboard/clipboard_types.h"
13 #include "ui/base/clipboard/scoped_clipboard_writer.h" 13 #include "ui/base/clipboard/scoped_clipboard_writer.h"
14 14
15 namespace {
16
17 static base::string16 ConvertMojoStringToString16(const mojo::String& input) {
18 return base::UTF8ToUTF16(input.get());
19 }
20
21 static mojo::String ConvertString16ToMojoString(const base::string16& input) {
22 return mojo::String(base::UTF16ToUTF8(input));
23 }
24
25 } // namespace
26
27 namespace arc { 15 namespace arc {
28 16
29 ArcClipboardBridge::ArcClipboardBridge(ArcBridgeService* bridge_service) 17 ArcClipboardBridge::ArcClipboardBridge(ArcBridgeService* bridge_service)
30 : ArcService(bridge_service), binding_(this) { 18 : ArcService(bridge_service), binding_(this) {
31 arc_bridge_service()->clipboard()->AddObserver(this); 19 arc_bridge_service()->clipboard()->AddObserver(this);
32 } 20 }
33 21
34 ArcClipboardBridge::~ArcClipboardBridge() { 22 ArcClipboardBridge::~ArcClipboardBridge() {
35 DCHECK(CalledOnValidThread()); 23 DCHECK(CalledOnValidThread());
36 arc_bridge_service()->clipboard()->RemoveObserver(this); 24 arc_bridge_service()->clipboard()->RemoveObserver(this);
37 } 25 }
38 26
39 void ArcClipboardBridge::OnInstanceReady() { 27 void ArcClipboardBridge::OnInstanceReady() {
40 mojom::ClipboardInstance* clipboard_instance = 28 mojom::ClipboardInstance* clipboard_instance =
41 arc_bridge_service()->clipboard()->GetInstanceForMethod("Init"); 29 arc_bridge_service()->clipboard()->GetInstanceForMethod("Init");
42 DCHECK(clipboard_instance); 30 DCHECK(clipboard_instance);
43 clipboard_instance->Init(binding_.CreateInterfacePtrAndBind()); 31 clipboard_instance->Init(binding_.CreateInterfacePtrAndBind());
44 } 32 }
45 33
46 void ArcClipboardBridge::SetTextContent(const mojo::String& text) { 34 void ArcClipboardBridge::SetTextContent(const std::string& text) {
47 DCHECK(CalledOnValidThread()); 35 DCHECK(CalledOnValidThread());
48 ui::ScopedClipboardWriter writer(ui::CLIPBOARD_TYPE_COPY_PASTE); 36 ui::ScopedClipboardWriter writer(ui::CLIPBOARD_TYPE_COPY_PASTE);
49 writer.WriteText(ConvertMojoStringToString16(text)); 37 writer.WriteText(base::UTF8ToUTF16(text));
50 } 38 }
51 39
52 void ArcClipboardBridge::GetTextContent() { 40 void ArcClipboardBridge::GetTextContent() {
53 DCHECK(CalledOnValidThread()); 41 DCHECK(CalledOnValidThread());
54 42
55 base::string16 text; 43 base::string16 text;
56 ui::Clipboard* clipboard = ui::Clipboard::GetForCurrentThread(); 44 ui::Clipboard* clipboard = ui::Clipboard::GetForCurrentThread();
57 clipboard->ReadText(ui::CLIPBOARD_TYPE_COPY_PASTE, &text); 45 clipboard->ReadText(ui::CLIPBOARD_TYPE_COPY_PASTE, &text);
58 46
59 mojom::ClipboardInstance* clipboard_instance = 47 mojom::ClipboardInstance* clipboard_instance =
60 arc_bridge_service()->clipboard()->GetInstanceForMethod( 48 arc_bridge_service()->clipboard()->GetInstanceForMethod(
61 "OnGetTextContent"); 49 "OnGetTextContent");
62 if (!clipboard_instance) 50 if (!clipboard_instance)
63 return; 51 return;
64 clipboard_instance->OnGetTextContent(ConvertString16ToMojoString(text)); 52 clipboard_instance->OnGetTextContent(base::UTF16ToUTF8(text));
65 } 53 }
66 54
67 bool ArcClipboardBridge::CalledOnValidThread() { 55 bool ArcClipboardBridge::CalledOnValidThread() {
68 // Make sure access to the Chrome clipboard is happening in the UI thread. 56 // Make sure access to the Chrome clipboard is happening in the UI thread.
69 return thread_checker_.CalledOnValidThread(); 57 return thread_checker_.CalledOnValidThread();
70 } 58 }
71 59
72 } // namespace arc 60 } // namespace arc
OLDNEW
« no previous file with comments | « components/arc/clipboard/arc_clipboard_bridge.h ('k') | components/arc/crash_collector/arc_crash_collector_bridge.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698