Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1010)

Unified Diff: components/arc/crash_collector/arc_crash_collector_bridge.cc

Issue 2496973002: arc: Partially migrate mojo types (Closed)
Patch Set: Fixed nit Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/arc/crash_collector/arc_crash_collector_bridge.h ('k') | ui/arc/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/arc/crash_collector/arc_crash_collector_bridge.cc
diff --git a/components/arc/crash_collector/arc_crash_collector_bridge.cc b/components/arc/crash_collector/arc_crash_collector_bridge.cc
index 78317c4268db6c66f29a9ad6e8f56225d84458a2..34e81752721b4ba0adee8607160c464b784e4b69 100644
--- a/components/arc/crash_collector/arc_crash_collector_bridge.cc
+++ b/components/arc/crash_collector/arc_crash_collector_bridge.cc
@@ -70,7 +70,7 @@ void ArcCrashCollectorBridge::OnInstanceReady() {
instance->Init(std::move(host_ptr));
}
-void ArcCrashCollectorBridge::DumpCrash(const mojo::String& type,
+void ArcCrashCollectorBridge::DumpCrash(const std::string& type,
mojo::ScopedHandle pipe) {
mojo::edk::ScopedPlatformHandle pipe_handle;
mojo::edk::PassWrappedPlatformHandle(pipe.release().value(), &pipe_handle);
@@ -80,12 +80,12 @@ void ArcCrashCollectorBridge::DumpCrash(const mojo::String& type,
base::Passed(std::move(pipe_handle))));
}
-void ArcCrashCollectorBridge::SetBuildProperties(const mojo::String& device,
- const mojo::String& board,
- const mojo::String& cpu_abi) {
- device_ = device.get();
- board_ = board.get();
- cpu_abi_ = cpu_abi.get();
+void ArcCrashCollectorBridge::SetBuildProperties(const std::string& device,
+ const std::string& board,
+ const std::string& cpu_abi) {
+ device_ = device;
+ board_ = board;
+ cpu_abi_ = cpu_abi;
}
} // namespace arc
« no previous file with comments | « components/arc/crash_collector/arc_crash_collector_bridge.h ('k') | ui/arc/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698