content/browser/permissions/permission_service_impl.h - Issue 2496653002: Part 2 of base::IDMap refactor to eliminate IDMapOwnPointer/IDMapExternalPointer modes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/permissions/permission_service_impl.h

Issue 2496653002: Part 2 of base::IDMap refactor to eliminate IDMapOwnPointer/IDMapExternalPointer modes (Closed)

Patch Set: typedefs => using statements, update comments in base/id_map.h Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/permissions/permission_service_impl.h

diff --git a/content/browser/permissions/permission_service_impl.h b/content/browser/permissions/permission_service_impl.h

index 9321ff4e2e8abc1f0ce10e30cab81b537353922f..6cc28720bbecf995aad6e80aae0109d34605d8b1 100644

--- a/content/browser/permissions/permission_service_impl.h

+++ b/content/browser/permissions/permission_service_impl.h

@@ -55,7 +55,7 @@ class PermissionServiceImpl : public blink::mojom::PermissionService {

RequestPermissionsCallback callback;

int request_count;

};

- using RequestsMap = IDMap<PendingRequest, IDMapOwnPointer>;

+ using RequestsMap = IDMap<std::unique_ptr<PendingRequest>>;

struct PendingSubscription {

PendingSubscription(PermissionType permission,

@@ -69,7 +69,7 @@ class PermissionServiceImpl : public blink::mojom::PermissionService {

url::Origin origin;

PermissionStatusCallback callback;

};

- using SubscriptionsMap = IDMap<PendingSubscription, IDMapOwnPointer>;

+ using SubscriptionsMap = IDMap<std::unique_ptr<PendingSubscription>>;

// blink::mojom::PermissionService.

void HasPermission(blink::mojom::PermissionDescriptorPtr permission,