content/browser/manifest/manifest_manager_host.h - Issue 2496653002: Part 2 of base::IDMap refactor to eliminate IDMapOwnPointer/IDMapExternalPointer modes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/manifest/manifest_manager_host.h

Issue 2496653002: Part 2 of base::IDMap refactor to eliminate IDMapOwnPointer/IDMapExternalPointer modes (Closed)

Patch Set: typedefs => using statements, update comments in base/id_map.h Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/manifest/manifest_manager_host.h

diff --git a/content/browser/manifest/manifest_manager_host.h b/content/browser/manifest/manifest_manager_host.h

index 8edc88be24b1f009d160b4ff06d98bdfb030f51b..b27031b2b1872ad3e60e10c654feee1a18fb8c51 100644

--- a/content/browser/manifest/manifest_manager_host.h

+++ b/content/browser/manifest/manifest_manager_host.h

@@ -39,7 +39,7 @@ class ManifestManagerHost : public WebContentsObserver {

void RenderFrameDeleted(RenderFrameHost*) override;

private:

- using GetCallbackMap = IDMap<GetManifestCallback, IDMapOwnPointer>;

+ using GetCallbackMap = IDMap<std::unique_ptr<GetManifestCallback>>;

void OnRequestManifestResponse(

RenderFrameHost*, int request_id, const GURL&, const Manifest&);