Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Side by Side Diff: content/browser/permissions/permission_service_impl.h

Issue 2496653002: Part 2 of base::IDMap refactor to eliminate IDMapOwnPointer/IDMapExternalPointer modes (Closed)
Patch Set: typedefs => using statements, update comments in base/id_map.h Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_PERMISSIONS_PERMISSION_SERVICE_IMPL_H_ 5 #ifndef CONTENT_BROWSER_PERMISSIONS_PERMISSION_SERVICE_IMPL_H_
6 #define CONTENT_BROWSER_PERMISSIONS_PERMISSION_SERVICE_IMPL_H_ 6 #define CONTENT_BROWSER_PERMISSIONS_PERMISSION_SERVICE_IMPL_H_
7 7
8 #include "base/callback.h" 8 #include "base/callback.h"
9 #include "base/id_map.h" 9 #include "base/id_map.h"
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 struct PendingRequest { 48 struct PendingRequest {
49 PendingRequest(const RequestPermissionsCallback& callback, 49 PendingRequest(const RequestPermissionsCallback& callback,
50 int request_count); 50 int request_count);
51 ~PendingRequest(); 51 ~PendingRequest();
52 52
53 // Request ID received from the PermissionManager. 53 // Request ID received from the PermissionManager.
54 int id; 54 int id;
55 RequestPermissionsCallback callback; 55 RequestPermissionsCallback callback;
56 int request_count; 56 int request_count;
57 }; 57 };
58 using RequestsMap = IDMap<PendingRequest, IDMapOwnPointer>; 58 using RequestsMap = IDMap<std::unique_ptr<PendingRequest>>;
59 59
60 struct PendingSubscription { 60 struct PendingSubscription {
61 PendingSubscription(PermissionType permission, 61 PendingSubscription(PermissionType permission,
62 const url::Origin& origin, 62 const url::Origin& origin,
63 const PermissionStatusCallback& callback); 63 const PermissionStatusCallback& callback);
64 ~PendingSubscription(); 64 ~PendingSubscription();
65 65
66 // Subscription ID received from the PermissionManager. 66 // Subscription ID received from the PermissionManager.
67 int id; 67 int id;
68 PermissionType permission; 68 PermissionType permission;
69 url::Origin origin; 69 url::Origin origin;
70 PermissionStatusCallback callback; 70 PermissionStatusCallback callback;
71 }; 71 };
72 using SubscriptionsMap = IDMap<PendingSubscription, IDMapOwnPointer>; 72 using SubscriptionsMap = IDMap<std::unique_ptr<PendingSubscription>>;
73 73
74 // blink::mojom::PermissionService. 74 // blink::mojom::PermissionService.
75 void HasPermission(blink::mojom::PermissionDescriptorPtr permission, 75 void HasPermission(blink::mojom::PermissionDescriptorPtr permission,
76 const url::Origin& origin, 76 const url::Origin& origin,
77 const PermissionStatusCallback& callback) override; 77 const PermissionStatusCallback& callback) override;
78 void RequestPermission(blink::mojom::PermissionDescriptorPtr permission, 78 void RequestPermission(blink::mojom::PermissionDescriptorPtr permission,
79 const url::Origin& origin, 79 const url::Origin& origin,
80 bool user_gesture, 80 bool user_gesture,
81 const PermissionStatusCallback& callback) override; 81 const PermissionStatusCallback& callback) override;
82 void RequestPermissions( 82 void RequestPermissions(
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
118 PermissionServiceContext* context_; 118 PermissionServiceContext* context_;
119 mojo::Binding<blink::mojom::PermissionService> binding_; 119 mojo::Binding<blink::mojom::PermissionService> binding_;
120 base::WeakPtrFactory<PermissionServiceImpl> weak_factory_; 120 base::WeakPtrFactory<PermissionServiceImpl> weak_factory_;
121 121
122 DISALLOW_COPY_AND_ASSIGN(PermissionServiceImpl); 122 DISALLOW_COPY_AND_ASSIGN(PermissionServiceImpl);
123 }; 123 };
124 124
125 } // namespace content 125 } // namespace content
126 126
127 #endif // CONTENT_BROWSER_PERMISSIONS_PERMISSION_SERVICE_IMPL_H_ 127 #endif // CONTENT_BROWSER_PERMISSIONS_PERMISSION_SERVICE_IMPL_H_
OLDNEW
« no previous file with comments | « content/browser/manifest/manifest_manager_host.h ('k') | content/browser/quota_dispatcher_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698