Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2496333002: [ic] Extract load IC proto array handlers handling to a separate stub. (Closed)

Created:
4 years, 1 month ago by Igor Sheludko
Modified:
4 years, 1 month ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ic] Extract load IC proto array handlers handling to a separate stub. This is to fix the performance regression by avoiding creation of a frame in LoadIC dispatcher caused by complicated logic of CSA::EmitLoadICProtoArrayCheck(). BUG=v8:5561, chromium:660795 Committed: https://crrev.com/815eca573a064e8170cfffa9a03fea7b5a90cc63 Cr-Commit-Position: refs/heads/master@{#40986}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -13 lines) Patch
M src/arm/interface-descriptors-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/code-stub-assembler.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/code-stub-assembler.cc View 1 chunk +32 lines, -6 lines 0 comments Download
M src/code-stubs.h View 2 chunks +11 lines, -0 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/interface-descriptors.h View 2 chunks +10 lines, -0 lines 0 comments Download
M src/interface-descriptors.cc View 2 chunks +18 lines, -1 line 0 comments Download
M src/mips/interface-descriptors-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/interface-descriptors-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/s390/interface-descriptors-s390.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/x64/interface-descriptors-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/interface-descriptors-x87.cc View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (11 generated)
Igor Sheludko
PTAL
4 years, 1 month ago (2016-11-14 18:13:59 UTC) #7
Jakob Kummerow
lgtm
4 years, 1 month ago (2016-11-15 11:13:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2496333002/20001
4 years, 1 month ago (2016-11-15 11:13:49 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 1 month ago (2016-11-15 11:15:52 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:33:45 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/815eca573a064e8170cfffa9a03fea7b5a90cc63
Cr-Commit-Position: refs/heads/master@{#40986}

Powered by Google App Engine
This is Rietveld 408576698