[ic] Refactor LoadIC code.

[ic] Refactor LoadIC code.

Extract CSA::HandleLoadICSmiHandlerCase() from CSA::HandleLoadICHandlerCase() and
CSA::EmitLoadICProtoArrayCheck() from CSA::HandleLoadICProtoHandler().

This is a preliminary step for extracting LoadICProtoArrayCheck to a separate stub
which is necesary to fix the preformance regression caused by proto array
handlers support.

BUG=v8:5561, chromium:660795
Committed: https://crrev.com/4a0e07a0cc1284ecde91381d40981f4791266d79
Cr-Commit-Position: refs/heads/master@{#40983}

[Igor Sheludko, 2016-11-14 18:07:25]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 18:07:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Igor Sheludko, 2016-11-14 18:08:35]

Description was changed from

==========
[ic] Refactor LoadIC code.

Extract CSA::HandleLoadICSmiHandlerCase() from CSA::HandleLoadICHandlerCase()
and
CSA::EmitLoadICProtoArrayCheck() from CSA::HandleLoadICProtoHandler().

This is a preliminary step for extracting LoadICProtoArrayCheck to a separate
stub
which is necesary to fix the preformance regression introduced by proto array
handlers support.

BUG=v8:5561, chromium:660795
==========

to

==========
[ic] Refactor LoadIC code.

Extract CSA::HandleLoadICSmiHandlerCase() from CSA::HandleLoadICHandlerCase()
and
CSA::EmitLoadICProtoArrayCheck() from CSA::HandleLoadICProtoHandler().

This is a preliminary step for extracting LoadICProtoArrayCheck to a separate
stub
which is necesary to fix the preformance regression caused by proto array
handlers support.

BUG=v8:5561, chromium:660795
==========

[Igor Sheludko, 2016-11-14 18:08:54]

ishell@chromium.org changed reviewers:
+ jkummerow@chromium.org

[Igor Sheludko, 2016-11-14 18:08:55]

PTAL

https://codereview.chromium.org/2498013002/diff/1/src/code-stub-assembler.cc
File src/code-stub-assembler.cc (left):

https://codereview.chromium.org/2498013002/diff/1/src/code-stub-assembler.cc#...
src/code-stub-assembler.cc:5512: Variable var_double_value(this,
MachineRepresentation::kFloat64);
This whole piece of code was moved to HandleLoadICSmiHandlerCase() unchanged.

https://codereview.chromium.org/2498013002/diff/1/src/code-stub-assembler.cc#...
src/code-stub-assembler.cc:5617: #if defined(DEBUG)
I only removed this #ifdef.

https://codereview.chromium.org/2498013002/diff/1/src/code-stub-assembler.cc#...
src/code-stub-assembler.cc:5722: Variable start_index(this,
MachineType::PointerRepresentation());
This code block now returns a holder.

[commit-bot: I haz the power, 2016-11-14 18:33:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 18:33:43]

Dry run: This issue passed the CQ dry run.

[Jakob Kummerow, 2016-11-15 10:03:43]

lgtm

[Igor Sheludko, 2016-11-15 10:07:45]

The CQ bit was checked by ishell@chromium.org

[commit-bot: I haz the power, 2016-11-15 10:07:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 10:09:49]

Description was changed from

==========
[ic] Refactor LoadIC code.

Extract CSA::HandleLoadICSmiHandlerCase() from CSA::HandleLoadICHandlerCase()
and
CSA::EmitLoadICProtoArrayCheck() from CSA::HandleLoadICProtoHandler().

This is a preliminary step for extracting LoadICProtoArrayCheck to a separate
stub
which is necesary to fix the preformance regression caused by proto array
handlers support.

BUG=v8:5561, chromium:660795
==========

to

==========
[ic] Refactor LoadIC code.

Extract CSA::HandleLoadICSmiHandlerCase() from CSA::HandleLoadICHandlerCase()
and
CSA::EmitLoadICProtoArrayCheck() from CSA::HandleLoadICProtoHandler().

This is a preliminary step for extracting LoadICProtoArrayCheck to a separate
stub
which is necesary to fix the preformance regression caused by proto array
handlers support.

BUG=v8:5561, chromium:660795
==========

[commit-bot: I haz the power, 2016-11-15 10:09:50]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-17 22:33:34]

Description was changed from

==========
[ic] Refactor LoadIC code.

Extract CSA::HandleLoadICSmiHandlerCase() from CSA::HandleLoadICHandlerCase()
and
CSA::EmitLoadICProtoArrayCheck() from CSA::HandleLoadICProtoHandler().

This is a preliminary step for extracting LoadICProtoArrayCheck to a separate
stub
which is necesary to fix the preformance regression caused by proto array
handlers support.

BUG=v8:5561, chromium:660795
==========

to

==========
[ic] Refactor LoadIC code.

Extract CSA::HandleLoadICSmiHandlerCase() from CSA::HandleLoadICHandlerCase()
and
CSA::EmitLoadICProtoArrayCheck() from CSA::HandleLoadICProtoHandler().

This is a preliminary step for extracting LoadICProtoArrayCheck to a separate
stub
which is necesary to fix the preformance regression caused by proto array
handlers support.

BUG=v8:5561, chromium:660795

Committed: https://crrev.com/4a0e07a0cc1284ecde91381d40981f4791266d79
Cr-Commit-Position: refs/heads/master@{#40983}
==========

[commit-bot: I haz the power, 2016-11-17 22:33:36]

Patchset 1 (id:??) landed as
https://crrev.com/4a0e07a0cc1284ecde91381d40981f4791266d79
Cr-Commit-Position: refs/heads/master@{#40983}