Reland:Adds eventlog provider dll to describe the message types of SYSLOG.

Reland:Adds eventlog provider dll to describe the message types of SYSLOG.

Creates a dll file that can be registered with the system event-logging
mechanisms on Windows to make the events generated when using the SYSLOG
macro nicer to read in the Event Viewer snapin.

BUG=642115
TEST=manual

Committed: https://crrev.com/35a1fb75849c0b9d24b8d699ebbae2e37b2235f7
Cr-Commit-Position: refs/heads/master@{#432854}

[pastarmovj, 2016-11-15 14:10:53]

pastarmovj@chromium.org changed reviewers:
+ brettw@chromium.org

[pastarmovj, 2016-11-15 14:10:54]

Hey Brett,
thanks for the comment on the original CL that got reverted yesterday. I
couldn't find another way to ensure the generation of a lib file but to add some
code to the file. This increases the size of the release file relatively by a
few hundred bytes and the compressed size by ~100bytes which seems acceptable. 

I was lookinginto ways to change the way the shared_library target type works to
make it have a flag to skip lib file generation if requested so. I guess it is
tehnically possible to achieve but I am not sure it is the right thing
considering the philosophy of GN I found here
https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/languag....
It claims "The build language should be opinionated as to how the build should
work. It should not necessarily be easy or even possible to express arbitrary
things. We should be changing source and tooling to make the build simpler
rather than making everything more complicated to conform to external
requirements (within reason)." I think you are the right person to say if this a
case for a change or rather given the low impact of the workaround not?

Thanks,
Julian

[brettw, 2016-11-16 22:19:51]

LGTM

https://codereview.chromium.org/2496323003/diff/20001/base/win/eventlog_provi...
File base/win/eventlog_provider.cc (right):

https://codereview.chromium.org/2496323003/diff/20001/base/win/eventlog_provi...
base/win/eventlog_provider.cc:5: // Force the generation of a lib file for the
dll to make the hermetic builds
I don't know if the problem is particularly "hermetic". Maybe say "...since
Ninja expects shared libraries to generate a .dll and a .lib file."

[pastarmovj, 2016-11-17 08:44:39]

The CQ bit was checked by pastarmovj@chromium.org

[pastarmovj, 2016-11-17 08:44:39]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/2496323003/#ps60001
(title: "Rebased on ToT.")

[pastarmovj, 2016-11-17 08:44:49]

https://codereview.chromium.org/2496323003/diff/20001/base/win/eventlog_provi...
File base/win/eventlog_provider.cc (right):

https://codereview.chromium.org/2496323003/diff/20001/base/win/eventlog_provi...
base/win/eventlog_provider.cc:5: // Force the generation of a lib file for the
dll to make the hermetic builds
On 2016/11/16 22:19:51, brettw (ping on IM after 24h) wrote:
> I don't know if the problem is particularly "hermetic". Maybe say "...since
> Ninja expects shared libraries to generate a .dll and a .lib file."

Done.

[commit-bot: I haz the power, 2016-11-17 08:44:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 12:47:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 12:47:56]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pastarmovj, 2016-11-17 12:50:12]

The CQ bit was checked by pastarmovj@chromium.org

[commit-bot: I haz the power, 2016-11-17 12:50:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 13:19:12]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-17 13:20:43]

Description was changed from

==========
Reland:Adds eventlog provider dll to describe the message types of SYSLOG.

Creates a dll file that can be registered with the system event-logging
mechanisms on Windows to make the events generated when using the SYSLOG
macro nicer to read in the Event Viewer snapin.

BUG=642115
TEST=manual
==========

to

==========
Reland:Adds eventlog provider dll to describe the message types of SYSLOG.

Creates a dll file that can be registered with the system event-logging
mechanisms on Windows to make the events generated when using the SYSLOG
macro nicer to read in the Event Viewer snapin.

BUG=642115
TEST=manual

Committed: https://crrev.com/35a1fb75849c0b9d24b8d699ebbae2e37b2235f7
Cr-Commit-Position: refs/heads/master@{#432854}
==========

[commit-bot: I haz the power, 2016-11-17 13:20:45]

Patchset 4 (id:??) landed as
https://crrev.com/35a1fb75849c0b9d24b8d699ebbae2e37b2235f7
Cr-Commit-Position: refs/heads/master@{#432854}