base/win/eventlog_provider.cc - Issue 2496323003: Reland:Adds eventlog provider dll to describe the message types of SYSLOG.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/win/eventlog_provider.cc

Issue 2496323003: Reland:Adds eventlog provider dll to describe the message types of SYSLOG. (Closed)

Patch Set: Adds a dummy export function to force the lib file generation. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // Force the generation of a lib file for the dll to make the hermetic builds
	brettw 2016/11/16 22:19:51 I don't know if the problem is particularly "herme I don't know if the problem is particularly "hermetic". Maybe say "...since Ninja expects shared libraries to generate a .dll and a .lib file." pastarmovj 2016/11/17 08:44:49 Done. Show quoted text On 2016/11/16 22:19:51, brettw (ping on IM after 24h) wrote: > I don't know if the problem is particularly "hermetic". Maybe say "...since > Ninja expects shared libraries to generate a .dll and a .lib file." Done.
	6 // happy.

	7 __declspec(dllexport) bool fn() {

	8 return true;

	9 }

OLD	NEW

« no previous file with comments | « base/win/eventlog_messages.mc ('k') | no next file » | no next file with comments »