Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2855)

Unified Diff: base/syslog_logging.cc

Issue 2496323003: Reland:Adds eventlog provider dll to describe the message types of SYSLOG. (Closed)
Patch Set: Rebased on ToT. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/BUILD.gn ('k') | base/win/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/syslog_logging.cc
diff --git a/base/syslog_logging.cc b/base/syslog_logging.cc
index 488f184598758444fda2a3b0281986f2245d8fb1..1cd545910a967a6f52f5a138136bceb8be6782fd 100644
--- a/base/syslog_logging.cc
+++ b/base/syslog_logging.cc
@@ -6,6 +6,8 @@
#include "base/syslog_logging.h"
#if defined(OS_WIN)
+#include "base/win/eventlog_messages.h"
+
#include <windows.h>
#elif defined(OS_LINUX)
#include <syslog.h>
@@ -51,10 +53,8 @@ EventLogMessage::~EventLogMessage() {
break;
}
LPCSTR strings[1] = {message.data()};
- // TODO(pastarmovj): Register Chrome's event log resource types to make the
- // entries nicer. 1337 is just a made up event id type.
- if (!ReportEventA(event_log_handle, log_type, 0, 1337, NULL, 1, 0,
- strings, NULL)) {
+ if (!ReportEventA(event_log_handle, log_type, BROWSER_CATEGORY,
+ MSG_LOG_MESSAGE, NULL, 1, 0, strings, NULL)) {
stream() << " !!NOT ADDED TO EVENTLOG!!";
}
DeregisterEventSource(event_log_handle);
« no previous file with comments | « base/BUILD.gn ('k') | base/win/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698