Add tool to visualize machine code/lithium.

Add tool to visualize machine code/lithium.

In the process:
- Add a command-line flag --opt-code-positions to track source position information throughout optimized code.
- Add a subclass of the hydrogen graph builder to ensure that the source position is properly set on the graph builder for all generated hydrogen code.
- Overhaul handling of source positions in hydrogen to ensure they are passed through to generated code consistently and in most cases transparently.

[danno, 2013-10-16 10:02:01]

PTAL. Dmitry, could you please check out the .js/.html code again? Michael,
could you please review the rest of the actual runtime changes?

[Michael Starzinger, 2013-10-18 13:04:21]

LGTM, only a few nits. I only reviewed the Crankshaft changes, didn't look at
the Sodium tool.

https://codereview.chromium.org/24957003/diff/32001/src/codegen.cc
File src/codegen.cc (right):

https://codereview.chromium.org/24957003/diff/32001/src/codegen.cc#newcode138
src/codegen.cc:138: code->kind() == Code::FUNCTION;
nit: Indentation is off.

https://codereview.chromium.org/24957003/diff/32001/src/flag-definitions.h
File src/flag-definitions.h (right):

https://codereview.chromium.org/24957003/diff/32001/src/flag-definitions.h#ne...
src/flag-definitions.h:827: DEFINE_bool(opt_code_positions, false, "annotate
optimize code with source code positions")
nit: s/opt_code_positions/print_opt_code_positions/

https://codereview.chromium.org/24957003/diff/32001/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):

https://codereview.chromium.org/24957003/diff/32001/src/hydrogen-instructions...
src/hydrogen-instructions.cc:748: ASSERT(next->position() ==
RelocInfo::kNoPosition);
nit: This if cascade looks awfully complex, especially because this ASSERT will
always hold. Can we merge that into just one if-statement?

https://codereview.chromium.org/24957003/diff/32001/src/hydrogen-instructions...
src/hydrogen-instructions.cc:789: ASSERT(previous->position() ==
RelocInfo::kNoPosition);
nit: Likewise.

https://codereview.chromium.org/24957003/diff/32001/src/hydrogen-instructions...
src/hydrogen-instructions.cc:789: ASSERT(previous->position() ==
RelocInfo::kNoPosition);
nit: Likewise.

https://codereview.chromium.org/24957003/diff/32001/src/hydrogen.h
File src/hydrogen.h (right):

https://codereview.chromium.org/24957003/diff/32001/src/hydrogen.h#newcode195
src/hydrogen.h:195: // Add the inlined function exit sequence, adding an
HLeaveInlined
nit: Can we add an empty new-line before the comment, makes it easier to read.

[Dmitry Lomov (no reviews), 2013-10-18 16:07:53]

LGTM

Some style comments

https://codereview.chromium.org/24957003/diff/32001/tools/sodium/index.html
File tools/sodium/index.html (right):

https://codereview.chromium.org/24957003/diff/32001/tools/sodium/index.html#n...
tools/sodium/index.html:8: <script
src="https://google-code-prettify.googlecode.com/svn/loader/run_prettify.js"></script>
Are you sure you want to load it from there? It is an svn server hit.

https://codereview.chromium.org/24957003/diff/32001/tools/sodium/sodium.js
File tools/sodium/sodium.js (right):

https://codereview.chromium.org/24957003/diff/32001/tools/sodium/sodium.js#ne...
tools/sodium/sodium.js:366: asmDivElement.innerHTML = '<div id=\"asm-text\">' +
newHtml + '</div>';
Use createElement here

https://codereview.chromium.org/24957003/diff/32001/tools/sodium/sodium.js#ne...
tools/sodium/sodium.js:394:
document.getElementById('log-file-id').addEventListener('change',
Consider replacing getElementById with parameters to Sodium, populated from the
caller

[danno, 2013-10-19 17:11:40]

I can't upload new patch sets of this CL, moving to:
https://codereview.chromium.org/29123008

https://codereview.chromium.org/24957003/diff/32001/src/codegen.cc
File src/codegen.cc (right):

https://codereview.chromium.org/24957003/diff/32001/src/codegen.cc#newcode138
src/codegen.cc:138: code->kind() == Code::FUNCTION;
On 2013/10/18 13:04:21, Michael Starzinger wrote:
> nit: Indentation is off.

Done.

https://codereview.chromium.org/24957003/diff/32001/src/flag-definitions.h
File src/flag-definitions.h (right):

https://codereview.chromium.org/24957003/diff/32001/src/flag-definitions.h#ne...
src/flag-definitions.h:827: DEFINE_bool(opt_code_positions, false, "annotate
optimize code with source code positions")
On 2013/10/18 13:04:21, Michael Starzinger wrote:
> nit: s/opt_code_positions/print_opt_code_positions/

Done.

https://codereview.chromium.org/24957003/diff/32001/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):

https://codereview.chromium.org/24957003/diff/32001/src/hydrogen-instructions...
src/hydrogen-instructions.cc:748: ASSERT(next->position() ==
RelocInfo::kNoPosition);
On 2013/10/18 13:04:21, Michael Starzinger wrote:
> nit: This if cascade looks awfully complex, especially because this ASSERT
will
> always hold. Can we merge that into just one if-statement?

Done.

https://codereview.chromium.org/24957003/diff/32001/src/hydrogen-instructions...
src/hydrogen-instructions.cc:789: ASSERT(previous->position() ==
RelocInfo::kNoPosition);
On 2013/10/18 13:04:21, Michael Starzinger wrote:
> nit: Likewise.

Done.

https://codereview.chromium.org/24957003/diff/32001/src/hydrogen-instructions...
src/hydrogen-instructions.cc:789: ASSERT(previous->position() ==
RelocInfo::kNoPosition);
On 2013/10/18 13:04:21, Michael Starzinger wrote:
> nit: Likewise.

Done.

https://codereview.chromium.org/24957003/diff/32001/src/hydrogen.h
File src/hydrogen.h (right):

https://codereview.chromium.org/24957003/diff/32001/src/hydrogen.h#newcode195
src/hydrogen.h:195: // Add the inlined function exit sequence, adding an
HLeaveInlined
On 2013/10/18 13:04:21, Michael Starzinger wrote:
> nit: Can we add an empty new-line before the comment, makes it easier to read.

Done.

https://codereview.chromium.org/24957003/diff/32001/tools/sodium/index.html
File tools/sodium/index.html (right):

https://codereview.chromium.org/24957003/diff/32001/tools/sodium/index.html#n...
tools/sodium/index.html:8: <script
src="https://google-code-prettify.googlecode.com/svn/loader/run_prettify.js"></script>
On 2013/10/18 16:07:53, Dmitry Lomov (chromium) wrote:
> Are you sure you want to load it from there? It is an svn server hit.

Yeah, for now. It's ugly, but that what is recommended in the documentation and
because of some licensing issues I don't want to include a local copy yet.

https://codereview.chromium.org/24957003/diff/32001/tools/sodium/sodium.js
File tools/sodium/sodium.js (right):

https://codereview.chromium.org/24957003/diff/32001/tools/sodium/sodium.js#ne...
tools/sodium/sodium.js:366: asmDivElement.innerHTML = '<div id=\"asm-text\">' +
newHtml + '</div>';
On 2013/10/18 16:07:53, Dmitry Lomov (chromium) wrote:
> Use createElement here

Done.

https://codereview.chromium.org/24957003/diff/32001/tools/sodium/sodium.js#ne...
tools/sodium/sodium.js:394:
document.getElementById('log-file-id').addEventListener('change',
On 2013/10/18 16:07:53, Dmitry Lomov (chromium) wrote:
> Consider replacing getElementById with parameters to Sodium, populated from
the
> caller

Done.