Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 29123008: Add tool to visualize machine code/lithium. (Closed)

Created:
7 years, 2 months ago by danno
Modified:
7 years, 2 months ago
Reviewers:
CC:
v8-dev
Visibility:
Public.

Description

Add tool to visualize machine code/lithium. In the process: - Add a command-line flag --opt-code-positions to track source position information throughout optimized code. - Add a subclass of the hydrogen graph builder to ensure that the source position is properly set on the graph builder for all generated hydrogen code. - Overhaul handling of source positions in hydrogen to ensure they are passed through to generated code consistently and in most cases transparently. Originally reviewed in this CL: https://codereview.chromium.org/24957003/ Committed: http://code.google.com/p/v8/source/detail?r=17295

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+885 lines, -372 lines) Patch
src/arm/lithium-arm.h View 3 chunks +0 lines, -11 lines 0 comments Download
src/arm/lithium-arm.cc View 2 chunks +1 line, -2 lines 0 comments Download
src/arm/lithium-codegen-arm.h View 3 chunks +3 lines, -6 lines 0 comments Download
src/arm/lithium-codegen-arm.cc View 8 chunks +6 lines, -20 lines 0 comments Download
src/code-stubs-hydrogen.cc View 3 chunks +3 lines, -4 lines 0 comments Download
src/codegen.cc View 2 chunks +7 lines, -1 line 0 comments Download
src/compiler.cc View 2 chunks +40 lines, -1 line 0 comments Download
src/flag-definitions.h View 1 chunk +11 lines, -0 lines 0 comments Download
src/hydrogen.h View 23 chunks +75 lines, -50 lines 0 comments Download
src/hydrogen.cc View 122 chunks +169 lines, -182 lines 0 comments Download
src/hydrogen-instructions.h View 3 chunks +5 lines, -1 line 0 comments Download
src/hydrogen-instructions.cc View 3 chunks +13 lines, -0 lines 0 comments Download
src/hydrogen-osr.cc View 2 chunks +3 lines, -3 lines 0 comments Download
src/hydrogen-representation-changes.cc View 1 chunk +5 lines, -0 lines 0 comments Download
src/ia32/lithium-codegen-ia32.h View 3 chunks +2 lines, -6 lines 0 comments Download
src/ia32/lithium-codegen-ia32.cc View 9 chunks +7 lines, -21 lines 0 comments Download
src/ia32/lithium-ia32.h View 5 chunks +0 lines, -13 lines 0 comments Download
src/ia32/lithium-ia32.cc View 3 chunks +1 line, -3 lines 0 comments Download
src/lithium.h View 3 chunks +1 line, -4 lines 0 comments Download
src/lithium.cc View 1 chunk +1 line, -1 line 0 comments Download
src/lithium-codegen.h View 1 chunk +1 line, -1 line 0 comments Download
src/lithium-codegen.cc View 1 chunk +7 lines, -1 line 0 comments Download
src/x64/lithium-codegen-x64.h View 3 chunks +2 lines, -6 lines 0 comments Download
src/x64/lithium-codegen-x64.cc View 8 chunks +6 lines, -19 lines 0 comments Download
src/x64/lithium-x64.h View 5 chunks +0 lines, -13 lines 0 comments Download
src/x64/lithium-x64.cc View 3 chunks +1 line, -3 lines 0 comments Download
tools/sodium/index.html View 1 chunk +36 lines, -0 lines 0 comments Download
tools/sodium/sodium.js View 1 chunk +409 lines, -0 lines 0 comments Download
tools/sodium/styles.css View 1 chunk +70 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
danno
7 years, 2 months ago (2013-10-21 13:36:08 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 manually as r17295.

Powered by Google App Engine
This is Rietveld 408576698