Add tool to visualize machine code/lithium.

src/hydrogen-instructions.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 723 matching lines @@
   ASSERT(!next->IsBlockEntry());
   ASSERT(!IsControlInstruction());
   ASSERT(!next->block()->IsStartBlock());
   ASSERT(next->previous_ != NULL);
   HInstruction* prev = next->previous();
   prev->next_ = this;
   next->previous_ = this;
   next_ = next;
   previous_ = prev;
   SetBlock(next->block());
+  if (position() == RelocInfo::kNoPosition) {
+    if (next->position() != RelocInfo::kNoPosition) {
+      set_position(next->position());
+    } else {
+      ASSERT(next->position() == RelocInfo::kNoPosition);

[Michael Starzinger, 2013/10/18 13:04:21]

nit: This if cascade looks awfully complex, especially because this ASSERT will
always hold. Can we merge that into just one if-statement?

[danno, 2013/10/19 17:11:40]

Done.

+    }
+  }
 }
 
 
 void HInstruction::InsertAfter(HInstruction* previous) {
   ASSERT(!IsLinked());
   ASSERT(!previous->IsControlInstruction());
   ASSERT(!IsControlInstruction() || previous->next_ == NULL);
   HBasicBlock* block = previous->block();
   // Never insert anything except constants into the start block after finishing
   // it.
@@ skipping 14 matching lines @@
   }
 
   previous_ = previous;
   next_ = next;
   SetBlock(block);
   previous->next_ = this;
   if (next != NULL) next->previous_ = this;
   if (block->last() == previous) {
     block->set_last(this);
   }
+  if (position() == RelocInfo::kNoPosition) {
+    if (previous->position() != RelocInfo::kNoPosition) {
+      set_position(previous->position());
+    } else {
+      ASSERT(previous->position() == RelocInfo::kNoPosition);

[Michael Starzinger, 2013/10/18 13:04:21]

nit: Likewise.

[Michael Starzinger, 2013/10/18 13:04:21]

nit: Likewise.

[danno, 2013/10/19 17:11:40]

Done.

[danno, 2013/10/19 17:11:40]

Done.

+    }
+  }
 }
 
 
 #ifdef DEBUG
 void HInstruction::Verify() {
   // Verify that input operands are defined before use.
   HBasicBlock* cur_block = block();
   for (int i = 0; i < OperandCount(); ++i) {
     HValue* other_operand = OperandAt(i);
     if (other_operand == NULL) continue;
@@ skipping 797 matching lines @@
 Range* HConstant::InferRange(Zone* zone) {
   if (has_int32_value_) {
     Range* result = new(zone) Range(int32_value_, int32_value_);
     result->set_can_be_minus_zero(false);
     return result;
   }
   return HValue::InferRange(zone);
 }
 
 
+int HPhi::position() const {
+  return block()->first()->position();
+}
+
+
 Range* HPhi::InferRange(Zone* zone) {
   Representation r = representation();
   if (r.IsSmiOrInteger32()) {
     if (block()->IsLoopHeader()) {
       Range* range = r.IsSmi()
           ? new(zone) Range(Smi::kMinValue, Smi::kMaxValue)
           : new(zone) Range(kMinInt, kMaxInt);
       return range;
     } else {
       Range* range = OperandAt(0)->range()->Copy(zone);
@@ skipping 2666 matching lines @@
       break;
     case kExternalMemory:
       stream->Add("[external-memory]");
       break;
   }
 
   stream->Add("@%d", offset());
 }
 
 } }  // namespace v8::internal