Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2494833002: Revert of Replaced cc::SurfaceId::nonce_ with base::UnguessableToken (Closed)

Created:
4 years, 1 month ago by Dirk Pranke
Modified:
4 years, 1 month ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, yzshen+watch_chromium.org, Stephen Chennney, rwlbuis, darin (slow to review), krit, drott+blinkwatch_chromium.org, Justin Novosad, abarth-chromium, Rik, blink-reviews-bindings_chromium.org, blink-reviews, ajuma+watch_chromium.org, pdr+graphicswatchlist_chromium.org, jbroman+watch_chromium.org, haraken, cc-bugs_chromium.org, Aaron Boodman, f(malita), danakj+watch_chromium.org, Fady Samuel
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Replaced cc::SurfaceId::nonce_ with base::UnguessableToken (patchset #25 id:480001 of https://codereview.chromium.org/2379653006/ ) Reason for revert: Looks like this added a static initializer to surface_manager.cc via the change to unguessable_token https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/28400/steps/sizes/logs/stdio Original issue's description: > Replaced cc::SurfaceId::nonce_ with base::UnguessableToken > > base::SurfaceId::nonce_ is an uint64 generated at random to make the entire > surface id unguessable. > base::UnguessableToken is a wrapper for 2 uint64 (high_ and low_). > high_ and low_ are generated at random using base::UnguessableToken::Create(). > base::UnguessableToken achieves the same goal as the original > cc::SurfaceId::nonce_ with better security and uses more common code. > > BUG=649800 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > > Committed: https://crrev.com/6b01e58ff708c17f74b560fe1b57f7733b78da53 > Cr-Commit-Position: refs/heads/master@{#431294} TBR=danakj@chromium.org,tsepez@chromium.org,fsamuel@chromium.org,jbroman@chromium.org,haraken@chromium.org,vmpstr@chromium.org,sky@chromium.org,dcheng@chromium.org,staraz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=649800 Committed: https://crrev.com/d75809ef13714bcc4e960779d2178d9f99783147 Cr-Commit-Position: refs/heads/master@{#431330}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -237 lines) Patch
M base/unguessable_token.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/ipc/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M cc/ipc/cc_param_traits.cc View 2 chunks +1 line, -2 lines 0 comments Download
M cc/ipc/cc_param_traits_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M cc/ipc/local_frame_id.mojom View 1 chunk +3 lines, -2 lines 0 comments Download
M cc/ipc/local_frame_id_struct_traits.h View 2 chunks +2 lines, -8 lines 0 comments Download
M cc/ipc/struct_traits_unittest.cc View 4 chunks +4 lines, -9 lines 0 comments Download
M cc/layers/surface_layer_impl_unittest.cc View 2 chunks +1 line, -3 lines 0 comments Download
M cc/layers/surface_layer_unittest.cc View 9 chunks +14 lines, -21 lines 0 comments Download
M cc/quads/draw_quad_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M cc/surfaces/display_scheduler_unittest.cc View 11 chunks +25 lines, -50 lines 0 comments Download
M cc/surfaces/local_frame_id.h View 2 chunks +8 lines, -14 lines 0 comments Download
M cc/surfaces/surface_aggregator_perftest.cc View 6 chunks +12 lines, -16 lines 0 comments Download
M cc/surfaces/surface_aggregator_unittest.cc View 7 chunks +11 lines, -14 lines 0 comments Download
M cc/surfaces/surface_factory_unittest.cc View 9 chunks +9 lines, -11 lines 0 comments Download
M cc/surfaces/surface_hittest_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M cc/surfaces/surface_id.h View 1 chunk +8 lines, -4 lines 0 comments Download
M cc/surfaces/surface_id_allocator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/surfaces/surface_manager.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M cc/surfaces/surface_manager_ref_unittest.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M cc/surfaces/surface_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/ws/frame_generator_unittest.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.h View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp View 6 chunks +8 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueDeserializer.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializer.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.h View 2 chunks +4 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModule.cpp View 1 chunk +1 line, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/CanvasSurfaceLayerBridgeTest.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp View 1 chunk +3 lines, -7 lines 0 comments Download
M ui/compositor/layer_unittest.cc View 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Dirk Pranke
Created Revert of Replaced cc::SurfaceId::nonce_ with base::UnguessableToken
4 years, 1 month ago (2016-11-10 20:03:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2494833002/1
4 years, 1 month ago (2016-11-10 20:03:41 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-10 20:05:12 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 20:14:23 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d75809ef13714bcc4e960779d2178d9f99783147
Cr-Commit-Position: refs/heads/master@{#431330}

Powered by Google App Engine
This is Rietveld 408576698