Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Side by Side Diff: cc/layers/surface_layer_unittest.cc

Issue 2494833002: Revert of Replaced cc::SurfaceId::nonce_ with base::UnguessableToken (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/layers/surface_layer_impl_unittest.cc ('k') | cc/quads/draw_quad_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stdint.h> 5 #include <stdint.h>
6 6
7 #include <set> 7 #include <set>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/location.h" 10 #include "base/location.h"
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
62 std::set<SurfaceSequence>* out, 62 std::set<SurfaceSequence>* out,
63 const SurfaceId& in_id, 63 const SurfaceId& in_id,
64 const SurfaceSequence& in) { 64 const SurfaceSequence& in) {
65 *out_id = in_id; 65 *out_id = in_id;
66 out->insert(in); 66 out->insert(in);
67 } 67 }
68 68
69 // Check that one surface can be referenced by multiple LayerTreeHosts, and 69 // Check that one surface can be referenced by multiple LayerTreeHosts, and
70 // each will create its own SurfaceSequence that's satisfied on destruction. 70 // each will create its own SurfaceSequence that's satisfied on destruction.
71 TEST_F(SurfaceLayerTest, MultipleFramesOneSurface) { 71 TEST_F(SurfaceLayerTest, MultipleFramesOneSurface) {
72 const base::UnguessableToken kArbitraryToken =
73 base::UnguessableToken::Create();
74 SurfaceSequence blank_change; // Receives sequence if commit doesn't happen. 72 SurfaceSequence blank_change; // Receives sequence if commit doesn't happen.
75 73
76 SurfaceId required_id; 74 SurfaceId required_id;
77 std::set<SurfaceSequence> required_seq; 75 std::set<SurfaceSequence> required_seq;
78 scoped_refptr<SurfaceLayer> layer(SurfaceLayer::Create( 76 scoped_refptr<SurfaceLayer> layer(SurfaceLayer::Create(
79 base::Bind(&SatisfyCallback, &blank_change), 77 base::Bind(&SatisfyCallback, &blank_change),
80 base::Bind(&RequireCallback, &required_id, &required_seq))); 78 base::Bind(&RequireCallback, &required_id, &required_seq)));
81 layer->SetSurfaceId( 79 layer->SetSurfaceId(SurfaceId(kArbitraryFrameSinkId, LocalFrameId(1, 0)), 1.f,
82 SurfaceId(kArbitraryFrameSinkId, LocalFrameId(1, kArbitraryToken)), 1.f, 80 gfx::Size(1, 1));
83 gfx::Size(1, 1));
84 layer_tree_host_->GetSurfaceSequenceGenerator()->set_frame_sink_id( 81 layer_tree_host_->GetSurfaceSequenceGenerator()->set_frame_sink_id(
85 FrameSinkId(1, 1)); 82 FrameSinkId(1, 1));
86 layer_tree_->SetRootLayer(layer); 83 layer_tree_->SetRootLayer(layer);
87 84
88 auto animation_host2 = AnimationHost::CreateForTesting(ThreadInstance::MAIN); 85 auto animation_host2 = AnimationHost::CreateForTesting(ThreadInstance::MAIN);
89 std::unique_ptr<FakeLayerTreeHost> layer_tree_host2 = 86 std::unique_ptr<FakeLayerTreeHost> layer_tree_host2 =
90 FakeLayerTreeHost::Create(&fake_client_, &task_graph_runner_, 87 FakeLayerTreeHost::Create(&fake_client_, &task_graph_runner_,
91 animation_host2.get()); 88 animation_host2.get());
92 scoped_refptr<SurfaceLayer> layer2(SurfaceLayer::Create( 89 scoped_refptr<SurfaceLayer> layer2(SurfaceLayer::Create(
93 base::Bind(&SatisfyCallback, &blank_change), 90 base::Bind(&SatisfyCallback, &blank_change),
94 base::Bind(&RequireCallback, &required_id, &required_seq))); 91 base::Bind(&RequireCallback, &required_id, &required_seq)));
95 layer2->SetSurfaceId( 92 layer2->SetSurfaceId(SurfaceId(kArbitraryFrameSinkId, LocalFrameId(1, 0)),
96 SurfaceId(kArbitraryFrameSinkId, LocalFrameId(1, kArbitraryToken)), 1.f, 93 1.f, gfx::Size(1, 1));
97 gfx::Size(1, 1));
98 layer_tree_host2->GetSurfaceSequenceGenerator()->set_frame_sink_id( 94 layer_tree_host2->GetSurfaceSequenceGenerator()->set_frame_sink_id(
99 FrameSinkId(2, 2)); 95 FrameSinkId(2, 2));
100 layer_tree_host2->SetRootLayer(layer2); 96 layer_tree_host2->SetRootLayer(layer2);
101 97
102 // Layers haven't been removed, so no sequence should be satisfied. 98 // Layers haven't been removed, so no sequence should be satisfied.
103 EXPECT_FALSE(blank_change.is_valid()); 99 EXPECT_FALSE(blank_change.is_valid());
104 100
105 SurfaceSequence expected1(FrameSinkId(1, 1), 1u); 101 SurfaceSequence expected1(FrameSinkId(1, 1), 1u);
106 SurfaceSequence expected2(FrameSinkId(2, 2), 1u); 102 SurfaceSequence expected2(FrameSinkId(2, 2), 1u);
107 103
108 layer_tree_host2->SetRootLayer(nullptr); 104 layer_tree_host2->SetRootLayer(nullptr);
109 layer_tree_host2.reset(); 105 layer_tree_host2.reset();
110 animation_host2 = nullptr; 106 animation_host2 = nullptr;
111 107
112 // Layer was removed so sequence from second LayerTreeHost should be 108 // Layer was removed so sequence from second LayerTreeHost should be
113 // satisfied. 109 // satisfied.
114 EXPECT_TRUE(blank_change == expected2); 110 EXPECT_TRUE(blank_change == expected2);
115 111
116 // Set of sequences that need to be satisfied should include sequences from 112 // Set of sequences that need to be satisfied should include sequences from
117 // both trees. 113 // both trees.
118 EXPECT_TRUE(required_id == SurfaceId(kArbitraryFrameSinkId, 114 EXPECT_TRUE(required_id ==
119 LocalFrameId(1, kArbitraryToken))); 115 SurfaceId(kArbitraryFrameSinkId, LocalFrameId(1, 0)));
120 EXPECT_EQ(2u, required_seq.size()); 116 EXPECT_EQ(2u, required_seq.size());
121 EXPECT_TRUE(required_seq.count(expected1)); 117 EXPECT_TRUE(required_seq.count(expected1));
122 EXPECT_TRUE(required_seq.count(expected2)); 118 EXPECT_TRUE(required_seq.count(expected2));
123 119
124 layer_tree_->SetRootLayer(nullptr); 120 layer_tree_->SetRootLayer(nullptr);
125 layer_tree_host_.reset(); 121 layer_tree_host_.reset();
126 122
127 // Layer was removed so sequence from first LayerTreeHost should be 123 // Layer was removed so sequence from first LayerTreeHost should be
128 // satisfied. 124 // satisfied.
129 EXPECT_TRUE(blank_change == expected1); 125 EXPECT_TRUE(blank_change == expected1);
130 126
131 // No more SurfaceSequences should have been generated that need to have be 127 // No more SurfaceSequences should have been generated that need to have be
132 // satisfied. 128 // satisfied.
133 EXPECT_EQ(2u, required_seq.size()); 129 EXPECT_EQ(2u, required_seq.size());
134 } 130 }
135 131
136 // Check that SurfaceSequence is sent through swap promise. 132 // Check that SurfaceSequence is sent through swap promise.
137 class SurfaceLayerSwapPromise : public LayerTreeTest { 133 class SurfaceLayerSwapPromise : public LayerTreeTest {
138 public: 134 public:
139 SurfaceLayerSwapPromise() 135 SurfaceLayerSwapPromise()
140 : commit_count_(0), sequence_was_satisfied_(false) {} 136 : commit_count_(0), sequence_was_satisfied_(false) {}
141 137
142 void BeginTest() override { 138 void BeginTest() override {
143 layer_tree_host()->GetSurfaceSequenceGenerator()->set_frame_sink_id( 139 layer_tree_host()->GetSurfaceSequenceGenerator()->set_frame_sink_id(
144 FrameSinkId(1, 1)); 140 FrameSinkId(1, 1));
145 layer_ = SurfaceLayer::Create( 141 layer_ = SurfaceLayer::Create(
146 base::Bind(&SatisfyCallback, &satisfied_sequence_), 142 base::Bind(&SatisfyCallback, &satisfied_sequence_),
147 base::Bind(&RequireCallback, &required_id_, &required_set_)); 143 base::Bind(&RequireCallback, &required_id_, &required_set_));
148 layer_->SetSurfaceId( 144 layer_->SetSurfaceId(SurfaceId(kArbitraryFrameSinkId, LocalFrameId(1, 0)),
149 SurfaceId(kArbitraryFrameSinkId, LocalFrameId(1, kArbitraryToken)), 1.f, 145 1.f, gfx::Size(1, 1));
150 gfx::Size(1, 1));
151 146
152 // Layer hasn't been added to tree so no SurfaceSequence generated yet. 147 // Layer hasn't been added to tree so no SurfaceSequence generated yet.
153 EXPECT_EQ(0u, required_set_.size()); 148 EXPECT_EQ(0u, required_set_.size());
154 149
155 layer_tree()->SetRootLayer(layer_); 150 layer_tree()->SetRootLayer(layer_);
156 151
157 // Should have SurfaceSequence from first tree. 152 // Should have SurfaceSequence from first tree.
158 SurfaceSequence expected(kArbitraryFrameSinkId, 1u); 153 SurfaceSequence expected(kArbitraryFrameSinkId, 1u);
159 EXPECT_TRUE(required_id_ == SurfaceId(kArbitraryFrameSinkId, 154 EXPECT_TRUE(required_id_ ==
160 LocalFrameId(1, kArbitraryToken))); 155 SurfaceId(kArbitraryFrameSinkId, LocalFrameId(1, 0)));
161 EXPECT_EQ(1u, required_set_.size()); 156 EXPECT_EQ(1u, required_set_.size());
162 EXPECT_TRUE(required_set_.count(expected)); 157 EXPECT_TRUE(required_set_.count(expected));
163 158
164 gfx::Size bounds(100, 100); 159 gfx::Size bounds(100, 100);
165 layer_tree()->SetViewportSize(bounds); 160 layer_tree()->SetViewportSize(bounds);
166 161
167 blank_layer_ = SolidColorLayer::Create(); 162 blank_layer_ = SolidColorLayer::Create();
168 blank_layer_->SetIsDrawable(true); 163 blank_layer_->SetIsDrawable(true);
169 blank_layer_->SetBounds(gfx::Size(10, 10)); 164 blank_layer_->SetBounds(gfx::Size(10, 10));
170 165
(...skipping 10 matching lines...) Expand all
181 176
182 protected: 177 protected:
183 int commit_count_; 178 int commit_count_;
184 bool sequence_was_satisfied_; 179 bool sequence_was_satisfied_;
185 scoped_refptr<SurfaceLayer> layer_; 180 scoped_refptr<SurfaceLayer> layer_;
186 scoped_refptr<Layer> blank_layer_; 181 scoped_refptr<Layer> blank_layer_;
187 SurfaceSequence satisfied_sequence_; 182 SurfaceSequence satisfied_sequence_;
188 183
189 SurfaceId required_id_; 184 SurfaceId required_id_;
190 std::set<SurfaceSequence> required_set_; 185 std::set<SurfaceSequence> required_set_;
191 const base::UnguessableToken kArbitraryToken =
192 base::UnguessableToken::Create();
193 }; 186 };
194 187
195 // Check that SurfaceSequence is sent through swap promise. 188 // Check that SurfaceSequence is sent through swap promise.
196 class SurfaceLayerSwapPromiseWithDraw : public SurfaceLayerSwapPromise { 189 class SurfaceLayerSwapPromiseWithDraw : public SurfaceLayerSwapPromise {
197 public: 190 public:
198 void ChangeTree() override { 191 void ChangeTree() override {
199 ++commit_count_; 192 ++commit_count_;
200 switch (commit_count_) { 193 switch (commit_count_) {
201 case 1: 194 case 1:
202 // Remove SurfaceLayer from tree to cause SwapPromise to be created. 195 // Remove SurfaceLayer from tree to cause SwapPromise to be created.
(...skipping 16 matching lines...) Expand all
219 // after the layer was removed from the tree, and only once. 212 // after the layer was removed from the tree, and only once.
220 EXPECT_EQ(1u, satisfied[0]); 213 EXPECT_EQ(1u, satisfied[0]);
221 EXPECT_LE(1, commit_count_); 214 EXPECT_LE(1, commit_count_);
222 EXPECT_FALSE(sequence_was_satisfied_); 215 EXPECT_FALSE(sequence_was_satisfied_);
223 sequence_was_satisfied_ = true; 216 sequence_was_satisfied_ = true;
224 EndTest(); 217 EndTest();
225 } 218 }
226 } 219 }
227 220
228 void AfterTest() override { 221 void AfterTest() override {
229 EXPECT_TRUE(required_id_ == SurfaceId(kArbitraryFrameSinkId, 222 EXPECT_TRUE(required_id_ ==
230 LocalFrameId(1, kArbitraryToken))); 223 SurfaceId(kArbitraryFrameSinkId, LocalFrameId(1, 0)));
231 EXPECT_EQ(1u, required_set_.size()); 224 EXPECT_EQ(1u, required_set_.size());
232 // Sequence should have been satisfied through Swap, not with the 225 // Sequence should have been satisfied through Swap, not with the
233 // callback. 226 // callback.
234 EXPECT_FALSE(satisfied_sequence_.is_valid()); 227 EXPECT_FALSE(satisfied_sequence_.is_valid());
235 } 228 }
236 }; 229 };
237 230
238 SINGLE_AND_MULTI_THREAD_TEST_F(SurfaceLayerSwapPromiseWithDraw); 231 SINGLE_AND_MULTI_THREAD_TEST_F(SurfaceLayerSwapPromiseWithDraw);
239 232
240 // Check that SurfaceSequence is sent through swap promise and resolved when 233 // Check that SurfaceSequence is sent through swap promise and resolved when
(...skipping 18 matching lines...) Expand all
259 case 2: 252 case 2:
260 layer_tree_host()->SetNeedsCommit(); 253 layer_tree_host()->SetNeedsCommit();
261 break; 254 break;
262 default: 255 default:
263 EndTest(); 256 EndTest();
264 break; 257 break;
265 } 258 }
266 } 259 }
267 260
268 void AfterTest() override { 261 void AfterTest() override {
269 EXPECT_TRUE(required_id_ == SurfaceId(kArbitraryFrameSinkId, 262 EXPECT_TRUE(required_id_ ==
270 LocalFrameId(1, kArbitraryToken))); 263 SurfaceId(kArbitraryFrameSinkId, LocalFrameId(1, 0)));
271 EXPECT_EQ(1u, required_set_.size()); 264 EXPECT_EQ(1u, required_set_.size());
272 // Sequence should have been satisfied with the callback. 265 // Sequence should have been satisfied with the callback.
273 EXPECT_TRUE(satisfied_sequence_ == 266 EXPECT_TRUE(satisfied_sequence_ ==
274 SurfaceSequence(kArbitraryFrameSinkId, 1u)); 267 SurfaceSequence(kArbitraryFrameSinkId, 1u));
275 } 268 }
276 }; 269 };
277 270
278 MULTI_THREAD_TEST_F(SurfaceLayerSwapPromiseWithoutDraw); 271 MULTI_THREAD_TEST_F(SurfaceLayerSwapPromiseWithoutDraw);
279 272
280 } // namespace 273 } // namespace
281 } // namespace cc 274 } // namespace cc
OLDNEW
« no previous file with comments | « cc/layers/surface_layer_impl_unittest.cc ('k') | cc/quads/draw_quad_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698